* [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int
@ 2020-04-28 10:20 Colin King
2020-04-28 14:26 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Colin King @ 2020-04-28 10:20 UTC (permalink / raw)
To: Nilesh Javali, GR-QLogic-Storage-Upstream,
James E . J . Bottomley, Martin K . Petersen, Arun Easi,
Himanshu Madhani, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed
which is not recommended as the representation is an implementation defined
behaviour. Fix this by making the bit-fields unsigned ints.
Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/qla2xxx/qla_def.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index daa9e936887b..172ea4e5887d 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -4248,8 +4248,8 @@ struct qla_hw_data {
int fw_dump_reading;
void *mpi_fw_dump;
u32 mpi_fw_dump_len;
- int mpi_fw_dump_reading:1;
- int mpi_fw_dumped:1;
+ unsigned int mpi_fw_dump_reading:1;
+ unsigned int mpi_fw_dumped:1;
int prev_minidump_failed;
dma_addr_t eft_dma;
void *eft;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int
2020-04-28 10:20 [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int Colin King
@ 2020-04-28 14:26 ` Bart Van Assche
2020-04-28 14:50 ` himanshu.madhani
2020-04-30 2:18 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2020-04-28 14:26 UTC (permalink / raw)
To: Colin King, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E . J . Bottomley, Martin K . Petersen, Arun Easi,
Himanshu Madhani, linux-scsi
Cc: kernel-janitors, linux-kernel
On 2020-04-28 03:20, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed
> which is not recommended as the representation is an implementation defined
> behaviour. Fix this by making the bit-fields unsigned ints.
>
> Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/qla2xxx/qla_def.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index daa9e936887b..172ea4e5887d 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -4248,8 +4248,8 @@ struct qla_hw_data {
> int fw_dump_reading;
> void *mpi_fw_dump;
> u32 mpi_fw_dump_len;
> - int mpi_fw_dump_reading:1;
> - int mpi_fw_dumped:1;
> + unsigned int mpi_fw_dump_reading:1;
> + unsigned int mpi_fw_dumped:1;
> int prev_minidump_failed;
> dma_addr_t eft_dma;
> void *eft;
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int
2020-04-28 10:20 [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int Colin King
2020-04-28 14:26 ` Bart Van Assche
@ 2020-04-28 14:50 ` himanshu.madhani
2020-04-30 2:18 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: himanshu.madhani @ 2020-04-28 14:50 UTC (permalink / raw)
To: Colin King, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E . J . Bottomley, Martin K . Petersen, Arun Easi,
linux-scsi
Cc: kernel-janitors, linux-kernel
On 4/28/20 5:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed
> which is not recommended as the representation is an implementation defined
> behaviour. Fix this by making the bit-fields unsigned ints.
>
> Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/qla2xxx/qla_def.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index daa9e936887b..172ea4e5887d 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -4248,8 +4248,8 @@ struct qla_hw_data {
> int fw_dump_reading;
> void *mpi_fw_dump;
> u32 mpi_fw_dump_len;
> - int mpi_fw_dump_reading:1;
> - int mpi_fw_dumped:1;
> + unsigned int mpi_fw_dump_reading:1;
> + unsigned int mpi_fw_dumped:1;
> int prev_minidump_failed;
> dma_addr_t eft_dma;
> void *eft;
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani
Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int
2020-04-28 10:20 [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int Colin King
2020-04-28 14:26 ` Bart Van Assche
2020-04-28 14:50 ` himanshu.madhani
@ 2020-04-30 2:18 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-04-30 2:18 UTC (permalink / raw)
To: Arun Easi, Nilesh Javali, linux-scsi, James E . J . Bottomley,
GR-QLogic-Storage-Upstream, Colin King, Himanshu Madhani
Cc: Martin K . Petersen, linux-kernel, kernel-janitors
On Tue, 28 Apr 2020 11:20:13 +0100, Colin King wrote:
> The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed
> which is not recommended as the representation is an implementation defined
> behaviour. Fix this by making the bit-fields unsigned ints.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qla2xxx: make 1-bit bit-fields unsigned int
https://git.kernel.org/mkp/scsi/c/78b874b7cbf0
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-30 2:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 10:20 [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int Colin King
2020-04-28 14:26 ` Bart Van Assche
2020-04-28 14:50 ` himanshu.madhani
2020-04-30 2:18 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).