* [PATCH -next] net: ethernet: mediatek: Make mtk_m32 static
@ 2020-05-06 6:27 Samuel Zou
2020-05-06 21:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Zou @ 2020-05-06 6:27 UTC (permalink / raw)
To: nbd, john, sean.wang, Mark-MC.Lee, davem, matthias.bgg
Cc: netdev, linux-arm-kernel, linux-mediatek, linux-kernel, Samuel Zou
Fix the following sparse warning:
drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning:
symbol 'mtk_m32' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 0904710..2822268 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -65,7 +65,7 @@ u32 mtk_r32(struct mtk_eth *eth, unsigned reg)
return __raw_readl(eth->base + reg);
}
-u32 mtk_m32(struct mtk_eth *eth, u32 mask, u32 set, unsigned reg)
+static u32 mtk_m32(struct mtk_eth *eth, u32 mask, u32 set, unsigned reg)
{
u32 val;
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: ethernet: mediatek: Make mtk_m32 static
2020-05-06 6:27 [PATCH -next] net: ethernet: mediatek: Make mtk_m32 static Samuel Zou
@ 2020-05-06 21:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-05-06 21:03 UTC (permalink / raw)
To: zou_wei
Cc: nbd, john, sean.wang, Mark-MC.Lee, matthias.bgg, netdev,
linux-arm-kernel, linux-mediatek, linux-kernel
From: Samuel Zou <zou_wei@huawei.com>
Date: Wed, 6 May 2020 14:27:30 +0800
> Fix the following sparse warning:
>
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning:
> symbol 'mtk_m32' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-06 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 6:27 [PATCH -next] net: ethernet: mediatek: Make mtk_m32 static Samuel Zou
2020-05-06 21:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).