* [PATCH 0/2] sunrpc: add missing newline when printing module parameters by sysfs
@ 2020-05-08 1:32 Xiongfeng Wang
2020-05-08 1:32 ` [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' " Xiongfeng Wang
2020-05-08 1:33 ` [PATCH 2/2] sunrpc: add missing newline when printing parameter 'auth_hashtable_size' " Xiongfeng Wang
0 siblings, 2 replies; 4+ messages in thread
From: Xiongfeng Wang @ 2020-05-08 1:32 UTC (permalink / raw)
To: bfields, chuck.lever, trond.myklebust, anna.schumaker, davem, kuba
Cc: linux-nfs, netdev, linux-kernel, wangxiongfeng2
When I cat parameters below ''/sys/module/sunrpc/parameters/', I found the
following two parameter need a new line.
[root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/pool_mode
global[root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/auth_hashtable_size
16[root@hulk-202 ~]#
Xiongfeng Wang (2):
sunrpc: add missing newline when printing parameter 'pool_mode' by
sysfs
sunrpc: add missing newline when printing parameter
'auth_hashtable_size' by sysfs
net/sunrpc/auth.c | 2 +-
net/sunrpc/svc.c | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
--
1.7.12.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' by sysfs
2020-05-08 1:32 [PATCH 0/2] sunrpc: add missing newline when printing module parameters by sysfs Xiongfeng Wang
@ 2020-05-08 1:32 ` Xiongfeng Wang
2020-05-12 0:21 ` J. Bruce Fields
2020-05-08 1:33 ` [PATCH 2/2] sunrpc: add missing newline when printing parameter 'auth_hashtable_size' " Xiongfeng Wang
1 sibling, 1 reply; 4+ messages in thread
From: Xiongfeng Wang @ 2020-05-08 1:32 UTC (permalink / raw)
To: bfields, chuck.lever, trond.myklebust, anna.schumaker, davem, kuba
Cc: linux-nfs, netdev, linux-kernel, wangxiongfeng2
When I cat parameter '/sys/module/sunrpc/parameters/pool_mode', it
displays as follows. It is better to add a newline for easy reading.
[root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/pool_mode
global[root@hulk-202 ~]#
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
net/sunrpc/svc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 187dd4e..d8ef47f 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -88,15 +88,15 @@ struct svc_pool_map svc_pool_map = {
switch (*ip)
{
case SVC_POOL_AUTO:
- return strlcpy(buf, "auto", 20);
+ return strlcpy(buf, "auto\n", 20);
case SVC_POOL_GLOBAL:
- return strlcpy(buf, "global", 20);
+ return strlcpy(buf, "global\n", 20);
case SVC_POOL_PERCPU:
- return strlcpy(buf, "percpu", 20);
+ return strlcpy(buf, "percpu\n", 20);
case SVC_POOL_PERNODE:
- return strlcpy(buf, "pernode", 20);
+ return strlcpy(buf, "pernode\n", 20);
default:
- return sprintf(buf, "%d", *ip);
+ return sprintf(buf, "%d\n", *ip);
}
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] sunrpc: add missing newline when printing parameter 'auth_hashtable_size' by sysfs
2020-05-08 1:32 [PATCH 0/2] sunrpc: add missing newline when printing module parameters by sysfs Xiongfeng Wang
2020-05-08 1:32 ` [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' " Xiongfeng Wang
@ 2020-05-08 1:33 ` Xiongfeng Wang
1 sibling, 0 replies; 4+ messages in thread
From: Xiongfeng Wang @ 2020-05-08 1:33 UTC (permalink / raw)
To: bfields, chuck.lever, trond.myklebust, anna.schumaker, davem, kuba
Cc: linux-nfs, netdev, linux-kernel, wangxiongfeng2
When I cat parameter
'/sys/module/sunrpc/parameters/auth_hashtable_size', it displays as
follows. It is better to add a newline for easy reading.
[root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/auth_hashtable_size
16[root@hulk-202 ~]#
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
net/sunrpc/auth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c
index 5748ad0..a9f0d17 100644
--- a/net/sunrpc/auth.c
+++ b/net/sunrpc/auth.c
@@ -81,7 +81,7 @@ static int param_get_hashtbl_sz(char *buffer, const struct kernel_param *kp)
unsigned int nbits;
nbits = *(unsigned int *)kp->arg;
- return sprintf(buffer, "%u", 1U << nbits);
+ return sprintf(buffer, "%u\n", 1U << nbits);
}
#define param_check_hashtbl_sz(name, p) __param_check(name, p, unsigned int);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' by sysfs
2020-05-08 1:32 ` [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' " Xiongfeng Wang
@ 2020-05-12 0:21 ` J. Bruce Fields
0 siblings, 0 replies; 4+ messages in thread
From: J. Bruce Fields @ 2020-05-12 0:21 UTC (permalink / raw)
To: Xiongfeng Wang
Cc: chuck.lever, trond.myklebust, anna.schumaker, davem, kuba,
linux-nfs, netdev, linux-kernel
On Fri, May 08, 2020 at 09:32:59AM +0800, Xiongfeng Wang wrote:
> When I cat parameter '/sys/module/sunrpc/parameters/pool_mode', it
> displays as follows. It is better to add a newline for easy reading.
Applying for 5.8. I assume Trond's getting the other patch.
--b.
>
> [root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/pool_mode
> global[root@hulk-202 ~]#
>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> ---
> net/sunrpc/svc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 187dd4e..d8ef47f 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -88,15 +88,15 @@ struct svc_pool_map svc_pool_map = {
> switch (*ip)
> {
> case SVC_POOL_AUTO:
> - return strlcpy(buf, "auto", 20);
> + return strlcpy(buf, "auto\n", 20);
> case SVC_POOL_GLOBAL:
> - return strlcpy(buf, "global", 20);
> + return strlcpy(buf, "global\n", 20);
> case SVC_POOL_PERCPU:
> - return strlcpy(buf, "percpu", 20);
> + return strlcpy(buf, "percpu\n", 20);
> case SVC_POOL_PERNODE:
> - return strlcpy(buf, "pernode", 20);
> + return strlcpy(buf, "pernode\n", 20);
> default:
> - return sprintf(buf, "%d", *ip);
> + return sprintf(buf, "%d\n", *ip);
> }
> }
>
> --
> 1.7.12.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-12 0:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 1:32 [PATCH 0/2] sunrpc: add missing newline when printing module parameters by sysfs Xiongfeng Wang
2020-05-08 1:32 ` [PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' " Xiongfeng Wang
2020-05-12 0:21 ` J. Bruce Fields
2020-05-08 1:33 ` [PATCH 2/2] sunrpc: add missing newline when printing parameter 'auth_hashtable_size' " Xiongfeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).