* [v1] drm/bridge: ensure bridge suspend happens during PM sleep
@ 2020-04-22 9:04 Harigovindan P
2020-05-12 20:26 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Harigovindan P @ 2020-04-22 9:04 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree
Cc: Harigovindan P, linux-kernel, robdclark, seanpaul, hoegsberg,
kalyan_t, nganji
ti-sn65dsi86 bridge is enumerated as a runtime device.
Adding sleep ops to force runtime_suspend when PM suspend is
requested on the device.
This change needs to be taken along with the series:
https://patchwork.kernel.org/patch/11494309/
Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 6ad688b320ae..2eef755b2917 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -159,6 +159,8 @@ static int __maybe_unused ti_sn_bridge_suspend(struct device *dev)
static const struct dev_pm_ops ti_sn_bridge_pm_ops = {
SET_RUNTIME_PM_OPS(ti_sn_bridge_suspend, ti_sn_bridge_resume, NULL)
+ SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+ pm_runtime_force_resume)
};
static int status_show(struct seq_file *s, void *data)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [v1] drm/bridge: ensure bridge suspend happens during PM sleep
2020-04-22 9:04 [v1] drm/bridge: ensure bridge suspend happens during PM sleep Harigovindan P
@ 2020-05-12 20:26 ` Stephen Boyd
2020-05-28 21:37 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2020-05-12 20:26 UTC (permalink / raw)
To: Harigovindan P, devicetree, dri-devel, freedreno, linux-arm-msm
Cc: Harigovindan P, linux-kernel, robdclark, seanpaul, hoegsberg,
kalyan_t, nganji, dianders
The subject is not specific enough. I'd expect it to be something like:
drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep
Quoting Harigovindan P (2020-04-22 02:04:43)
> ti-sn65dsi86 bridge is enumerated as a runtime device.
>
> Adding sleep ops to force runtime_suspend when PM suspend is
> requested on the device.
>
> This change needs to be taken along with the series:
> https://patchwork.kernel.org/patch/11494309/
Why? It doesn't seem like it should be required to go along with a qcom
specific driver patch.
>
> Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
> ---
Besides the subject:
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v1] drm/bridge: ensure bridge suspend happens during PM sleep
2020-05-12 20:26 ` Stephen Boyd
@ 2020-05-28 21:37 ` Doug Anderson
0 siblings, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2020-05-28 21:37 UTC (permalink / raw)
To: Stephen Boyd
Cc: Harigovindan P,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
dri-devel, freedreno, linux-arm-msm, LKML, Rob Clark, Sean Paul,
Kristian H. Kristensen, Kalyan Thota, nganji, Sam Ravnborg
Hi,
On Tue, May 12, 2020 at 1:26 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> The subject is not specific enough. I'd expect it to be something like:
>
> drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep
>
> Quoting Harigovindan P (2020-04-22 02:04:43)
> > ti-sn65dsi86 bridge is enumerated as a runtime device.
> >
> > Adding sleep ops to force runtime_suspend when PM suspend is
> > requested on the device.
> >
> > This change needs to be taken along with the series:
> > https://patchwork.kernel.org/patch/11494309/
>
> Why? It doesn't seem like it should be required to go along with a qcom
> specific driver patch.
>
> >
> > Signed-off-by: Harigovindan P <harigovi@codeaurora.org>
> > ---
>
> Besides the subject:
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Are you planning to re-post with the changes Stephen requested? Maybe
CC Sam too who was nice enough to help land some of my recent changes
to this driver.
-Doug
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-28 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 9:04 [v1] drm/bridge: ensure bridge suspend happens during PM sleep Harigovindan P
2020-05-12 20:26 ` Stephen Boyd
2020-05-28 21:37 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).