linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static
@ 2020-05-14  1:26 ChenTao
  2020-05-14  1:37 ` Stanley Chu
  2020-05-15  1:10 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: ChenTao @ 2020-05-14  1:26 UTC (permalink / raw)
  To: stanley.chu, jejb, martin.petersen, matthias.bgg
  Cc: alim.akhtar, avri.altman, linux-scsi, linux-mediatek,
	linux-arm-kernel, linux-kernel, chentao107

Fix the following warning:

drivers/scsi/ufs/ufs-mediatek.c:585:6: warning:
symbol 'ufs_mtk_fixup_dev_quirks' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenTao <chentao107@huawei.com>
---
 drivers/scsi/ufs/ufs-mediatek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index c543142554d3..73e4a4f9a3a2 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -582,7 +582,7 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba)
 	return 0;
 }
 
-void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba)
+static void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba)
 {
 	struct ufs_dev_info *dev_info = &hba->dev_info;
 	u16 mid = dev_info->wmanufacturerid;
-- 
2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static
  2020-05-14  1:26 [PATCH -next] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static ChenTao
@ 2020-05-14  1:37 ` Stanley Chu
  2020-05-15  1:10 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Stanley Chu @ 2020-05-14  1:37 UTC (permalink / raw)
  To: ChenTao
  Cc: jejb, martin.petersen, matthias.bgg, linux-scsi, linux-kernel,
	avri.altman, linux-mediatek, alim.akhtar, linux-arm-kernel

Hi Tao,

On Thu, 2020-05-14 at 09:26 +0800, ChenTao wrote:
> Fix the following warning:
> 
> drivers/scsi/ufs/ufs-mediatek.c:585:6: warning:
> symbol 'ufs_mtk_fixup_dev_quirks' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: ChenTao <chentao107@huawei.com>
> ---
>  drivers/scsi/ufs/ufs-mediatek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c543142554d3..73e4a4f9a3a2 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -582,7 +582,7 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba)
>  	return 0;
>  }
>  
> -void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba)
> +static void ufs_mtk_fixup_dev_quirks(struct ufs_hba *hba)
>  {
>  	struct ufs_dev_info *dev_info = &hba->dev_info;
>  	u16 mid = dev_info->wmanufacturerid;

Thanks for fixing this.

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static
  2020-05-14  1:26 [PATCH -next] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static ChenTao
  2020-05-14  1:37 ` Stanley Chu
@ 2020-05-15  1:10 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-05-15  1:10 UTC (permalink / raw)
  To: jejb, matthias.bgg, ChenTao, stanley.chu
  Cc: Martin K . Petersen, linux-scsi, alim.akhtar, avri.altman,
	linux-mediatek, linux-arm-kernel, linux-kernel

On Thu, 14 May 2020 09:26:55 +0800, ChenTao wrote:

> Fix the following warning:
> 
> drivers/scsi/ufs/ufs-mediatek.c:585:6: warning:
> symbol 'ufs_mtk_fixup_dev_quirks' was not declared. Should it be static?

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static
      https://git.kernel.org/mkp/scsi/c/21d2b76831fd

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-15  1:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14  1:26 [PATCH -next] scsi: ufs-mediatek: Make ufs_mtk_fixup_dev_quirks static ChenTao
2020-05-14  1:37 ` Stanley Chu
2020-05-15  1:10 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).