* [PATCH 2/6] arm64: dts: rockchip: fix rtl8211f nodename for rk3328 Beelink A1
2020-03-21 21:54 [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
@ 2020-03-21 21:54 ` Johan Jonker
2020-03-21 21:54 ` [PATCH 3/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-nanopi4 Johan Jonker
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Johan Jonker @ 2020-03-21 21:54 UTC (permalink / raw)
To: heiko
Cc: robin.murphy, aballier, robh+dt, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
A test with the command below gives this error:
arch/arm64/boot/dts/rockchip/rk3328-a1.dt.yaml: phy@0:
'#phy-cells' is a required property
The rtl8211f node is used by a phy-handle.
The parent node is compatible with "snps,dwmac-mdio",
so change nodename to 'ethernet-phy', for which '#phy-cells'
is not a required property.
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/schemas/
phy/phy-provider.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
index 16f1656d5..fbd06a351 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
@@ -114,7 +114,7 @@
#address-cells = <1>;
#size-cells = <0>;
- rtl8211f: phy@0 {
+ rtl8211f: ethernet-phy@0 {
reg = <0>;
reset-assert-us = <10000>;
reset-deassert-us = <30000>;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-nanopi4
2020-03-21 21:54 [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
2020-03-21 21:54 ` [PATCH 2/6] arm64: dts: rockchip: fix rtl8211f nodename for rk3328 Beelink A1 Johan Jonker
@ 2020-03-21 21:54 ` Johan Jonker
2020-03-21 21:54 ` [PATCH 4/6] arm64: dts: rockchip: fix &pinctrl phy sub " Johan Jonker
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Johan Jonker @ 2020-03-21 21:54 UTC (permalink / raw)
To: heiko
Cc: robin.murphy, aballier, robh+dt, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
A test with the command below gives these errors:
arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dt.yaml: phy@1:
'#phy-cells' is a required property
arch/arm64/boot/dts/rockchip/rk3399-nanopi-m4.dt.yaml: phy@1:
'#phy-cells' is a required property
arch/arm64/boot/dts/rockchip/rk3399-nanopi-neo4.dt.yaml: phy@1:
'#phy-cells' is a required property
The rtl8211e node is used by a phy-handle.
The parent node is compatible with "snps,dwmac-mdio",
so change nodename to 'ethernet-phy', for which '#phy-cells'
is not a required property.
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/schemas/
phy/phy-provider.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
index c88018a0e..20529105c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
@@ -182,7 +182,7 @@
#address-cells = <1>;
#size-cells = <0>;
- rtl8211e: phy@1 {
+ rtl8211e: ethernet-phy@1 {
reg = <1>;
interrupt-parent = <&gpio3>;
interrupts = <RK_PB2 IRQ_TYPE_LEVEL_LOW>;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/6] arm64: dts: rockchip: fix &pinctrl phy sub nodename for rk3399-nanopi4
2020-03-21 21:54 [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
2020-03-21 21:54 ` [PATCH 2/6] arm64: dts: rockchip: fix rtl8211f nodename for rk3328 Beelink A1 Johan Jonker
2020-03-21 21:54 ` [PATCH 3/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-nanopi4 Johan Jonker
@ 2020-03-21 21:54 ` Johan Jonker
2020-03-21 21:54 ` [PATCH 5/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-orangepi Johan Jonker
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Johan Jonker @ 2020-03-21 21:54 UTC (permalink / raw)
To: heiko
Cc: robin.murphy, aballier, robh+dt, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
A test with the command below gives for example this error:
arch/arm64/boot/dts/rockchip/rk3399-nanopc-t4.dt.yaml: phy:
'#phy-cells' is a required property
arch/arm64/boot/dts/rockchip/rk3399-nanopi-m4.dt.yaml: phy:
'#phy-cells' is a required property
arch/arm64/boot/dts/rockchip/rk3399-nanopi-neo4.dt.yaml: phy:
'#phy-cells' is a required property
'phy' is a reserved nodename and should not be used for pinctrl,
so change it to 'gmac'.
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/schemas/
phy/phy-provider.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
index 20529105c..1d246c2ca 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
@@ -525,7 +525,7 @@
};
};
- phy {
+ gmac {
phy_intb: phy-intb {
rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
};
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-orangepi
2020-03-21 21:54 [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
` (2 preceding siblings ...)
2020-03-21 21:54 ` [PATCH 4/6] arm64: dts: rockchip: fix &pinctrl phy sub " Johan Jonker
@ 2020-03-21 21:54 ` Johan Jonker
2020-03-21 21:54 ` [PATCH 6/6] arm64: dts: rockchip: fix &pinctrl phy sub " Johan Jonker
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Johan Jonker @ 2020-03-21 21:54 UTC (permalink / raw)
To: heiko
Cc: robin.murphy, aballier, robh+dt, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
A test with the command below gives this error:
arch/arm64/boot/dts/rockchip/rk3399-orangepi.dt.yaml: phy@1:
'#phy-cells' is a required property
The phy nodename is used by a phy-handle.
The parent node is compatible with "snps,dwmac-mdio",
so change nodename to 'ethernet-phy', for which '#phy-cells'
is not a required property
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/schemas/
phy/phy-provider.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
index f9f7246d4..afbcd213c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
@@ -214,7 +214,7 @@
#address-cells = <1>;
#size-cells = <0>;
- rtl8211e: phy@1 {
+ rtl8211e: ethernet-phy@1 {
reg = <1>;
interrupt-parent = <&gpio3>;
interrupts = <RK_PB2 IRQ_TYPE_LEVEL_LOW>;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 6/6] arm64: dts: rockchip: fix &pinctrl phy sub nodename for rk3399-orangepi
2020-03-21 21:54 [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
` (3 preceding siblings ...)
2020-03-21 21:54 ` [PATCH 5/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-orangepi Johan Jonker
@ 2020-03-21 21:54 ` Johan Jonker
2020-05-05 17:02 ` [PATCH v2] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
2020-05-18 22:27 ` [PATCH 1/6] " Heiko Stuebner
6 siblings, 0 replies; 9+ messages in thread
From: Johan Jonker @ 2020-03-21 21:54 UTC (permalink / raw)
To: heiko
Cc: robin.murphy, aballier, robh+dt, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
A test with the command below this error:
arch/arm64/boot/dts/rockchip/rk3399-orangepi.dt.yaml: phy:
'#phy-cells' is a required property
'phy' is a reserved nodename and should not be used for pinctrl,
so change it to 'gmac'.
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/schemas/
phy/phy-provider.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
index afbcd213c..6163ae806 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts
@@ -554,7 +554,7 @@
};
};
- phy {
+ gmac {
phy_intb: phy-intb {
rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
};
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2] arm64: dts: rockchip: fix phy nodename for rk3328
2020-03-21 21:54 [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
` (4 preceding siblings ...)
2020-03-21 21:54 ` [PATCH 6/6] arm64: dts: rockchip: fix &pinctrl phy sub " Johan Jonker
@ 2020-05-05 17:02 ` Johan Jonker
2020-05-18 22:28 ` Heiko Stuebner
2020-05-18 22:27 ` [PATCH 1/6] " Heiko Stuebner
6 siblings, 1 reply; 9+ messages in thread
From: Johan Jonker @ 2020-05-05 17:02 UTC (permalink / raw)
To: heiko; +Cc: robh+dt, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
A test with the command below gives for example this error:
arch/arm64/boot/dts/rockchip/rk3328-evb.dt.yaml: phy@0:
'#phy-cells' is a required property
The phy nodename is normally used by a phy-handle.
This node is however compatible with
"ethernet-phy-id1234.d400", "ethernet-phy-ieee802.3-c22"
which is just been added to 'ethernet-phy.yaml'.
So change nodename to 'ethernet-phy' for which '#phy-cells'
is not a required property
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/schemas/
phy/phy-provider.yaml
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Changes v2:
Reword commit message in the same way as in the patches for
'rk3228-evb.dts' and 'rk3229-xms6.dts'
that are already aproved.
Patch 2-6 of version 1 unchanged.
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index 931a9279e..fdf0e1b26 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -935,7 +935,7 @@
#address-cells = <1>;
#size-cells = <0>;
- phy: phy@0 {
+ phy: ethernet-phy@0 {
compatible = "ethernet-phy-id1234.d400", "ethernet-phy-ieee802.3-c22";
reg = <0>;
clocks = <&cru SCLK_MAC2PHY_OUT>;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] arm64: dts: rockchip: fix phy nodename for rk3328
2020-05-05 17:02 ` [PATCH v2] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
@ 2020-05-18 22:28 ` Heiko Stuebner
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2020-05-18 22:28 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, devicetree, linux-rockchip, robh+dt,
linux-arm-kernel, linux-kernel
On Tue, 5 May 2020 19:02:27 +0200, Johan Jonker wrote:
> A test with the command below gives for example this error:
>
> arch/arm64/boot/dts/rockchip/rk3328-evb.dt.yaml: phy@0:
> '#phy-cells' is a required property
>
> The phy nodename is normally used by a phy-handle.
> This node is however compatible with
> "ethernet-phy-id1234.d400", "ethernet-phy-ieee802.3-c22"
> which is just been added to 'ethernet-phy.yaml'.
> So change nodename to 'ethernet-phy' for which '#phy-cells'
> is not a required property
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: fix phy nodename for rk3328
commit: 8370cc5533b3baa5e0f18075ae638b050458aabd
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328
2020-03-21 21:54 [PATCH 1/6] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
` (5 preceding siblings ...)
2020-05-05 17:02 ` [PATCH v2] arm64: dts: rockchip: fix phy nodename for rk3328 Johan Jonker
@ 2020-05-18 22:27 ` Heiko Stuebner
6 siblings, 0 replies; 9+ messages in thread
From: Heiko Stuebner @ 2020-05-18 22:27 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, devicetree, linux-rockchip, robin.murphy,
linux-arm-kernel, robh+dt, linux-kernel, aballier
On Sat, 21 Mar 2020 22:54:18 +0100, Johan Jonker wrote:
> A test with the command below gives for example this error:
>
> arch/arm64/boot/dts/rockchip/rk3328-evb.dt.yaml: phy@0:
> '#phy-cells' is a required property
>
> The phy nodename is used by a phy-handle.
> The parent node is compatible with "snps,dwmac-mdio",
> so change nodename to 'ethernet-phy', for which '#phy-cells'
> is not a required property
>
> [...]
Applied, thanks!
[1/6] arm64: dts: rockchip: fix phy nodename for rk3328
commit: 8370cc5533b3baa5e0f18075ae638b050458aabd
[2/6] arm64: dts: rockchip: fix rtl8211f nodename for rk3328 Beelink A1
commit: 63834d1edb96e2016191e53444934299bbc06bb1
[3/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-nanopi4
commit: b450d1c566bd726f93bc72a3cf3155cecebc1b75
[4/6] arm64: dts: rockchip: fix &pinctrl phy sub nodename for rk3399-nanopi4
commit: 737157f9618b40c7147cf697aec431ce9dd178a0
[5/6] arm64: dts: rockchip: fix rtl8211e nodename for rk3399-orangepi
commit: b2bb769100d49c6acbfb2756cc4748aac09209c9
[6/6] arm64: dts: rockchip: fix &pinctrl phy sub nodename for rk3399-orangepi
commit: 302a729c84b59c835f7857ec378efecbda58b9b3
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 9+ messages in thread