* [PATCH -next] scsi: ibmvscsi: Make some functions static
@ 2020-05-20 9:10 Chen Tao
2020-05-27 2:12 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Chen Tao @ 2020-05-20 9:10 UTC (permalink / raw)
To: jejb, martin.petersen
Cc: tyreld, mpe, benh, paulus, linux-scsi, linuxppc-dev,
linux-kernel, chentao107
Fix the following warning:
drivers/scsi/ibmvscsi/ibmvscsi.c:2387:12: warning: symbol
'ibmvscsi_module_init' was not declared. Should it be static?
drivers/scsi/ibmvscsi/ibmvscsi.c:2409:13: warning: symbol
'ibmvscsi_module_exit' was not declared. Should it be static?
Signed-off-by: Chen Tao <chentao107@huawei.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 59f0f1030c54..44e64aa21194 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -2384,7 +2384,7 @@ static struct vio_driver ibmvscsi_driver = {
static struct srp_function_template ibmvscsi_transport_functions = {
};
-int __init ibmvscsi_module_init(void)
+static int __init ibmvscsi_module_init(void)
{
int ret;
@@ -2406,7 +2406,7 @@ int __init ibmvscsi_module_init(void)
return ret;
}
-void __exit ibmvscsi_module_exit(void)
+static void __exit ibmvscsi_module_exit(void)
{
vio_unregister_driver(&ibmvscsi_driver);
srp_release_transport(ibmvscsi_transport_template);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: ibmvscsi: Make some functions static
2020-05-20 9:10 [PATCH -next] scsi: ibmvscsi: Make some functions static Chen Tao
@ 2020-05-27 2:12 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-05-27 2:12 UTC (permalink / raw)
To: jejb, Chen Tao
Cc: Martin K . Petersen, linux-scsi, mpe, tyreld, benh, linux-kernel,
linuxppc-dev, paulus
On Wed, 20 May 2020 17:10:36 +0800, Chen Tao wrote:
> Fix the following warning:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:2387:12: warning: symbol
> 'ibmvscsi_module_init' was not declared. Should it be static?
> drivers/scsi/ibmvscsi/ibmvscsi.c:2409:13: warning: symbol
> 'ibmvscsi_module_exit' was not declared. Should it be static?
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ibmvscsi: Make some functions static
https://git.kernel.org/mkp/scsi/c/1f93ad177d24
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-27 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 9:10 [PATCH -next] scsi: ibmvscsi: Make some functions static Chen Tao
2020-05-27 2:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).