linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com,
	hkallweit1@gmail.com, richardcochran@gmail.com,
	alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com, allan.nielsen@microchip.com,
	foss@0leil.net
Subject: Re: [PATCH net-next 5/8] net: phy: mscc: 1588 block initialization
Date: Thu, 28 May 2020 08:57:42 +0200	[thread overview]
Message-ID: <159064906267.314251.13734785844479438819@kwain> (raw)
In-Reply-To: <20200527103513.05ee36e9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>

Hello Jakub,

Quoting Jakub Kicinski (2020-05-27 19:35:13)
> 
> This doesn't build on my system :S

I'll have a look at this and fix it for v2.

Thanks for reporting it!
Antoine

> 
> In file included from ../drivers/net/phy/mscc/mscc_ptp.c:18:
> ../include/linux/unaligned/be_byteshift.h:41:19: error: redefinition of ‘get_unaligned_be16’
>    41 | static inline u16 get_unaligned_be16(const void *p)
>       |                   ^~~~~~~~~~~~~~~~~~
> In file included from ../arch/x86/include/asm/unaligned.h:9,
>                  from ../include/linux/etherdevice.h:24,
>                  from ../include/linux/if_vlan.h:11,
>                  from ../include/linux/filter.h:22,
>                  from ../include/net/sock.h:59,
>                  from ../include/net/inet_sock.h:22,
>                  from ../include/linux/udp.h:16,
>                  from ../drivers/net/phy/mscc/mscc_ptp.c:17:
> ../include/linux/unaligned/access_ok.h:23:28: note: previous definition of ‘get_unaligned_be16’ was here
>    23 | static __always_inline u16 get_unaligned_be16(const void *p)
>       |                            ^~~~~~~~~~~~~~~~~~
> In file included from ../drivers/net/phy/mscc/mscc_ptp.c:18:
> ../include/linux/unaligned/be_byteshift.h:46:19: error: redefinition of ‘get_unaligned_be32’
>    46 | static inline u32 get_unaligned_be32(const void *p)
>       |                   ^~~~~~~~~~~~~~~~~~
> In file included from ../arch/x86/include/asm/unaligned.h:9,
>                  from ../include/linux/etherdevice.h:24,
>                  from ../include/linux/if_vlan.h:11,
>                  from ../include/linux/filter.h:22,
>                  from ../include/net/sock.h:59,
>                  from ../include/net/inet_sock.h:22,
>                  from ../include/linux/udp.h:16,
>                  from ../drivers/net/phy/mscc/mscc_ptp.c:17:
> ../include/linux/unaligned/access_ok.h:28:28: note: previous definition of ‘get_unaligned_be32’ was here
>    28 | static __always_inline u32 get_unaligned_be32(const void *p)
>       |                            ^~~~~~~~~~~~~~~~~~
> In file included from ../drivers/net/phy/mscc/mscc_ptp.c:18:
> ../include/linux/unaligned/be_byteshift.h:51:19: error: redefinition of ‘get_unaligned_be64’
>    51 | static inline u64 get_unaligned_be64(const void *p)
>       |                   ^~~~~~~~~~~~~~~~~~
> In file included from ../arch/x86/include/asm/unaligned.h:9,
>                  from ../include/linux/etherdevice.h:24,
>                  from ../include/linux/if_vlan.h:11,
>                  from ../include/linux/filter.h:22,
>                  from ../include/net/sock.h:59,
>                  from ../include/net/inet_sock.h:22,
>                  from ../include/linux/udp.h:16,
>                  from ../drivers/net/phy/mscc/mscc_ptp.c:17:
> ../include/linux/unaligned/access_ok.h:33:28: note: previous definition of ‘get_unaligned_be64’ was here
>    33 | static __always_inline u64 get_unaligned_be64(const void *p)
>       |                            ^~~~~~~~~~~~~~~~~~
> In file included from ../drivers/net/phy/mscc/mscc_ptp.c:18:
> ../include/linux/unaligned/be_byteshift.h:56:20: error: redefinition of ‘put_unaligned_be16’
>    56 | static inline void put_unaligned_be16(u16 val, void *p)
>       |                    ^~~~~~~~~~~~~~~~~~
> In file included from ../arch/x86/include/asm/unaligned.h:9,
>                  from ../include/linux/etherdevice.h:24,
>                  from ../include/linux/if_vlan.h:11,
>                  from ../include/linux/filter.h:22,
>                  from ../include/net/sock.h:59,
>                  from ../include/net/inet_sock.h:22,
>                  from ../include/linux/udp.h:16,
>                  from ../drivers/net/phy/mscc/mscc_ptp.c:17:
> ../include/linux/unaligned/access_ok.h:53:29: note: previous definition of ‘put_unaligned_be16’ was here
>    53 | static __always_inline void put_unaligned_be16(u16 val, void *p)
>       |                             ^~~~~~~~~~~~~~~~~~
> In file included from ../drivers/net/phy/mscc/mscc_ptp.c:18:
> ../include/linux/unaligned/be_byteshift.h:61:20: error: redefinition of ‘put_unaligned_be32’
>    61 | static inline void put_unaligned_be32(u32 val, void *p)
>       |                    ^~~~~~~~~~~~~~~~~~
> In file included from ../arch/x86/include/asm/unaligned.h:9,
>                  from ../include/linux/etherdevice.h:24,
>                  from ../include/linux/if_vlan.h:11,
>                  from ../include/linux/filter.h:22,
>                  from ../include/net/sock.h:59,
>                  from ../include/net/inet_sock.h:22,
>                  from ../include/linux/udp.h:16,
>                  from ../drivers/net/phy/mscc/mscc_ptp.c:17:
> ../include/linux/unaligned/access_ok.h:58:29: note: previous definition of ‘put_unaligned_be32’ was here
>    58 | static __always_inline void put_unaligned_be32(u32 val, void *p)
>       |                             ^~~~~~~~~~~~~~~~~~
> In file included from ../drivers/net/phy/mscc/mscc_ptp.c:18:
> ../include/linux/unaligned/be_byteshift.h:66:20: error: redefinition of ‘put_unaligned_be64’
>    66 | static inline void put_unaligned_be64(u64 val, void *p)
>       |                    ^~~~~~~~~~~~~~~~~~
> In file included from ../arch/x86/include/asm/unaligned.h:9,
>                  from ../include/linux/etherdevice.h:24,
>                  from ../include/linux/if_vlan.h:11,
>                  from ../include/linux/filter.h:22,
>                  from ../include/net/sock.h:59,
>                  from ../include/net/inet_sock.h:22,
>                  from ../include/linux/udp.h:16,
>                  from ../drivers/net/phy/mscc/mscc_ptp.c:17:
> ../include/linux/unaligned/access_ok.h:63:29: note: previous definition of ‘put_unaligned_be64’ was here
>    63 | static __always_inline void put_unaligned_be64(u64 val, void *p)
>       |                             ^~~~~~~~~~~~~~~~~~
> ../drivers/net/phy/mscc/mscc_ptp.c:658:12: warning: ‘vsc85xx_ts_engine_init’ defined but not used [-Wunused-function]
>   658 | static int vsc85xx_ts_engine_init(struct phy_device *phydev, bool one_step)
>       |            ^~~~~~~~~~~~~~~~~~~~~~
> make[5]: *** [drivers/net/phy/mscc/mscc_ptp.o] Error 1
> make[4]: *** [drivers/net/phy/mscc] Error 2
> make[3]: *** [drivers/net/phy] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [drivers/net] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers] Error 2
> make: *** [sub-make] Error 2

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-05-28  6:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 16:41 [PATCH net-next 0/8] net: phy: mscc: PHC and timestamping support Antoine Tenart
2020-05-27 16:41 ` [PATCH net-next 1/8] net: phy: add support for a common probe between shared PHYs Antoine Tenart
2020-05-27 16:41 ` [PATCH net-next 2/8] net: phy: mscc: fix copyright and author information in MACsec Antoine Tenart
2020-05-27 16:41 ` [PATCH net-next 3/8] net: phy: mscc: remove the TR CLK disable magic value Antoine Tenart
2020-05-27 16:41 ` [PATCH net-next 4/8] net: phy: mscc: take into account the 1588 block in MACsec init Antoine Tenart
2020-05-27 16:41 ` [PATCH net-next 5/8] net: phy: mscc: 1588 block initialization Antoine Tenart
2020-05-27 17:35   ` Jakub Kicinski
2020-05-28  6:57     ` Antoine Tenart [this message]
2020-05-27 22:04   ` kbuild test robot
2020-05-27 16:41 ` [PATCH net-next 6/8] net: phy: mscc: timestamping and PHC support Antoine Tenart
2020-05-28 14:34   ` Richard Cochran
2020-05-28 15:23     ` Antoine Tenart
2020-05-27 16:41 ` [PATCH net-next 7/8] dt-bindings: net: phy: vsc8531: document the load/save GPIO Antoine Tenart
2020-05-27 16:41 ` [PATCH net-next 8/8] MIPS: dts: ocelot: describe " Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159064906267.314251.13734785844479438819@kwain \
    --to=antoine.tenart@bootlin.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allan.nielsen@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=foss@0leil.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).