* [PATCH V2 0/3] Convert mxs/imx spi/cspi/lpspi binding to json-schema
@ 2020-06-04 1:55 Anson Huang
2020-06-04 1:55 ` [PATCH V2 1/3] dt-bindings: spi: Convert mxs spi " Anson Huang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Anson Huang @ 2020-06-04 1:55 UTC (permalink / raw)
To: broonie, robh+dt, shawnguo, s.hauer, kernel, festevam, marex,
linux-spi, devicetree, linux-arm-kernel, linux-kernel
Cc: Linux-imx
This patch series converts mxs/imx spi/cspi/lpspi binding to json-schema.
In fsl-imx-cspi.yaml, also update compatible, remove obsolete properties
"fsl,spi-num-chipselects" and update the example based on latest DT file;
In spi-fsl-lpspi.yaml, the original maintainer's email address pandy.gao@nxp.com
is no longer valid, so I use mine.
Compared to V1, this patch series adds "unevaluatedProperties: false" for
each binding doc.
Anson Huang (3):
dt-bindings: spi: Convert mxs spi to json-schema
dt-bindings: spi: Convert imx cspi to json-schema
dt-bindings: spi: Convert imx lpspi to json-schema
.../devicetree/bindings/spi/fsl-imx-cspi.txt | 56 ------------
.../devicetree/bindings/spi/fsl-imx-cspi.yaml | 99 ++++++++++++++++++++++
Documentation/devicetree/bindings/spi/mxs-spi.txt | 26 ------
Documentation/devicetree/bindings/spi/mxs-spi.yaml | 57 +++++++++++++
.../devicetree/bindings/spi/spi-fsl-lpspi.txt | 29 -------
.../devicetree/bindings/spi/spi-fsl-lpspi.yaml | 62 ++++++++++++++
6 files changed, 218 insertions(+), 111 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
create mode 100644 Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml
delete mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt
create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.yaml
delete mode 100644 Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt
create mode 100644 Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V2 1/3] dt-bindings: spi: Convert mxs spi to json-schema 2020-06-04 1:55 [PATCH V2 0/3] Convert mxs/imx spi/cspi/lpspi binding to json-schema Anson Huang @ 2020-06-04 1:55 ` Anson Huang 2020-06-15 17:12 ` Rob Herring 2020-06-04 1:55 ` [PATCH V2 2/3] dt-bindings: spi: Convert imx cspi " Anson Huang 2020-06-04 1:55 ` [PATCH V2 3/3] dt-bindings: spi: Convert imx lpspi " Anson Huang 2 siblings, 1 reply; 6+ messages in thread From: Anson Huang @ 2020-06-04 1:55 UTC (permalink / raw) To: broonie, robh+dt, shawnguo, s.hauer, kernel, festevam, marex, linux-spi, devicetree, linux-arm-kernel, linux-kernel Cc: Linux-imx Convert the MXS SPI binding to DT schema format using json-schema Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V1: - add "unevaluatedProperties: false". --- Documentation/devicetree/bindings/spi/mxs-spi.txt | 26 ---------- Documentation/devicetree/bindings/spi/mxs-spi.yaml | 57 ++++++++++++++++++++++ 2 files changed, 57 insertions(+), 26 deletions(-) delete mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.yaml diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.txt b/Documentation/devicetree/bindings/spi/mxs-spi.txt deleted file mode 100644 index 3499b73..0000000 --- a/Documentation/devicetree/bindings/spi/mxs-spi.txt +++ /dev/null @@ -1,26 +0,0 @@ -* Freescale MX233/MX28 SSP/SPI - -Required properties: -- compatible: Should be "fsl,<soc>-spi", where soc is "imx23" or "imx28" -- reg: Offset and length of the register set for the device -- interrupts: Should contain SSP ERROR interrupt -- dmas: DMA specifier, consisting of a phandle to DMA controller node - and SSP DMA channel ID. - Refer to dma.txt and fsl-mxs-dma.txt for details. -- dma-names: Must be "rx-tx". - -Optional properties: -- clock-frequency : Input clock frequency to the SPI block in Hz. - Default is 160000000 Hz. - -Example: - -ssp0: ssp@80010000 { - #address-cells = <1>; - #size-cells = <0>; - compatible = "fsl,imx28-spi"; - reg = <0x80010000 0x2000>; - interrupts = <96>; - dmas = <&dma_apbh 0>; - dma-names = "rx-tx"; -}; diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.yaml b/Documentation/devicetree/bindings/spi/mxs-spi.yaml new file mode 100644 index 0000000..68c5d6d --- /dev/null +++ b/Documentation/devicetree/bindings/spi/mxs-spi.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/mxs-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale MX233/MX28 SSP/SPI + +maintainers: + - Marek Vasut <marex@denx.de> + +allOf: + - $ref: "/schemas/spi/spi-controller.yaml#" + +properties: + compatible: + enum: + - fsl,imx23-spi + - fsl,imx28-spi + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + dmas: + maxItems: 1 + + dma-names: + const: rx-tx + + clock-frequency: + $ref: /schemas/types.yaml#/definitions/uint32 + description: input clock frequency to the SPI block in Hz. + default: 160000000 + +required: + - compatible + - reg + - interrupts + - dmas + - dma-names + +unevaluatedProperties: false + +examples: + - | + spi@80010000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "fsl,imx28-spi"; + reg = <0x80010000 0x2000>; + interrupts = <96>; + dmas = <&dma_apbh 0>; + dma-names = "rx-tx"; + }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 1/3] dt-bindings: spi: Convert mxs spi to json-schema 2020-06-04 1:55 ` [PATCH V2 1/3] dt-bindings: spi: Convert mxs spi " Anson Huang @ 2020-06-15 17:12 ` Rob Herring 0 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2020-06-15 17:12 UTC (permalink / raw) To: Anson Huang Cc: broonie, shawnguo, s.hauer, kernel, festevam, marex, linux-spi, devicetree, linux-arm-kernel, linux-kernel, Linux-imx On Thu, Jun 04, 2020 at 09:55:29AM +0800, Anson Huang wrote: > Convert the MXS SPI binding to DT schema format using json-schema > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V1: > - add "unevaluatedProperties: false". > --- > Documentation/devicetree/bindings/spi/mxs-spi.txt | 26 ---------- > Documentation/devicetree/bindings/spi/mxs-spi.yaml | 57 ++++++++++++++++++++++ > 2 files changed, 57 insertions(+), 26 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt > create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.txt b/Documentation/devicetree/bindings/spi/mxs-spi.txt > deleted file mode 100644 > index 3499b73..0000000 > --- a/Documentation/devicetree/bindings/spi/mxs-spi.txt > +++ /dev/null > @@ -1,26 +0,0 @@ > -* Freescale MX233/MX28 SSP/SPI > - > -Required properties: > -- compatible: Should be "fsl,<soc>-spi", where soc is "imx23" or "imx28" > -- reg: Offset and length of the register set for the device > -- interrupts: Should contain SSP ERROR interrupt > -- dmas: DMA specifier, consisting of a phandle to DMA controller node > - and SSP DMA channel ID. > - Refer to dma.txt and fsl-mxs-dma.txt for details. > -- dma-names: Must be "rx-tx". > - > -Optional properties: > -- clock-frequency : Input clock frequency to the SPI block in Hz. > - Default is 160000000 Hz. > - > -Example: > - > -ssp0: ssp@80010000 { > - #address-cells = <1>; > - #size-cells = <0>; > - compatible = "fsl,imx28-spi"; > - reg = <0x80010000 0x2000>; > - interrupts = <96>; > - dmas = <&dma_apbh 0>; > - dma-names = "rx-tx"; > -}; > diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.yaml b/Documentation/devicetree/bindings/spi/mxs-spi.yaml > new file mode 100644 > index 0000000..68c5d6d > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/mxs-spi.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/mxs-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale MX233/MX28 SSP/SPI > + > +maintainers: > + - Marek Vasut <marex@denx.de> > + > +allOf: > + - $ref: "/schemas/spi/spi-controller.yaml#" > + > +properties: > + compatible: > + enum: > + - fsl,imx23-spi > + - fsl,imx28-spi > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + dmas: > + maxItems: 1 > + > + dma-names: > + const: rx-tx > + > + clock-frequency: > + $ref: /schemas/types.yaml#/definitions/uint32 Already has a type, drop. With that, Reviewed-by: Rob Herring <robh@kernel.org> > + description: input clock frequency to the SPI block in Hz. > + default: 160000000 > + > +required: > + - compatible > + - reg > + - interrupts > + - dmas > + - dma-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi@80010000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,imx28-spi"; > + reg = <0x80010000 0x2000>; > + interrupts = <96>; > + dmas = <&dma_apbh 0>; > + dma-names = "rx-tx"; > + }; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 2/3] dt-bindings: spi: Convert imx cspi to json-schema 2020-06-04 1:55 [PATCH V2 0/3] Convert mxs/imx spi/cspi/lpspi binding to json-schema Anson Huang 2020-06-04 1:55 ` [PATCH V2 1/3] dt-bindings: spi: Convert mxs spi " Anson Huang @ 2020-06-04 1:55 ` Anson Huang 2020-06-15 17:14 ` Rob Herring 2020-06-04 1:55 ` [PATCH V2 3/3] dt-bindings: spi: Convert imx lpspi " Anson Huang 2 siblings, 1 reply; 6+ messages in thread From: Anson Huang @ 2020-06-04 1:55 UTC (permalink / raw) To: broonie, robh+dt, shawnguo, s.hauer, kernel, festevam, marex, linux-spi, devicetree, linux-arm-kernel, linux-kernel Cc: Linux-imx Convert the i.MX CSPI binding to DT schema format using json-schema, update compatible, remove obsolete properties "fsl,spi-num-chipselects" and update the example based on latest DT file. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V1: - add "unevaluatedProperties: false". --- .../devicetree/bindings/spi/fsl-imx-cspi.txt | 56 ------------ .../devicetree/bindings/spi/fsl-imx-cspi.yaml | 99 ++++++++++++++++++++++ 2 files changed, 99 insertions(+), 56 deletions(-) delete mode 100644 Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt create mode 100644 Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt deleted file mode 100644 index 33bc58f..0000000 --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt +++ /dev/null @@ -1,56 +0,0 @@ -* Freescale (Enhanced) Configurable Serial Peripheral Interface - (CSPI/eCSPI) for i.MX - -Required properties: -- compatible : - - "fsl,imx1-cspi" for SPI compatible with the one integrated on i.MX1 - - "fsl,imx21-cspi" for SPI compatible with the one integrated on i.MX21 - - "fsl,imx27-cspi" for SPI compatible with the one integrated on i.MX27 - - "fsl,imx31-cspi" for SPI compatible with the one integrated on i.MX31 - - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 - - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 - - "fsl,imx53-ecspi" for SPI compatible with the one integrated on i.MX53 and later Soc - - "fsl,imx8mq-ecspi" for SPI compatible with the one integrated on i.MX8MQ - - "fsl,imx8mm-ecspi" for SPI compatible with the one integrated on i.MX8MM - - "fsl,imx8mn-ecspi" for SPI compatible with the one integrated on i.MX8MN - - "fsl,imx8mp-ecspi" for SPI compatible with the one integrated on i.MX8MP -- reg : Offset and length of the register set for the device -- interrupts : Should contain CSPI/eCSPI interrupt -- clocks : Clock specifiers for both ipg and per clocks. -- clock-names : Clock names should include both "ipg" and "per" -See the clock consumer binding, - Documentation/devicetree/bindings/clock/clock-bindings.txt - -Recommended properties: -- cs-gpios : GPIOs to use as chip selects, see spi-bus.txt. While the native chip -select lines can be used, they appear to always generate a pulse between each -word of a transfer. Most use cases will require GPIO based chip selects to -generate a valid transaction. - -Optional properties: -- num-cs : Number of total chip selects, see spi-bus.txt. -- dmas: DMA specifiers for tx and rx dma. See the DMA client binding, -Documentation/devicetree/bindings/dma/dma.txt. -- dma-names: DMA request names, if present, should include "tx" and "rx". -- fsl,spi-rdy-drctl: Integer, representing the value of DRCTL, the register -controlling the SPI_READY handling. Note that to enable the DRCTL consideration, -the SPI_READY mode-flag needs to be set too. -Valid values are: 0 (disabled), 1 (edge-triggered burst) and 2 (level-triggered burst). - -Obsolete properties: -- fsl,spi-num-chipselects : Contains the number of the chipselect - -Example: - -ecspi@70010000 { - #address-cells = <1>; - #size-cells = <0>; - compatible = "fsl,imx51-ecspi"; - reg = <0x70010000 0x4000>; - interrupts = <36>; - cs-gpios = <&gpio3 24 0>, /* GPIO3_24 */ - <&gpio3 25 0>; /* GPIO3_25 */ - dmas = <&sdma 3 7 1>, <&sdma 4 7 2>; - dma-names = "rx", "tx"; - fsl,spi-rdy-drctl = <1>; -}; diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml new file mode 100644 index 0000000..606af7d --- /dev/null +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml @@ -0,0 +1,99 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/fsl-imx-cspi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale (Enhanced) Configurable Serial Peripheral Interface (CSPI/eCSPI) for i.MX + +maintainers: + - Shawn Guo <shawn.guo@linaro.org> + +allOf: + - $ref: "/schemas/spi/spi-controller.yaml#" + +properties: + compatible: + oneOf: + - const: fsl,imx1-cspi + - const: fsl,imx21-cspi + - const: fsl,imx27-cspi + - const: fsl,imx31-cspi + - const: fsl,imx35-cspi + - const: fsl,imx51-ecspi + - const: fsl,imx53-ecspi + - items: + - enum: + - fsl,imx50-ecspi + - fsl,imx6q-ecspi + - fsl,imx6sx-ecspi + - fsl,imx6sl-ecspi + - fsl,imx6sll-ecspi + - fsl,imx6ul-ecspi + - fsl,imx7d-ecspi + - fsl,imx8mq-ecspi + - fsl,imx8mm-ecspi + - fsl,imx8mn-ecspi + - fsl,imx8mp-ecspi + - const: fsl,imx51-ecspi + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: SoC SPI ipg clock + - description: SoC SPI per clock + maxItems: 2 + + clock-names: + items: + - const: ipg + - const: per + maxItems: 2 + + dmas: + items: + - description: DMA controller phandle and request line for RX + - description: DMA controller phandle and request line for TX + + dma-names: + items: + - const: rx + - const: tx + + fsl,spi-rdy-drctl: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Integer, representing the value of DRCTL, the register controlling + the SPI_READY handling. Note that to enable the DRCTL consideration, + the SPI_READY mode-flag needs to be set too. + Valid values are: 0 (disabled), 1 (edge-triggered burst) and 2 (level-triggered burst). + enum: [0, 1, 2] + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/imx5-clock.h> + + spi@70010000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "fsl,imx51-ecspi"; + reg = <0x70010000 0x4000>; + interrupts = <36>; + clocks = <&clks IMX5_CLK_ECSPI1_IPG_GATE>, + <&clks IMX5_CLK_ECSPI1_PER_GATE>; + clock-names = "ipg", "per"; + }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: spi: Convert imx cspi to json-schema 2020-06-04 1:55 ` [PATCH V2 2/3] dt-bindings: spi: Convert imx cspi " Anson Huang @ 2020-06-15 17:14 ` Rob Herring 0 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2020-06-15 17:14 UTC (permalink / raw) To: Anson Huang Cc: broonie, shawnguo, s.hauer, kernel, festevam, marex, linux-spi, devicetree, linux-arm-kernel, linux-kernel, Linux-imx On Thu, Jun 04, 2020 at 09:55:30AM +0800, Anson Huang wrote: > Convert the i.MX CSPI binding to DT schema format using json-schema, > update compatible, remove obsolete properties "fsl,spi-num-chipselects" > and update the example based on latest DT file. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V1: > - add "unevaluatedProperties: false". > --- > .../devicetree/bindings/spi/fsl-imx-cspi.txt | 56 ------------ > .../devicetree/bindings/spi/fsl-imx-cspi.yaml | 99 ++++++++++++++++++++++ > 2 files changed, 99 insertions(+), 56 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > create mode 100644 Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml > > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > deleted file mode 100644 > index 33bc58f..0000000 > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt > +++ /dev/null > @@ -1,56 +0,0 @@ > -* Freescale (Enhanced) Configurable Serial Peripheral Interface > - (CSPI/eCSPI) for i.MX > - > -Required properties: > -- compatible : > - - "fsl,imx1-cspi" for SPI compatible with the one integrated on i.MX1 > - - "fsl,imx21-cspi" for SPI compatible with the one integrated on i.MX21 > - - "fsl,imx27-cspi" for SPI compatible with the one integrated on i.MX27 > - - "fsl,imx31-cspi" for SPI compatible with the one integrated on i.MX31 > - - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 > - - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 > - - "fsl,imx53-ecspi" for SPI compatible with the one integrated on i.MX53 and later Soc > - - "fsl,imx8mq-ecspi" for SPI compatible with the one integrated on i.MX8MQ > - - "fsl,imx8mm-ecspi" for SPI compatible with the one integrated on i.MX8MM > - - "fsl,imx8mn-ecspi" for SPI compatible with the one integrated on i.MX8MN > - - "fsl,imx8mp-ecspi" for SPI compatible with the one integrated on i.MX8MP > -- reg : Offset and length of the register set for the device > -- interrupts : Should contain CSPI/eCSPI interrupt > -- clocks : Clock specifiers for both ipg and per clocks. > -- clock-names : Clock names should include both "ipg" and "per" > -See the clock consumer binding, > - Documentation/devicetree/bindings/clock/clock-bindings.txt > - > -Recommended properties: > -- cs-gpios : GPIOs to use as chip selects, see spi-bus.txt. While the native chip > -select lines can be used, they appear to always generate a pulse between each > -word of a transfer. Most use cases will require GPIO based chip selects to > -generate a valid transaction. > - > -Optional properties: > -- num-cs : Number of total chip selects, see spi-bus.txt. > -- dmas: DMA specifiers for tx and rx dma. See the DMA client binding, > -Documentation/devicetree/bindings/dma/dma.txt. > -- dma-names: DMA request names, if present, should include "tx" and "rx". > -- fsl,spi-rdy-drctl: Integer, representing the value of DRCTL, the register > -controlling the SPI_READY handling. Note that to enable the DRCTL consideration, > -the SPI_READY mode-flag needs to be set too. > -Valid values are: 0 (disabled), 1 (edge-triggered burst) and 2 (level-triggered burst). > - > -Obsolete properties: > -- fsl,spi-num-chipselects : Contains the number of the chipselect > - > -Example: > - > -ecspi@70010000 { > - #address-cells = <1>; > - #size-cells = <0>; > - compatible = "fsl,imx51-ecspi"; > - reg = <0x70010000 0x4000>; > - interrupts = <36>; > - cs-gpios = <&gpio3 24 0>, /* GPIO3_24 */ > - <&gpio3 25 0>; /* GPIO3_25 */ > - dmas = <&sdma 3 7 1>, <&sdma 4 7 2>; > - dma-names = "rx", "tx"; > - fsl,spi-rdy-drctl = <1>; > -}; > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml > new file mode 100644 > index 0000000..606af7d > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.yaml > @@ -0,0 +1,99 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/fsl-imx-cspi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale (Enhanced) Configurable Serial Peripheral Interface (CSPI/eCSPI) for i.MX > + > +maintainers: > + - Shawn Guo <shawn.guo@linaro.org> > + > +allOf: > + - $ref: "/schemas/spi/spi-controller.yaml#" > + > +properties: > + compatible: > + oneOf: > + - const: fsl,imx1-cspi > + - const: fsl,imx21-cspi > + - const: fsl,imx27-cspi > + - const: fsl,imx31-cspi > + - const: fsl,imx35-cspi > + - const: fsl,imx51-ecspi > + - const: fsl,imx53-ecspi > + - items: > + - enum: > + - fsl,imx50-ecspi > + - fsl,imx6q-ecspi > + - fsl,imx6sx-ecspi > + - fsl,imx6sl-ecspi > + - fsl,imx6sll-ecspi > + - fsl,imx6ul-ecspi > + - fsl,imx7d-ecspi > + - fsl,imx8mq-ecspi > + - fsl,imx8mm-ecspi > + - fsl,imx8mn-ecspi > + - fsl,imx8mp-ecspi > + - const: fsl,imx51-ecspi > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: SoC SPI ipg clock > + - description: SoC SPI per clock > + maxItems: 2 Can drop 'maxItems', it is redundant here. > + > + clock-names: > + items: > + - const: ipg > + - const: per > + maxItems: 2 And here. > + > + dmas: > + items: > + - description: DMA controller phandle and request line for RX > + - description: DMA controller phandle and request line for TX > + > + dma-names: > + items: > + - const: rx > + - const: tx > + > + fsl,spi-rdy-drctl: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Integer, representing the value of DRCTL, the register controlling > + the SPI_READY handling. Note that to enable the DRCTL consideration, > + the SPI_READY mode-flag needs to be set too. > + Valid values are: 0 (disabled), 1 (edge-triggered burst) and 2 (level-triggered burst). > + enum: [0, 1, 2] > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/imx5-clock.h> > + > + spi@70010000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,imx51-ecspi"; > + reg = <0x70010000 0x4000>; > + interrupts = <36>; > + clocks = <&clks IMX5_CLK_ECSPI1_IPG_GATE>, > + <&clks IMX5_CLK_ECSPI1_PER_GATE>; > + clock-names = "ipg", "per"; > + }; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 3/3] dt-bindings: spi: Convert imx lpspi to json-schema 2020-06-04 1:55 [PATCH V2 0/3] Convert mxs/imx spi/cspi/lpspi binding to json-schema Anson Huang 2020-06-04 1:55 ` [PATCH V2 1/3] dt-bindings: spi: Convert mxs spi " Anson Huang 2020-06-04 1:55 ` [PATCH V2 2/3] dt-bindings: spi: Convert imx cspi " Anson Huang @ 2020-06-04 1:55 ` Anson Huang 2 siblings, 0 replies; 6+ messages in thread From: Anson Huang @ 2020-06-04 1:55 UTC (permalink / raw) To: broonie, robh+dt, shawnguo, s.hauer, kernel, festevam, marex, linux-spi, devicetree, linux-arm-kernel, linux-kernel Cc: Linux-imx Convert the i.MX LPSPI binding to DT schema format using json-schema Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V1: - add "unevaluatedProperties: false". --- .../devicetree/bindings/spi/spi-fsl-lpspi.txt | 29 ---------- .../devicetree/bindings/spi/spi-fsl-lpspi.yaml | 62 ++++++++++++++++++++++ 2 files changed, 62 insertions(+), 29 deletions(-) delete mode 100644 Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt create mode 100644 Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt deleted file mode 100644 index e71b81a..0000000 --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.txt +++ /dev/null @@ -1,29 +0,0 @@ -* Freescale Low Power SPI (LPSPI) for i.MX - -Required properties: -- compatible : - - "fsl,imx7ulp-spi" for LPSPI compatible with the one integrated on i.MX7ULP soc - - "fsl,imx8qxp-spi" for LPSPI compatible with the one integrated on i.MX8QXP soc -- reg : address and length of the lpspi master registers -- interrupt-parent : core interrupt controller -- interrupts : lpspi interrupt -- clocks : lpspi clock specifier. Its number and order need to correspond to the - value in clock-names. -- clock-names : Corresponding to per clock and ipg clock in "clocks" - respectively. In i.MX7ULP, it only has per clk, so use CLK_DUMMY - to fill the "ipg" blank. -- spi-slave : spi slave mode support. In slave mode, add this attribute without - value. In master mode, remove it. - -Examples: - -lpspi2: lpspi@40290000 { - compatible = "fsl,imx7ulp-spi"; - reg = <0x40290000 0x10000>; - interrupt-parent = <&intc>; - interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX7ULP_CLK_LPSPI2>, - <&clks IMX7ULP_CLK_DUMMY>; - clock-names = "per", "ipg"; - spi-slave; -}; diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml new file mode 100644 index 0000000..8ceb529 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/spi-fsl-lpspi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale Low Power SPI (LPSPI) for i.MX + +maintainers: + - Anson Huang <Anson.Huang@nxp.com> + +allOf: + - $ref: "/schemas/spi/spi-controller.yaml#" + +properties: + compatible: + enum: + - fsl,imx7ulp-spi + - fsl,imx8qxp-spi + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: SoC SPI per clock + - description: SoC SPI ipg clock + maxItems: 2 + + clock-names: + items: + - const: per + - const: ipg + maxItems: 2 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/imx7ulp-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + spi@40290000 { + compatible = "fsl,imx7ulp-spi"; + reg = <0x40290000 0x10000>; + interrupt-parent = <&intc>; + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks IMX7ULP_CLK_LPSPI2>, + <&clks IMX7ULP_CLK_DUMMY>; + clock-names = "per", "ipg"; + spi-slave; + }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-15 17:14 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-06-04 1:55 [PATCH V2 0/3] Convert mxs/imx spi/cspi/lpspi binding to json-schema Anson Huang 2020-06-04 1:55 ` [PATCH V2 1/3] dt-bindings: spi: Convert mxs spi " Anson Huang 2020-06-15 17:12 ` Rob Herring 2020-06-04 1:55 ` [PATCH V2 2/3] dt-bindings: spi: Convert imx cspi " Anson Huang 2020-06-15 17:14 ` Rob Herring 2020-06-04 1:55 ` [PATCH V2 3/3] dt-bindings: spi: Convert imx lpspi " Anson Huang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).