* [PATCH v3] net: atm: Remove the error message according to the atomic context
@ 2020-06-13 6:03 Yi Wang
2020-06-13 22:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2020-06-13 6:03 UTC (permalink / raw)
To: davem
Cc: kuba, mst, hkallweit1, snelson, andriy.shevchenko,
xiyou.wangcong, netdev, linux-kernel, xue.zhihong, wang.yi59,
wang.liang82, Liao Pingfang
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Looking into the context (atomic!) and the error message should be dropped.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
---
Changes in v3: remove {} as there is only one statement left.
net/atm/lec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/atm/lec.c b/net/atm/lec.c
index ca37f5a..875fc0b 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -1536,10 +1536,8 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
struct lec_arp_table *to_return;
to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
- if (!to_return) {
- pr_info("LEC: Arp entry kmalloc failed\n");
+ if (!to_return)
return NULL;
- }
ether_addr_copy(to_return->mac_addr, mac_addr);
INIT_HLIST_NODE(&to_return->next);
timer_setup(&to_return->timer, lec_arp_expire_arp, 0);
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] net: atm: Remove the error message according to the atomic context
2020-06-13 6:03 [PATCH v3] net: atm: Remove the error message according to the atomic context Yi Wang
@ 2020-06-13 22:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-13 22:29 UTC (permalink / raw)
To: wang.yi59
Cc: kuba, mst, hkallweit1, snelson, andriy.shevchenko,
xiyou.wangcong, netdev, linux-kernel, xue.zhihong, wang.liang82,
liao.pingfang
From: Yi Wang <wang.yi59@zte.com.cn>
Date: Sat, 13 Jun 2020 14:03:26 +0800
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Looking into the context (atomic!) and the error message should be dropped.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> ---
> Changes in v3: remove {} as there is only one statement left.
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-13 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-13 6:03 [PATCH v3] net: atm: Remove the error message according to the atomic context Yi Wang
2020-06-13 22:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).