* [PATCH] scsi: ppa: Remove superfluous breaks
@ 2020-07-14 10:59 Yi Wang
2020-07-25 2:50 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2020-07-14 10:59 UTC (permalink / raw)
To: jejb
Cc: martin.petersen, linux-scsi, linux-kernel, xue.zhihong,
wang.yi59, wang.liang82, Liao Pingfang
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
drivers/scsi/ppa.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c
index a406cc8..0ae800c 100644
--- a/drivers/scsi/ppa.c
+++ b/drivers/scsi/ppa.c
@@ -779,7 +779,6 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
(DID_OK << 16) + (h << 8) + (l & STATUS_MASK);
}
return 0; /* Finished */
- break;
default:
printk(KERN_ERR "ppa: Invalid scsi phase\n");
@@ -847,10 +846,8 @@ static int ppa_abort(struct scsi_cmnd *cmd)
case 1: /* Have not connected to interface */
dev->cur_cmd = NULL; /* Forget the problem */
return SUCCESS;
- break;
default: /* SCSI command sent, can not abort */
return FAILED;
- break;
}
}
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: ppa: Remove superfluous breaks
2020-07-14 10:59 [PATCH] scsi: ppa: Remove superfluous breaks Yi Wang
@ 2020-07-25 2:50 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-07-25 2:50 UTC (permalink / raw)
To: jejb, Yi Wang
Cc: Martin K . Petersen, linux-kernel, wang.liang82, Liao Pingfang,
linux-scsi, xue.zhihong
On Tue, 14 Jul 2020 18:59:31 +0800, Yi Wang wrote:
> Remove superfluous breaks, as there is a "return" before them.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: ppa: Remove superfluous breaks
https://git.kernel.org/mkp/scsi/c/6671eebd672c
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-25 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 10:59 [PATCH] scsi: ppa: Remove superfluous breaks Yi Wang
2020-07-25 2:50 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).