From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v5 02/10] bus: mhi: core: Abort suspends due to outgoing pending packets
Date: Thu, 23 Jul 2020 15:36:34 -0700 [thread overview]
Message-ID: <1595543802-17859-3-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1595543802-17859-1-git-send-email-bbhatt@codeaurora.org>
Add the missing check to abort suspends if a client driver has pending
outgoing packets to send to the device. This allows better utilization
of the MHI bus wherein clients on the host are not left waiting for
longer suspend or resume cycles to finish for data transfers.
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/bus/mhi/core/pm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index 7960980..661d704 100644
--- a/drivers/bus/mhi/core/pm.c
+++ b/drivers/bus/mhi/core/pm.c
@@ -686,7 +686,8 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl)
return -EIO;
/* Return busy if there are any pending resources */
- if (atomic_read(&mhi_cntrl->dev_wake))
+ if (atomic_read(&mhi_cntrl->dev_wake) ||
+ atomic_read(&mhi_cntrl->pending_pkts))
return -EBUSY;
/* Take MHI out of M2 state */
@@ -712,7 +713,8 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl)
write_lock_irq(&mhi_cntrl->pm_lock);
- if (atomic_read(&mhi_cntrl->dev_wake)) {
+ if (atomic_read(&mhi_cntrl->dev_wake) ||
+ atomic_read(&mhi_cntrl->pending_pkts)) {
write_unlock_irq(&mhi_cntrl->pm_lock);
return -EBUSY;
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-07-23 22:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 22:36 [PATCH v5 00/10] Introduce features and debugfs/sysfs entries for MHI Bhaumik Bhatt
2020-07-23 22:36 ` [PATCH v5 01/10] bus: mhi: core: Remove double occurrence for mhi_ctrl_ev_task() declaration Bhaumik Bhatt
2020-07-23 22:36 ` Bhaumik Bhatt [this message]
2020-07-23 22:36 ` [PATCH v5 03/10] bus: mhi: core: Use helper API to trigger a non-blocking host resume Bhaumik Bhatt
2020-07-24 6:09 ` Manivannan Sadhasivam
2020-07-23 22:36 ` [PATCH v5 04/10] bus: mhi: core: Trigger host resume if suspended during mhi_device_get() Bhaumik Bhatt
2020-07-23 22:36 ` [PATCH v5 05/10] bus: mhi: core: Use generic name field for an MHI device Bhaumik Bhatt
2020-07-23 22:36 ` [PATCH v5 06/10] bus: mhi: core: Introduce helper function to check device state Bhaumik Bhatt
2020-07-23 22:36 ` [PATCH v5 07/10] bus: mhi: core: Introduce debugfs entries for MHI Bhaumik Bhatt
2020-07-24 4:11 ` kernel test robot
2020-07-24 23:46 ` kernel test robot
2020-07-23 22:36 ` [PATCH v5 08/10] bus: mhi: core: Use counters to track MHI device state transitions Bhaumik Bhatt
2020-07-24 5:24 ` Manivannan Sadhasivam
2020-07-23 22:36 ` [PATCH v5 09/10] bus: mhi: core: Read and save device hardware information from BHI Bhaumik Bhatt
2020-07-23 22:36 ` [PATCH v5 10/10] bus: mhi: core: Introduce sysfs entries for MHI Bhaumik Bhatt
2020-07-24 5:42 ` Manivannan Sadhasivam
2020-07-28 0:29 ` bbhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595543802-17859-3-git-send-email-bbhatt@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).