* [PATCH 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling
@ 2020-08-11 3:23 Anson Huang
2020-08-11 3:23 ` [PATCH 2/3] pwm: imx27: " Anson Huang
2020-08-11 3:23 ` [PATCH 3/3] pwm: imx1: " Anson Huang
0 siblings, 2 replies; 3+ messages in thread
From: Anson Huang @ 2020-08-11 3:23 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, shawnguo, s.hauer,
kernel, festevam, linux-pwm, linux-arm-kernel, linux-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/pwm/pwm-imx-tpm.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c
index fcdf6be..e46fad3 100644
--- a/drivers/pwm/pwm-imx-tpm.c
+++ b/drivers/pwm/pwm-imx-tpm.c
@@ -350,13 +350,9 @@ static int pwm_imx_tpm_probe(struct platform_device *pdev)
return PTR_ERR(tpm->base);
tpm->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(tpm->clk)) {
- ret = PTR_ERR(tpm->clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "failed to get PWM clock: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(tpm->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(tpm->clk),
+ "failed to get PWM clock: %ld\n", PTR_ERR(tpm->clk));
ret = clk_prepare_enable(tpm->clk);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] pwm: imx27: Use dev_err_probe() to simplify error handling
2020-08-11 3:23 [PATCH 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
@ 2020-08-11 3:23 ` Anson Huang
2020-08-11 3:23 ` [PATCH 3/3] pwm: imx1: " Anson Huang
1 sibling, 0 replies; 3+ messages in thread
From: Anson Huang @ 2020-08-11 3:23 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, shawnguo, s.hauer,
kernel, festevam, linux-pwm, linux-arm-kernel, linux-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/pwm/pwm-imx27.c | 27 ++++++++-------------------
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
index c50d453..fabd30d1 100644
--- a/drivers/pwm/pwm-imx27.c
+++ b/drivers/pwm/pwm-imx27.c
@@ -315,27 +315,16 @@ static int pwm_imx27_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, imx);
imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
- if (IS_ERR(imx->clk_ipg)) {
- int ret = PTR_ERR(imx->clk_ipg);
-
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "getting ipg clock failed with %d\n",
- ret);
- return ret;
- }
+ if (IS_ERR(imx->clk_ipg))
+ return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_ipg),
+ "getting ipg clock failed with %ld\n",
+ PTR_ERR(imx->clk_ipg));
imx->clk_per = devm_clk_get(&pdev->dev, "per");
- if (IS_ERR(imx->clk_per)) {
- int ret = PTR_ERR(imx->clk_per);
-
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "failed to get peripheral clock: %d\n",
- ret);
-
- return ret;
- }
+ if (IS_ERR(imx->clk_per))
+ return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_per),
+ "failed to get peripheral clock: %ld\n",
+ PTR_ERR(imx->clk_per));
imx->chip.ops = &pwm_imx27_ops;
imx->chip.dev = &pdev->dev;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] pwm: imx1: Use dev_err_probe() to simplify error handling
2020-08-11 3:23 [PATCH 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 3:23 ` [PATCH 2/3] pwm: imx27: " Anson Huang
@ 2020-08-11 3:23 ` Anson Huang
1 sibling, 0 replies; 3+ messages in thread
From: Anson Huang @ 2020-08-11 3:23 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, shawnguo, s.hauer,
kernel, festevam, linux-pwm, linux-arm-kernel, linux-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/pwm/pwm-imx1.c | 23 ++++++++---------------
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/pwm/pwm-imx1.c b/drivers/pwm/pwm-imx1.c
index f8b2c2e..c0757a5 100644
--- a/drivers/pwm/pwm-imx1.c
+++ b/drivers/pwm/pwm-imx1.c
@@ -145,23 +145,16 @@ static int pwm_imx1_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, imx);
imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
- if (IS_ERR(imx->clk_ipg)) {
- dev_err(&pdev->dev, "getting ipg clock failed with %ld\n",
- PTR_ERR(imx->clk_ipg));
- return PTR_ERR(imx->clk_ipg);
- }
+ if (IS_ERR(imx->clk_ipg))
+ return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_ipg),
+ "getting ipg clock failed with %ld\n",
+ PTR_ERR(imx->clk_ipg));
imx->clk_per = devm_clk_get(&pdev->dev, "per");
- if (IS_ERR(imx->clk_per)) {
- int ret = PTR_ERR(imx->clk_per);
-
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev,
- "failed to get peripheral clock: %d\n",
- ret);
-
- return ret;
- }
+ if (IS_ERR(imx->clk_per))
+ return dev_err_probe(&pdev->dev, PTR_ERR(imx->clk_per),
+ "failed to get peripheral clock: %ld\n",
+ PTR_ERR(imx->clk_per));
imx->chip.ops = &pwm_imx1_ops;
imx->chip.dev = &pdev->dev;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-11 3:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 3:23 [PATCH 1/3] pwm: imx-tpm: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 3:23 ` [PATCH 2/3] pwm: imx27: " Anson Huang
2020-08-11 3:23 ` [PATCH 3/3] pwm: imx1: " Anson Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).