* [PATCH V2 1/5] dt-bindings: clock: Update i.MX28 example
@ 2020-08-12 8:51 Anson Huang
2020-08-12 8:51 ` [PATCH V2 2/5] dt-bindings: clock: Update i.MX23 example Anson Huang
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Anson Huang @ 2020-08-12 8:51 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, shawnguo, s.hauer, kernel, festevam,
gregkh, galak, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, linux-serial
Cc: Linux-imx
Update the i.MX28 clock example to align with MXS AUART binding doc to
avoid below build error:
Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml:
serial@8006a000: clocks: [[4294967295, 45]] is too short
Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml:
serial@8006a000: compatible: Additional items are not allowed
('fsl,imx23-auart' was unexpected)
Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml:
serial@8006a000: compatible: ['fsl,imx28-auart', 'fsl,imx23-auart']
is too long
Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml:
serial@8006a000: 'dmas' is a required property
Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml:
serial@8006a000: 'dma-names' is a required property
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
new patch.
---
Documentation/devicetree/bindings/clock/imx28-clock.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/imx28-clock.yaml b/Documentation/devicetree/bindings/clock/imx28-clock.yaml
index 72328d5..671b279 100644
--- a/Documentation/devicetree/bindings/clock/imx28-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx28-clock.yaml
@@ -108,8 +108,10 @@ examples:
};
serial@8006a000 {
- compatible = "fsl,imx28-auart", "fsl,imx23-auart";
+ compatible = "fsl,imx28-auart";
reg = <0x8006a000 0x2000>;
- interrupts = <112 70 71>;
+ interrupts = <112>;
+ dmas = <&dma_apbx 8>, <&dma_apbx 9>;
+ dma-names = "rx", "tx";
clocks = <&clks 45>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V2 2/5] dt-bindings: clock: Update i.MX23 example
2020-08-12 8:51 [PATCH V2 1/5] dt-bindings: clock: Update i.MX28 example Anson Huang
@ 2020-08-12 8:51 ` Anson Huang
2020-08-12 8:51 ` [PATCH V2 3/5] dt-bindings: serial: Convert i.MX uart to json-schema Anson Huang
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2020-08-12 8:51 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, shawnguo, s.hauer, kernel, festevam,
gregkh, galak, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, linux-serial
Cc: Linux-imx
Update the i.MX23 clock example to align with MXS AUART binding doc to
avoid below build error:
Documentation/devicetree/bindings/clock/imx23-clock.example.dt.yaml:
serial@8006c000: clocks: [[4294967295, 32]] is too short
Documentation/devicetree/bindings/clock/imx23-clock.example.dt.yaml:
serial@8006c000: 'dmas' is a required property
Documentation/devicetree/bindings/clock/imx23-clock.example.dt.yaml:
serial@8006c000: 'dma-names' is a required property
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
new patch.
---
Documentation/devicetree/bindings/clock/imx23-clock.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/imx23-clock.yaml b/Documentation/devicetree/bindings/clock/imx23-clock.yaml
index 66cb238..4028c1f 100644
--- a/Documentation/devicetree/bindings/clock/imx23-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx23-clock.yaml
@@ -87,6 +87,8 @@ examples:
serial@8006c000 {
compatible = "fsl,imx23-auart";
reg = <0x8006c000 0x2000>;
- interrupts = <24 25 23>;
+ interrupts = <24>;
clocks = <&clks 32>;
+ dmas = <&dma_apbx 6>, <&dma_apbx 7>;
+ dma-names = "rx", "tx";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V2 3/5] dt-bindings: serial: Convert i.MX uart to json-schema
2020-08-12 8:51 [PATCH V2 1/5] dt-bindings: clock: Update i.MX28 example Anson Huang
2020-08-12 8:51 ` [PATCH V2 2/5] dt-bindings: clock: Update i.MX23 example Anson Huang
@ 2020-08-12 8:51 ` Anson Huang
2020-08-12 8:51 ` [PATCH V2 4/5] dt-bindings: serial: Convert MXS auart " Anson Huang
2020-08-12 8:51 ` [PATCH V2 5/5] dt-bindings: serial: Convert NXP lpuart " Anson Huang
3 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2020-08-12 8:51 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, shawnguo, s.hauer, kernel, festevam,
gregkh, galak, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, linux-serial
Cc: Linux-imx
Convert the i.MX uart binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
no change.
---
.../devicetree/bindings/serial/fsl-imx-uart.txt | 40 ----------
.../devicetree/bindings/serial/fsl-imx-uart.yaml | 92 ++++++++++++++++++++++
2 files changed, 92 insertions(+), 40 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/serial/fsl-imx-uart.txt
create mode 100644 Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt b/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt
deleted file mode 100644
index 9582fc2..0000000
--- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt
+++ /dev/null
@@ -1,40 +0,0 @@
-* Freescale i.MX Universal Asynchronous Receiver/Transmitter (UART)
-
-Required properties:
-- compatible : Should be "fsl,<soc>-uart"
-- reg : Address and length of the register set for the device
-- interrupts : Should contain uart interrupt
-
-Optional properties:
-- fsl,dte-mode : Indicate the uart works in DTE mode. The uart works
- in DCE mode by default.
-- fsl,inverted-tx , fsl,inverted-rx : Indicate that the hardware attached
- to the peripheral inverts the signal transmitted or received,
- respectively, and that the peripheral should invert its output/input
- using the INVT/INVR registers.
-- rs485-rts-delay, rs485-rts-active-low, rs485-rx-during-tx,
- linux,rs485-enabled-at-boot-time: see rs485.txt. Note that for RS485
- you must enable either the "uart-has-rtscts" or the "rts-gpios"
- properties. In case you use "uart-has-rtscts" the signal that controls
- the transceiver is actually CTS_B, not RTS_B. CTS_B is always output,
- and RTS_B is input, regardless of dte-mode.
-
-Please check Documentation/devicetree/bindings/serial/serial.yaml
-for the complete list of generic properties.
-
-Note: Each uart controller should have an alias correctly numbered
-in "aliases" node.
-
-Example:
-
-aliases {
- serial0 = &uart1;
-};
-
-uart1: serial@73fbc000 {
- compatible = "fsl,imx51-uart", "fsl,imx21-uart";
- reg = <0x73fbc000 0x4000>;
- interrupts = <31>;
- uart-has-rtscts;
- fsl,dte-mode;
-};
diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
new file mode 100644
index 0000000..cba3f83
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
@@ -0,0 +1,92 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/fsl-imx-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX Universal Asynchronous Receiver/Transmitter (UART)
+
+maintainers:
+ - Fabio Estevam <fabio.estevam@nxp.com>
+
+allOf:
+ - $ref: "serial.yaml"
+ - $ref: "rs485.yaml"
+
+properties:
+ compatible:
+ oneOf:
+ - const: fsl,imx1-uart
+ - const: fsl,imx21-uart
+ - const: fsl,imx53-uart
+ - const: fsl,imx6q-uart
+ - items:
+ - enum:
+ - fsl,imx25-uart
+ - fsl,imx27-uart
+ - fsl,imx31-uart
+ - fsl,imx35-uart
+ - fsl,imx50-uart
+ - fsl,imx51-uart
+ - const: fsl,imx21-uart
+ - items:
+ - enum:
+ - fsl,imx6sl-uart
+ - fsl,imx6sll-uart
+ - fsl,imx6sx-uart
+ - fsl,imx6ul-uart
+ - fsl,imx7d-uart
+ - const: fsl,imx6q-uart
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ fsl,dte-mode:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: |
+ Indicate the uart works in DTE mode. The uart works in DCE mode by default.
+
+ fsl,inverted-tx:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: |
+ Indicate that the hardware attached to the peripheral inverts the signal
+ transmitted, and that the peripheral should invert its output using the
+ INVT registers.
+
+ fsl,inverted-rx:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: |
+ Indicate that the hardware attached to the peripheral inverts the signal
+ received, and that the peripheral should invert its input using the
+ INVR registers.
+
+ uart-has-rtscts: true
+
+ rs485-rts-delay: true
+ rs485-rts-active-low: true
+ rs485-rx-during-tx: true
+ linux,rs485-enabled-at-boot-time: true
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ aliases {
+ serial0 = &uart1;
+ };
+
+ uart1: serial@73fbc000 {
+ compatible = "fsl,imx51-uart", "fsl,imx21-uart";
+ reg = <0x73fbc000 0x4000>;
+ interrupts = <31>;
+ uart-has-rtscts;
+ fsl,dte-mode;
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V2 4/5] dt-bindings: serial: Convert MXS auart to json-schema
2020-08-12 8:51 [PATCH V2 1/5] dt-bindings: clock: Update i.MX28 example Anson Huang
2020-08-12 8:51 ` [PATCH V2 2/5] dt-bindings: clock: Update i.MX23 example Anson Huang
2020-08-12 8:51 ` [PATCH V2 3/5] dt-bindings: serial: Convert i.MX uart to json-schema Anson Huang
@ 2020-08-12 8:51 ` Anson Huang
2020-08-18 2:17 ` Rob Herring
2020-08-12 8:51 ` [PATCH V2 5/5] dt-bindings: serial: Convert NXP lpuart " Anson Huang
3 siblings, 1 reply; 7+ messages in thread
From: Anson Huang @ 2020-08-12 8:51 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, shawnguo, s.hauer, kernel, festevam,
gregkh, galak, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, linux-serial
Cc: Linux-imx
Convert the MXS auart binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
changes since V1:
- update examples to align with i.MX23/i.MX28 clock bindings;
- add minItem to clocks/clock-names property as i.MX23/i.MX28 have optional clocks
property with one item.
---
.../devicetree/bindings/serial/fsl-mxs-auart.txt | 53 -------------
.../devicetree/bindings/serial/fsl-mxs-auart.yaml | 91 ++++++++++++++++++++++
2 files changed, 91 insertions(+), 53 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
create mode 100644 Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
diff --git a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
deleted file mode 100644
index 5c96d41..0000000
--- a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-* Freescale MXS Application UART (AUART)
-
-Required properties for all SoCs:
-- compatible : Should be one of fallowing variants:
- "fsl,imx23-auart" - Freescale i.MX23
- "fsl,imx28-auart" - Freescale i.MX28
- "alphascale,asm9260-auart" - Alphascale ASM9260
-- reg : Address and length of the register set for the device
-- interrupts : Should contain the auart interrupt numbers
-- dmas: DMA specifier, consisting of a phandle to DMA controller node
- and AUART DMA channel ID.
- Refer to dma.txt and fsl-mxs-dma.txt for details.
-- dma-names: "rx" for RX channel, "tx" for TX channel.
-
-Required properties for "alphascale,asm9260-auart":
-- clocks : the clocks feeding the watchdog timer. See clock-bindings.txt
-- clock-names : should be set to
- "mod" - source for tick counter.
- "ahb" - ahb gate.
-
-Optional properties:
-- uart-has-rtscts : Indicate the UART has RTS and CTS lines
- for hardware flow control,
- it also means you enable the DMA support for this UART.
-- {rts,cts,dtr,dsr,rng,dcd}-gpios: specify a GPIO for RTS/CTS/DTR/DSR/RI/DCD
- line respectively. It will use specified PIO instead of the peripheral
- function pin for the USART feature.
- If unsure, don't specify this property.
-
-Example:
-auart0: serial@8006a000 {
- compatible = "fsl,imx28-auart", "fsl,imx23-auart";
- reg = <0x8006a000 0x2000>;
- interrupts = <112>;
- dmas = <&dma_apbx 8>, <&dma_apbx 9>;
- dma-names = "rx", "tx";
- cts-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
- dsr-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
- dcd-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
-};
-
-Note: Each auart port should have an alias correctly numbered in "aliases"
-node.
-
-Example:
-
-aliases {
- serial0 = &auart0;
- serial1 = &auart1;
- serial2 = &auart2;
- serial3 = &auart3;
- serial4 = &auart4;
-};
diff --git a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
new file mode 100644
index 0000000..5c4fa75
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/fsl-mxs-auart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale MXS Application UART (AUART)
+
+maintainers:
+ - Kumar Gala <galak@codeaurora.org>
+
+allOf:
+ - $ref: "serial.yaml"
+
+properties:
+ compatible:
+ enum:
+ - fsl,imx23-auart
+ - fsl,imx28-auart
+ - alphascale,asm9260-auart
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ dmas:
+ items:
+ - description: DMA controller phandle and request line for RX
+ - description: DMA controller phandle and request line for TX
+
+ dma-names:
+ items:
+ - const: rx
+ - const: tx
+
+ clocks:
+ items:
+ - description: mod clock
+ - description: ahb clock
+ minItems: 1
+
+ clock-names:
+ items:
+ - const: mod
+ - const: ahb
+ minItems: 1
+
+ uart-has-rtscts: true
+ rts-gpios: true
+ cts-gpios: true
+ dtr-gpios: true
+ dsr-gpios: true
+ rng-gpios: true
+ dcd-gpios: true
+
+if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - alphascale,asm9260-auart
+then:
+ required:
+ - clocks
+ - clock-names
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - dmas
+ - dma-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ aliases {
+ serial0 = &auart0;
+ };
+
+ auart0: serial@8006a000 {
+ compatible = "fsl,imx28-auart";
+ reg = <0x8006a000 0x2000>;
+ interrupts = <112>;
+ dmas = <&dma_apbx 8>, <&dma_apbx 9>;
+ dma-names = "rx", "tx";
+ clocks = <&clks 45>;
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V2 5/5] dt-bindings: serial: Convert NXP lpuart to json-schema
2020-08-12 8:51 [PATCH V2 1/5] dt-bindings: clock: Update i.MX28 example Anson Huang
` (2 preceding siblings ...)
2020-08-12 8:51 ` [PATCH V2 4/5] dt-bindings: serial: Convert MXS auart " Anson Huang
@ 2020-08-12 8:51 ` Anson Huang
3 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2020-08-12 8:51 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, shawnguo, s.hauer, kernel, festevam,
gregkh, galak, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, linux-serial
Cc: Linux-imx
Convert the NXP lpuart binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
no change.
---
.../devicetree/bindings/serial/fsl-lpuart.txt | 43 ------------
.../devicetree/bindings/serial/fsl-lpuart.yaml | 79 ++++++++++++++++++++++
2 files changed, 79 insertions(+), 43 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/serial/fsl-lpuart.txt
create mode 100644 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt b/Documentation/devicetree/bindings/serial/fsl-lpuart.txt
deleted file mode 100644
index e7448b9..0000000
--- a/Documentation/devicetree/bindings/serial/fsl-lpuart.txt
+++ /dev/null
@@ -1,43 +0,0 @@
-* Freescale low power universal asynchronous receiver/transmitter (lpuart)
-
-Required properties:
-- compatible :
- - "fsl,vf610-lpuart" for lpuart compatible with the one integrated
- on Vybrid vf610 SoC with 8-bit register organization
- - "fsl,ls1021a-lpuart" for lpuart compatible with the one integrated
- on LS1021A SoC with 32-bit big-endian register organization
- - "fsl,ls1028a-lpuart" for lpuart compatible with the one integrated
- on LS1028A SoC with 32-bit little-endian register organization
- - "fsl,imx7ulp-lpuart" for lpuart compatible with the one integrated
- on i.MX7ULP SoC with 32-bit little-endian register organization
- - "fsl,imx8qxp-lpuart" for lpuart compatible with the one integrated
- on i.MX8QXP SoC with 32-bit little-endian register organization
- - "fsl,imx8qm-lpuart" for lpuart compatible with the one integrated
- on i.MX8QM SoC with 32-bit little-endian register organization
-- reg : Address and length of the register set for the device
-- interrupts : Should contain uart interrupt
-- clocks : phandle + clock specifier pairs, one for each entry in clock-names
-- clock-names : For vf610/ls1021a/ls1028a/imx7ulp, "ipg" clock is for uart
- bus/baud clock. For imx8qxp lpuart, "ipg" clock is bus clock that is used
- to access lpuart controller registers, it also requires "baud" clock for
- module to receive/transmit data.
-
-Optional properties:
-- dmas: A list of two dma specifiers, one for each entry in dma-names.
-- dma-names: should contain "tx" and "rx".
-- rs485-rts-active-low, linux,rs485-enabled-at-boot-time: see rs485.txt
-
-Note: Optional properties for DMA support. Write them both or both not.
-
-Example:
-
-uart0: serial@40027000 {
- compatible = "fsl,vf610-lpuart";
- reg = <0x40027000 0x1000>;
- interrupts = <0 61 0x00>;
- clocks = <&clks VF610_CLK_UART0>;
- clock-names = "ipg";
- dmas = <&edma0 0 2>,
- <&edma0 0 3>;
- dma-names = "rx","tx";
- };
diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
new file mode 100644
index 0000000..1b955f3
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/fsl-lpuart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale low power universal asynchronous receiver/transmitter (lpuart)
+
+maintainers:
+ - Kumar Gala <galak@codeaurora.org>
+
+allOf:
+ - $ref: "rs485.yaml"
+
+properties:
+ compatible:
+ enum:
+ - fsl,vf610-lpuart
+ - fsl,ls1021a-lpuart
+ - fsl,ls1028a-lpuart
+ - fsl,imx7ulp-lpuart
+ - fsl,imx8qxp-lpuart
+ - fsl,imx8qm-lpuart
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: ipg clock
+ - description: baud clock
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: ipg
+ - const: baud
+ minItems: 1
+ maxItems: 2
+
+ dmas:
+ items:
+ - description: DMA controller phandle and request line for RX
+ - description: DMA controller phandle and request line for TX
+
+ dma-names:
+ items:
+ - const: rx
+ - const: tx
+
+ rs485-rts-active-low: true
+ linux,rs485-enabled-at-boot-time: true
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/vf610-clock.h>
+
+ serial@40027000 {
+ compatible = "fsl,vf610-lpuart";
+ reg = <0x40027000 0x1000>;
+ interrupts = <0 61 0x00>;
+ clocks = <&clks VF610_CLK_UART0>;
+ clock-names = "ipg";
+ dmas = <&edma0 0 2>, <&edma0 0 3>;
+ dma-names = "rx","tx";
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V2 4/5] dt-bindings: serial: Convert MXS auart to json-schema
2020-08-12 8:51 ` [PATCH V2 4/5] dt-bindings: serial: Convert MXS auart " Anson Huang
@ 2020-08-18 2:17 ` Rob Herring
2020-08-18 3:08 ` Anson Huang
0 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2020-08-18 2:17 UTC (permalink / raw)
To: Anson Huang
Cc: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam, gregkh,
galak, linux-clk, devicetree, linux-arm-kernel, linux-kernel,
linux-serial, Linux-imx
On Wed, Aug 12, 2020 at 04:51:23PM +0800, Anson Huang wrote:
> Convert the MXS auart binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> changes since V1:
> - update examples to align with i.MX23/i.MX28 clock bindings;
> - add minItem to clocks/clock-names property as i.MX23/i.MX28 have optional clocks
> property with one item.
> ---
> .../devicetree/bindings/serial/fsl-mxs-auart.txt | 53 -------------
> .../devicetree/bindings/serial/fsl-mxs-auart.yaml | 91 ++++++++++++++++++++++
> 2 files changed, 91 insertions(+), 53 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
> create mode 100644 Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
> deleted file mode 100644
> index 5c96d41..0000000
> --- a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
> +++ /dev/null
> @@ -1,53 +0,0 @@
> -* Freescale MXS Application UART (AUART)
> -
> -Required properties for all SoCs:
> -- compatible : Should be one of fallowing variants:
> - "fsl,imx23-auart" - Freescale i.MX23
> - "fsl,imx28-auart" - Freescale i.MX28
> - "alphascale,asm9260-auart" - Alphascale ASM9260
> -- reg : Address and length of the register set for the device
> -- interrupts : Should contain the auart interrupt numbers
> -- dmas: DMA specifier, consisting of a phandle to DMA controller node
> - and AUART DMA channel ID.
> - Refer to dma.txt and fsl-mxs-dma.txt for details.
> -- dma-names: "rx" for RX channel, "tx" for TX channel.
> -
> -Required properties for "alphascale,asm9260-auart":
> -- clocks : the clocks feeding the watchdog timer. See clock-bindings.txt
> -- clock-names : should be set to
> - "mod" - source for tick counter.
> - "ahb" - ahb gate.
> -
> -Optional properties:
> -- uart-has-rtscts : Indicate the UART has RTS and CTS lines
> - for hardware flow control,
> - it also means you enable the DMA support for this UART.
> -- {rts,cts,dtr,dsr,rng,dcd}-gpios: specify a GPIO for RTS/CTS/DTR/DSR/RI/DCD
> - line respectively. It will use specified PIO instead of the peripheral
> - function pin for the USART feature.
> - If unsure, don't specify this property.
> -
> -Example:
> -auart0: serial@8006a000 {
> - compatible = "fsl,imx28-auart", "fsl,imx23-auart";
> - reg = <0x8006a000 0x2000>;
> - interrupts = <112>;
> - dmas = <&dma_apbx 8>, <&dma_apbx 9>;
> - dma-names = "rx", "tx";
> - cts-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
> - dsr-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> - dcd-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
> -};
> -
> -Note: Each auart port should have an alias correctly numbered in "aliases"
> -node.
> -
> -Example:
> -
> -aliases {
> - serial0 = &auart0;
> - serial1 = &auart1;
> - serial2 = &auart2;
> - serial3 = &auart3;
> - serial4 = &auart4;
> -};
> diff --git a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> new file mode 100644
> index 0000000..5c4fa75
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/fsl-mxs-auart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MXS Application UART (AUART)
> +
> +maintainers:
> + - Kumar Gala <galak@codeaurora.org>
Why is Kumar maintainer and that's a really old email address?
> +
> +allOf:
> + - $ref: "serial.yaml"
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,imx23-auart
> + - fsl,imx28-auart
> + - alphascale,asm9260-auart
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + dmas:
> + items:
> + - description: DMA controller phandle and request line for RX
> + - description: DMA controller phandle and request line for TX
> +
> + dma-names:
> + items:
> + - const: rx
> + - const: tx
> +
> + clocks:
> + items:
> + - description: mod clock
> + - description: ahb clock
> + minItems: 1
> +
> + clock-names:
> + items:
> + - const: mod
> + - const: ahb
> + minItems: 1
> +
> + uart-has-rtscts: true
> + rts-gpios: true
> + cts-gpios: true
> + dtr-gpios: true
> + dsr-gpios: true
> + rng-gpios: true
> + dcd-gpios: true
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - alphascale,asm9260-auart
> +then:
> + required:
> + - clocks
> + - clock-names
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - dmas
> + - dma-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + aliases {
> + serial0 = &auart0;
> + };
> +
> + auart0: serial@8006a000 {
> + compatible = "fsl,imx28-auart";
> + reg = <0x8006a000 0x2000>;
> + interrupts = <112>;
> + dmas = <&dma_apbx 8>, <&dma_apbx 9>;
> + dma-names = "rx", "tx";
> + clocks = <&clks 45>;
> + };
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH V2 4/5] dt-bindings: serial: Convert MXS auart to json-schema
2020-08-18 2:17 ` Rob Herring
@ 2020-08-18 3:08 ` Anson Huang
0 siblings, 0 replies; 7+ messages in thread
From: Anson Huang @ 2020-08-18 3:08 UTC (permalink / raw)
To: Rob Herring
Cc: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam, gregkh,
galak, linux-clk, devicetree, linux-arm-kernel, linux-kernel,
linux-serial, dl-linux-imx
Hi, Rob
> Subject: Re: [PATCH V2 4/5] dt-bindings: serial: Convert MXS auart to
> json-schema
>
> On Wed, Aug 12, 2020 at 04:51:23PM +0800, Anson Huang wrote:
> > Convert the MXS auart binding to DT schema format using json-schema.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > changes since V1:
> > - update examples to align with i.MX23/i.MX28 clock bindings;
> > - add minItem to clocks/clock-names property as i.MX23/i.MX28 have
> optional clocks
> > property with one item.
> > ---
> > .../devicetree/bindings/serial/fsl-mxs-auart.txt | 53 -------------
> > .../devicetree/bindings/serial/fsl-mxs-auart.yaml | 91
> > ++++++++++++++++++++++
> > 2 files changed, 91 insertions(+), 53 deletions(-) delete mode
> > 100644 Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
> > create mode 100644
> > Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
> > b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
> > deleted file mode 100644
> > index 5c96d41..0000000
> > --- a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
> > +++ /dev/null
> > @@ -1,53 +0,0 @@
> > -* Freescale MXS Application UART (AUART)
> > -
> > -Required properties for all SoCs:
> > -- compatible : Should be one of fallowing variants:
> > - "fsl,imx23-auart" - Freescale i.MX23
> > - "fsl,imx28-auart" - Freescale i.MX28
> > - "alphascale,asm9260-auart" - Alphascale ASM9260
> > -- reg : Address and length of the register set for the device
> > -- interrupts : Should contain the auart interrupt numbers
> > -- dmas: DMA specifier, consisting of a phandle to DMA controller node
> > - and AUART DMA channel ID.
> > - Refer to dma.txt and fsl-mxs-dma.txt for details.
> > -- dma-names: "rx" for RX channel, "tx" for TX channel.
> > -
> > -Required properties for "alphascale,asm9260-auart":
> > -- clocks : the clocks feeding the watchdog timer. See
> > clock-bindings.txt
> > -- clock-names : should be set to
> > - "mod" - source for tick counter.
> > - "ahb" - ahb gate.
> > -
> > -Optional properties:
> > -- uart-has-rtscts : Indicate the UART has RTS and CTS lines
> > - for hardware flow control,
> > - it also means you enable the DMA support for this UART.
> > -- {rts,cts,dtr,dsr,rng,dcd}-gpios: specify a GPIO for
> > RTS/CTS/DTR/DSR/RI/DCD
> > - line respectively. It will use specified PIO instead of the
> > peripheral
> > - function pin for the USART feature.
> > - If unsure, don't specify this property.
> > -
> > -Example:
> > -auart0: serial@8006a000 {
> > - compatible = "fsl,imx28-auart", "fsl,imx23-auart";
> > - reg = <0x8006a000 0x2000>;
> > - interrupts = <112>;
> > - dmas = <&dma_apbx 8>, <&dma_apbx 9>;
> > - dma-names = "rx", "tx";
> > - cts-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
> > - dsr-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
> > - dcd-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
> > -};
> > -
> > -Note: Each auart port should have an alias correctly numbered in "aliases"
> > -node.
> > -
> > -Example:
> > -
> > -aliases {
> > - serial0 = &auart0;
> > - serial1 = &auart1;
> > - serial2 = &auart2;
> > - serial3 = &auart3;
> > - serial4 = &auart4;
> > -};
> > diff --git
> > a/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> > b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> > new file mode 100644
> > index 0000000..5c4fa75
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> > @@ -0,0 +1,91 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fserial%2Ffsl-mxs-auart.yaml%23&data=02%7
> C0
> >
> +1%7CAnson.Huang%40nxp.com%7Cab0ecefb1f8a405a777608d8431ceba7%
> 7C686ea1
> >
> +d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637333138774276608&
> sdata=0eW
> > +q1Lnvv2PJcAlS2IThb6DYy9x55jopNRcz%2Fa5YGgc%3D&reserved=0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7CAns
> on.Hua
> >
> +ng%40nxp.com%7Cab0ecefb1f8a405a777608d8431ceba7%7C686ea1d3bc2
> b4c6fa92
> >
> +cd99c5c301635%7C0%7C0%7C637333138774286606&sdata=77AsG1n
> Q%2BFl9x0
> > +XStFm6xHXXAO4MNVrkLgezkHni57Y%3D&reserved=0
> > +
> > +title: Freescale MXS Application UART (AUART)
> > +
> > +maintainers:
> > + - Kumar Gala <galak@codeaurora.org>
>
> Why is Kumar maintainer and that's a really old email address?
I finally found the fist patch of this binding doc, Kumar ONLY did the moving of the file to different
folder, I will update the mainatainer to Fabio in V3.
commit 1ea6607d4cdc917987e7e6cfaafc4a630d97a297
Author: Fabio Estevam <fabio.estevam@freescale.com>
Date: Mon Jun 18 10:06:09 2012 -0300
serial: mxs-auart: Allow device tree probing
Allow device tree probing.
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: <linux-serial@vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Subodh Nijsure <snijsure@grid-net.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Thanks,
Anson
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-18 3:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 8:51 [PATCH V2 1/5] dt-bindings: clock: Update i.MX28 example Anson Huang
2020-08-12 8:51 ` [PATCH V2 2/5] dt-bindings: clock: Update i.MX23 example Anson Huang
2020-08-12 8:51 ` [PATCH V2 3/5] dt-bindings: serial: Convert i.MX uart to json-schema Anson Huang
2020-08-12 8:51 ` [PATCH V2 4/5] dt-bindings: serial: Convert MXS auart " Anson Huang
2020-08-18 2:17 ` Rob Herring
2020-08-18 3:08 ` Anson Huang
2020-08-12 8:51 ` [PATCH V2 5/5] dt-bindings: serial: Convert NXP lpuart " Anson Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).