* [PATCH v2] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe()
@ 2020-08-06 7:01 Jing Xiangfeng
2020-08-06 7:08 ` Avri Altman
2020-08-18 3:12 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jing Xiangfeng @ 2020-08-06 7:01 UTC (permalink / raw)
To: alim.akhtar, avri.altman, jejb, martin.petersen, vigneshr, jingxiangfeng
Cc: linux-scsi, linux-kernel
Fix to return error code PTR_ERR() from the error handling case instead
of 0.
Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime changes")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/scsi/ufs/ti-j721e-ufs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ti-j721e-ufs.c b/drivers/scsi/ufs/ti-j721e-ufs.c
index 46bb905b4d6a..eafe0db98d54 100644
--- a/drivers/scsi/ufs/ti-j721e-ufs.c
+++ b/drivers/scsi/ufs/ti-j721e-ufs.c
@@ -38,6 +38,7 @@ static int ti_j721e_ufs_probe(struct platform_device *pdev)
/* Select MPHY refclk frequency */
clk = devm_clk_get(dev, NULL);
if (IS_ERR(clk)) {
+ ret = PTR_ERR(clk);
dev_err(dev, "Cannot claim MPHY clock.\n");
goto clk_err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v2] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe()
2020-08-06 7:01 [PATCH v2] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe() Jing Xiangfeng
@ 2020-08-06 7:08 ` Avri Altman
2020-08-18 3:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Avri Altman @ 2020-08-06 7:08 UTC (permalink / raw)
To: Jing Xiangfeng, alim.akhtar, jejb, martin.petersen, vigneshr
Cc: linux-scsi, linux-kernel
>
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
>
> Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime
> changes")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe()
2020-08-06 7:01 [PATCH v2] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe() Jing Xiangfeng
2020-08-06 7:08 ` Avri Altman
@ 2020-08-18 3:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-08-18 3:12 UTC (permalink / raw)
To: Jing Xiangfeng, avri.altman, jejb, alim.akhtar, vigneshr
Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Thu, 6 Aug 2020 15:01:35 +0800, Jing Xiangfeng wrote:
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
Applied to 5.9/scsi-fixes, thanks!
[1/1] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe()
https://git.kernel.org/mkp/scsi/c/2138d1c91824
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-18 3:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 7:01 [PATCH v2] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe() Jing Xiangfeng
2020-08-06 7:08 ` Avri Altman
2020-08-18 3:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).