linux-next: build warning after merge of the sound-asoc tree

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/sunxi/sun8i-codec.c:532:12: warning: 'sun8i_codec_component_probe' defined but not used [-Wunused-function]
  532 | static int sun8i_codec_component_probe(struct snd_soc_component *component)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  90cac932976e ("ASoC: sun8i-codec: Fix DAPM to match the hardware topology")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] ASoC: sun8i-codec: Hook up component probe function

[Samuel Holland]

Due to a mistake made while reordering patches, commit 90cac932976e
("ASoC: sun8i-codec: Fix DAPM to match the hardware topology") added
the sun8i_codec_component_probe function without referencing it from
the component definition. Add the reference so the probe function gets
called as expected.

Fixes: 90cac932976e ("ASoC: sun8i-codec: Fix DAPM to match the hardware topology")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
 sound/soc/sunxi/sun8i-codec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c
index 304683a71acd..e3a1347d7ecd 100644
--- a/sound/soc/sunxi/sun8i-codec.c
+++ b/sound/soc/sunxi/sun8i-codec.c
@@ -584,6 +584,7 @@ static const struct snd_soc_component_driver sun8i_soc_component = {
 	.num_dapm_widgets	= ARRAY_SIZE(sun8i_codec_dapm_widgets),
 	.dapm_routes		= sun8i_codec_dapm_routes,
 	.num_dapm_routes	= ARRAY_SIZE(sun8i_codec_dapm_routes),
+	.probe			= sun8i_codec_component_probe,
 	.idle_bias_on		= 1,
 	.use_pmdown_time	= 1,
 	.endianness		= 1,
-- 
2.26.2

Re: [PATCH] ASoC: sun8i-codec: Hook up component probe function

[Mark Brown]

On Tue, 18 Aug 2020 22:40:38 -0500, Samuel Holland wrote:
> Due to a mistake made while reordering patches, commit 90cac932976e
> ("ASoC: sun8i-codec: Fix DAPM to match the hardware topology") added
> the sun8i_codec_component_probe function without referencing it from
> the component definition. Add the reference so the probe function gets
> called as expected.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: sun8i-codec: Hook up component probe function
      commit: ed7f0fbc9dca0961ac9a713c778319b7f24315ae

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark