From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 08/10] usb: phy-ulpi-viewport: convert to readl_poll_timeout_atomic()
Date: Wed, 19 Aug 2020 20:41:03 +0800 [thread overview]
Message-ID: <1597840865-26631-8-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1597840865-26631-1-git-send-email-chunfeng.yun@mediatek.com>
Use readl_poll_timeout_atomic() to simplify code
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/phy/phy-ulpi-viewport.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/phy/phy-ulpi-viewport.c b/drivers/usb/phy/phy-ulpi-viewport.c
index 7a14e0e..0f61e32 100644
--- a/drivers/usb/phy/phy-ulpi-viewport.c
+++ b/drivers/usb/phy/phy-ulpi-viewport.c
@@ -7,6 +7,7 @@
#include <linux/kernel.h>
#include <linux/usb.h>
#include <linux/io.h>
+#include <linux/iopoll.h>
#include <linux/usb/otg.h>
#include <linux/usb/ulpi.h>
@@ -20,16 +21,9 @@
static int ulpi_viewport_wait(void __iomem *view, u32 mask)
{
- unsigned long usec = 2000;
+ u32 val;
- while (usec--) {
- if (!(readl(view) & mask))
- return 0;
-
- udelay(1);
- }
-
- return -ETIMEDOUT;
+ return readl_poll_timeout_atomic(view, val, !(val & mask), 1, 2000);
}
static int ulpi_viewport_read(struct usb_phy *otg, u32 reg)
--
1.9.1
next prev parent reply other threads:[~2020-08-19 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 12:40 [PATCH 01/10] usb: early: convert to readl_poll_timeout_atomic() Chunfeng Yun
2020-08-19 12:40 ` [PATCH 02/10] usb: early: ehci-dbgp: " Chunfeng Yun
2020-08-19 12:40 ` [PATCH 03/10] usb: pci-quirks: " Chunfeng Yun
2020-08-19 12:40 ` [PATCH 04/10] usb: xhci-rcar: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 05/10] usb: oxu210hp-hcd: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 06/10] usb: fotg210-hcd: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 07/10] usb: isp1760-hcd: " Chunfeng Yun
2020-08-19 12:41 ` Chunfeng Yun [this message]
2020-08-19 12:41 ` [PATCH 09/10] usb: phy: phy-mv-usb: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 10/10] usb: udc: net2280: " Chunfeng Yun
2020-08-19 14:59 ` Alan Stern
2020-08-20 1:57 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597840865-26631-8-git-send-email-chunfeng.yun@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).