From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 10/10] usb: udc: net2280: convert to readl_poll_timeout_atomic()
Date: Thu, 20 Aug 2020 09:57:03 +0800 [thread overview]
Message-ID: <1597888623.23067.19.camel@mhfsdcap03> (raw)
In-Reply-To: <20200819145957.GA183103@rowland.harvard.edu>
On Wed, 2020-08-19 at 10:59 -0400, Alan Stern wrote:
> On Wed, Aug 19, 2020 at 08:41:05PM +0800, Chunfeng Yun wrote:
> > Use readl_poll_timeout_atomic() to simplify code
> >
> > Cc: Alan Stern <stern@rowland.harvard.edu>
> > Cc: Felipe Balbi <balbi@kernel.org>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > drivers/usb/gadget/udc/net2280.c | 21 ++++++++++-----------
> > 1 file changed, 10 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
> > index 7530bd9..f1a21f4 100644
> > --- a/drivers/usb/gadget/udc/net2280.c
> > +++ b/drivers/usb/gadget/udc/net2280.c
> > @@ -52,6 +52,7 @@
> > #include <linux/usb/gadget.h>
> > #include <linux/prefetch.h>
> > #include <linux/io.h>
> > +#include <linux/iopoll.h>
> >
> > #include <asm/byteorder.h>
> > #include <asm/irq.h>
> > @@ -360,18 +361,16 @@ static inline void enable_pciirqenb(struct net2280_ep *ep)
> > static int handshake(u32 __iomem *ptr, u32 mask, u32 done, int usec)
> > {
> > u32 result;
> > + int ret;
> >
> > - do {
> > - result = readl(ptr);
> > - if (result == ~(u32)0) /* "device unplugged" */
> > - return -ENODEV;
> > - result &= mask;
> > - if (result == done)
> > - return 0;
> > - udelay(1);
> > - usec--;
> > - } while (usec > 0);
> > - return -ETIMEDOUT;
> > + ret = readl_poll_timeout_atomic(ptr, result,
> > + ((result & mask) == done ||
> > + result == U32_MAX),
> > + 1, usec);
> > + if (result == U32_MAX) /* device unplugged */
> > + return -ENODEV;
> > +
> > + return ret;
> > }
> >
> > static const struct usb_ep_ops net2280_ep_ops;
> > --
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> However, I noticed that the kerneldoc for readl_poll_timeout_atomic() is
> out of date. Can you fix it up?
Ok, will do it, thanks
>
> Alan Stern
prev parent reply other threads:[~2020-08-20 1:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 12:40 [PATCH 01/10] usb: early: convert to readl_poll_timeout_atomic() Chunfeng Yun
2020-08-19 12:40 ` [PATCH 02/10] usb: early: ehci-dbgp: " Chunfeng Yun
2020-08-19 12:40 ` [PATCH 03/10] usb: pci-quirks: " Chunfeng Yun
2020-08-19 12:40 ` [PATCH 04/10] usb: xhci-rcar: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 05/10] usb: oxu210hp-hcd: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 06/10] usb: fotg210-hcd: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 07/10] usb: isp1760-hcd: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 08/10] usb: phy-ulpi-viewport: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 09/10] usb: phy: phy-mv-usb: " Chunfeng Yun
2020-08-19 12:41 ` [PATCH 10/10] usb: udc: net2280: " Chunfeng Yun
2020-08-19 14:59 ` Alan Stern
2020-08-20 1:57 ` Chunfeng Yun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597888623.23067.19.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).