From: "Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)" <dzagorui@cisco.com>
To: David Miller <davem@davemloft.net>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"ap420073@gmail.com" <ap420073@gmail.com>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"mkubecek@suse.cz" <mkubecek@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc
Date: Wed, 26 Aug 2020 14:37:49 +0000 [thread overview]
Message-ID: <1598452669073.46639@cisco.com> (raw)
In-Reply-To: <20200817.150803.1838250925233891556.davem@davemloft.net>
>This doesn't seem appropriate at all. If anything UC addresses
>should be blocked and the Intel driver change reverted. We have
>a well defined way to add secondary UC addresses and the MC interfaces
>are not it.
As I understand by ‘well defined way’ you mean macvlan feature. But macvlan
is more virtualisation thing where an additional netdevice is created and for each
skb passed to linux stack hash_lookup is made to find a netdevice to which this
skb belongs to based on mac_dst. In case if someone want to have a network
protocol on top of physical layer (AF_PACKET) where NIC should allow several uc
mac addr without enabling promiscuous mode i am not sure that for this simple
task macvlan is needed.
>Furthermore, even if this was appropriate, "fixing" this only for
>ethernet is definitely not appropriate. The fix would need to be able
>to handle any address type. Having a generic interface work
>inconsistently for one link type vs. another is a non-starter.
Maybe overusing multicast api isn’t the best choice for this purpose, but i noticed
that it is already overused by i40 for the same purpose, that is why i suggested
this diff. Anyway i can add separate ioctls for add/del secondary uc, if this is worth it.
prev parent reply other threads:[~2020-08-26 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 17:52 [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc Denys Zagorui
2020-08-17 22:08 ` David Miller
2020-08-26 14:37 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598452669073.46639@cisco.com \
--to=dzagorui@cisco.com \
--cc=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).