From: David Miller <davem@davemloft.net>
To: dzagorui@cisco.com
Cc: kuba@kernel.org, netdev@vger.kernel.org,
"ikhoronz@cisco.com--cc=xe-linux-external"@cisco.com,
xiyou.wangcong@gmail.com, ap420073@gmail.com,
richardcochran@gmail.com, f.fainelli@gmail.com, andrew@lunn.ch,
mkubecek@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc
Date: Mon, 17 Aug 2020 15:08:03 -0700 (PDT) [thread overview]
Message-ID: <20200817.150803.1838250925233891556.davem@davemloft.net> (raw)
In-Reply-To: <20200817175224.49608-1-dzagorui@cisco.com>
From: Denys Zagorui <dzagorui@cisco.com>
Date: Mon, 17 Aug 2020 10:52:24 -0700
> SIOCADDMULTI API allows adding multicast/unicast mac addresses but
> doesn't deferentiate them so if someone tries to add secondary
> unicast mac addr it will be added to multicast netdev list which is
> confusing. There is at least one user that allows adding secondary
> unicast through this API.
> (2f41f3358672 i40e/i40evf: fix unicast mac address add)
This doesn't seem appropriate at all. If anything UC addresses
should be blocked and the Intel driver change reverted. We have
a well defined way to add secondary UC addresses and the MC interfaces
are not it.
Furthermore, even if this was appropriate, "fixing" this only for
ethernet is definitely not appropriate. The fix would need to be able
to handle any address type. Having a generic interface work
inconsistently for one link type vs. another is a non-starter.
Thanks.
next prev parent reply other threads:[~2020-08-17 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 17:52 [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc Denys Zagorui
2020-08-17 22:08 ` David Miller [this message]
2020-08-26 14:37 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817.150803.1838250925233891556.davem@davemloft.net \
--to=davem@davemloft.net \
--cc="ikhoronz@cisco.com--cc=xe-linux-external"@cisco.com \
--cc=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=dzagorui@cisco.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).