From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Allen Pais <allen.lkml@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] linux/kernel.h: add container_from()
Date: Thu, 27 Aug 2020 11:32:13 -0700 [thread overview]
Message-ID: <1598553133.4237.8.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAHk-=whiEUUrtnbgUH2xsD0+jNyoXudYJ4hGCA55MCjryaHGjw@mail.gmail.com>
On Thu, 2020-08-27 at 11:04 -0700, Linus Torvalds wrote:
> On Wed, Aug 26, 2020 at 6:36 PM Allen Pais <allen.lkml@gmail.com>
> wrote:
> >
> > Introduce container_from() as a generic helper instead of
> > sub-systems defining a private from_
>
> NAK.
>
> This seems completely broken.
>
> The documentation comment doesn't even match the macro, and claims
> that "container" is a type.
>
> Which it isn't. That's what container_of()" already takes.
>
> And if the argument is that a broken commit introduced a broken
> macro,
> then that's not a great argument. Yes, we have that broken
> "from_tasklet()" macro, but it's not even *USED* anywhere.
>
> So instead of adding a broken new concept that adds absolutely no
> value, let's just remove the broken macro that isn't even used.
The argument is more over the tasklet rework adding from_tasklet that
was effectively completely generic.
https://lore.kernel.org/dri-devel/20200817091617.28119-1-allen.cryptic@gmail.com/
The tasklet rework people don't want to use container_of, which was our
first suggestion, because it produces lines which are "too long". So
container_from is a compromise that takes the actual structure pointer
as a second argument instead of the structure type, thus being
completely generic and suitable for line length reduction in the
tasklet rework code.
James
next prev parent reply other threads:[~2020-08-27 18:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 1:36 [PATCH] linux/kernel.h: add container_from() Allen Pais
2020-08-27 2:31 ` Kees Cook
2020-08-27 12:19 ` Greg Kroah-Hartman
2020-08-27 17:50 ` Kees Cook
2020-08-27 18:04 ` Linus Torvalds
2020-08-27 18:32 ` James Bottomley [this message]
2020-08-27 18:40 ` Linus Torvalds
2020-08-27 18:48 ` Linus Torvalds
2020-08-27 19:28 ` Kees Cook
2020-08-27 20:46 ` Linus Torvalds
2020-08-27 21:36 ` Al Viro
2020-08-27 22:14 ` Kees Cook
2020-08-28 7:09 ` Allen
2020-08-28 7:07 ` Allen
2020-08-27 18:07 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598553133.4237.8.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).