linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: vdso32: make vdso32 install conditional
@ 2020-08-27 23:40 Frank van der Linden
  2020-08-28 12:31 ` Catalin Marinas
  0 siblings, 1 reply; 2+ messages in thread
From: Frank van der Linden @ 2020-08-27 23:40 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, catalin.marinas, will
  Cc: Frank van der Linden

vdso32 should only be installed if CONFIG_COMPAT_VDSO is enabled,
since it's not even supposed to be compiled otherwise, and arm64
builds without a 32bit crosscompiler will fail.

Signed-off-by: Frank van der Linden <fllinden@amazon.com>
Fixes: 8d75785a8142 ("ARM64: vdso32: Install vdso32 from vdso_install")
Cc: stable@vger.kernel.org [5.4+]
---
 arch/arm64/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index b45f0124cc16..100abbb19e0b 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -165,7 +165,8 @@ zinstall install:
 PHONY += vdso_install
 vdso_install:
 	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso $@
-	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso32 $@
+	$(if $(CONFIG_COMPAT_VDSO),$(Q)$(MAKE) \
+		$(build)=arch/arm64/kernel/vdso32 $@)
 
 # We use MRPROPER_FILES and CLEAN_FILES now
 archclean:
-- 
2.16.6


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: vdso32: make vdso32 install conditional
  2020-08-27 23:40 [PATCH] arm64: vdso32: make vdso32 install conditional Frank van der Linden
@ 2020-08-28 12:31 ` Catalin Marinas
  0 siblings, 0 replies; 2+ messages in thread
From: Catalin Marinas @ 2020-08-28 12:31 UTC (permalink / raw)
  To: will, linux-arm-kernel, Frank van der Linden, linux-kernel

On Thu, 27 Aug 2020 23:40:12 +0000, Frank van der Linden wrote:
> vdso32 should only be installed if CONFIG_COMPAT_VDSO is enabled,
> since it's not even supposed to be compiled otherwise, and arm64
> builds without a 32bit crosscompiler will fail.

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: vdso32: make vdso32 install conditional
      https://git.kernel.org/arm64/c/5d28ba5f8a0c

-- 
Catalin


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-28 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27 23:40 [PATCH] arm64: vdso32: make vdso32 install conditional Frank van der Linden
2020-08-28 12:31 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).