From: satya priya <skakit@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
gregkh@linuxfoundation.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, akashast@codeaurora.org,
rojay@codeaurora.org, msavaliy@qti.qualcomm.com,
dianders@chromium.org, satya priya <skakit@codeaurora.org>
Subject: [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART
Date: Thu, 10 Sep 2020 18:23:56 +0530 [thread overview]
Message-ID: <1599742438-16811-3-git-send-email-skakit@codeaurora.org> (raw)
In-Reply-To: <1599742438-16811-1-git-send-email-skakit@codeaurora.org>
Add a suitable sleep configuration for uart3 to support Bluetooth wakeup.
If QUP function is selected in sleep state, UART RTS/RFR is pulled high
during suspend and BT SoC not able to send wakeup bytes. So, configure
GPIO mode in sleep state to keep it low during suspend.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Akash Asthana <akashast@codeaurora.org>
---
Changes in V2:
- This patch adds sleep state for BT UART. Newly added in V2.
Changes in V3:
- Remove "output-high" for TX from both sleep and default states
as it is not required. Configure pull-up for TX in sleep state.
Changes in V4:
- As per Matthias's comment, removed drive-strength for sleep state
and fixed nit-pick.
Changes in V5:
- As per Matthias's comments, moved pinmux change for sleep state,
pinctrl and interrupt config to the board specific file.
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 48 +++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 04888df..e529a41 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -344,6 +344,10 @@
};
&uart3 {
+ pinctrl-names = "default", "sleep";
+ pinctrl-1 = <&qup_uart3_sleep>;
+ interrupts-extended = <&intc GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>,
+ <&tlmm 41 IRQ_TYPE_EDGE_FALLING>;
status = "okay";
bluetooth: wcn3990-bt {
@@ -545,3 +549,47 @@
};
};
+&tlmm {
+ qup_uart3_sleep: qup-uart3-sleep {
+ pinmux {
+ pins = "gpio38", "gpio39",
+ "gpio40", "gpio41";
+ function = "gpio";
+ };
+
+ pinconf-cts {
+ /*
+ * Configure a pull-down on CTS to match the pull of
+ * the Bluetooth module.
+ */
+ pins = "gpio38";
+ bias-pull-down;
+ };
+
+ pinconf-rts {
+ /*
+ * Configure pull-down on RTS to make sure that the BT SoC can
+ * wake up the system by sending wakeup bytes during suspend.
+ */
+ pins = "gpio39";
+ bias-pull-down;
+ };
+
+ pinconf-tx {
+ /* Configure pull-up on TX when it isn't actively driven */
+ pins = "gpio40";
+ bias-pull-up;
+ };
+
+ pinconf-rx {
+ /*
+ * Configure a pull-up on RX. This is needed to avoid
+ * garbage data when the TX pin of the Bluetooth module is
+ * in tri-state (module powered off or not driving the
+ * signal yet).
+ */
+ pins = "gpio41";
+ bias-pull-up;
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-09-10 13:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 12:53 [PATCH V5 0/4] Add wakeup support over UART RX satya priya
2020-09-10 12:53 ` [PATCH V5 1/4] arm64: dts: qcom: sc7180: Improve the pin config settings for CTS and TX satya priya
2020-09-10 14:40 ` Doug Anderson
2020-09-11 10:14 ` skakit
2020-09-10 12:53 ` satya priya [this message]
2020-09-10 14:40 ` [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART Doug Anderson
2020-09-11 10:15 ` skakit
2020-09-11 13:52 ` Bjorn Andersson
2020-09-11 15:30 ` Doug Anderson
2020-09-10 15:35 ` Matthias Kaehlcke
2020-09-11 10:15 ` skakit
2020-09-10 23:45 ` Bjorn Andersson
2020-09-11 10:16 ` skakit
2020-09-10 12:53 ` [PATCH V5 3/4] arm64: dts: qcom: sc7180-trogdor: Add " satya priya
2020-09-10 14:42 ` Doug Anderson
2020-09-11 10:15 ` skakit
2020-09-10 12:53 ` [PATCH V5 4/4] tty: serial: qcom_geni_serial: Fix the UART wakeup issue satya priya
2020-09-10 23:06 ` Bjorn Andersson
2020-09-16 12:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599742438-16811-3-git-send-email-skakit@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).