From: Doug Anderson <dianders@chromium.org>
To: satya priya <skakit@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Akash Asthana <akashast@codeaurora.org>,
Roja Rani Yarubandi <rojay@codeaurora.org>,
msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V5 1/4] arm64: dts: qcom: sc7180: Improve the pin config settings for CTS and TX
Date: Thu, 10 Sep 2020 07:40:00 -0700 [thread overview]
Message-ID: <CAD=FV=XYqiGk3QEPxVKCgnYA0FVrizyarSW52HPRGVyAUSugrQ@mail.gmail.com> (raw)
In-Reply-To: <1599742438-16811-2-git-send-email-skakit@codeaurora.org>
Hi,
On Thu, Sep 10, 2020 at 5:55 AM satya priya <skakit@codeaurora.org> wrote:
>
> Remove output-high from CTS and TX as this is not really required. During
> bringup to fix transfer failures this was added to match with console uart
> settings. Probably some boot loader config was missing then. As it is
> working fine now, remove it.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Akash Asthana <akashast@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in V4:
> - This is newly added in V4 to separate the improvements in pin settings
> and wakeup related changes.
>
> Changes in V5:
> - As per Doug's comment configured pull-down for CTS pin as earlier.
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Looks fine to me. Slight nit that this only applies to the IDP board
but ${SUBJECT} makes it sound as if this applies to all sc7180. I
wouldn't spin just for that, though. If Bjorn agrees, he can always
adjust the subject when applying.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2020-09-10 21:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 12:53 [PATCH V5 0/4] Add wakeup support over UART RX satya priya
2020-09-10 12:53 ` [PATCH V5 1/4] arm64: dts: qcom: sc7180: Improve the pin config settings for CTS and TX satya priya
2020-09-10 14:40 ` Doug Anderson [this message]
2020-09-11 10:14 ` skakit
2020-09-10 12:53 ` [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART satya priya
2020-09-10 14:40 ` Doug Anderson
2020-09-11 10:15 ` skakit
2020-09-11 13:52 ` Bjorn Andersson
2020-09-11 15:30 ` Doug Anderson
2020-09-10 15:35 ` Matthias Kaehlcke
2020-09-11 10:15 ` skakit
2020-09-10 23:45 ` Bjorn Andersson
2020-09-11 10:16 ` skakit
2020-09-10 12:53 ` [PATCH V5 3/4] arm64: dts: qcom: sc7180-trogdor: Add " satya priya
2020-09-10 14:42 ` Doug Anderson
2020-09-11 10:15 ` skakit
2020-09-10 12:53 ` [PATCH V5 4/4] tty: serial: qcom_geni_serial: Fix the UART wakeup issue satya priya
2020-09-10 23:06 ` Bjorn Andersson
2020-09-16 12:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XYqiGk3QEPxVKCgnYA0FVrizyarSW52HPRGVyAUSugrQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).