From: Hari Bathini <hbathini@linux.ibm.com>
To: Michal Suchanek <msuchanek@suse.de>, linuxppc-dev@lists.ozlabs.org
Cc: Yangtao Li <tiny.windzz@gmail.com>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] powerpc/fadump: when fadump is supported register the fadump sysfs files.
Date: Thu, 29 Aug 2019 10:58:16 +0530 [thread overview]
Message-ID: <15be95b0-4cb2-1cf1-2fc1-ec313b9aa6f0@linux.ibm.com> (raw)
In-Reply-To: <20190828172742.18378-1-msuchanek@suse.de>
On 28/08/19 10:57 PM, Michal Suchanek wrote:
> Currently it is not possible to distinguish the case when fadump is
> supported by firmware and disabled in kernel and completely unsupported
> using the kernel sysfs interface. User can investigate the devicetree
> but it is more reasonable to provide sysfs files in case we get some
> fadumpv2 in the future.
>
> With this patch sysfs files are available whenever fadump is supported
> by firmware.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
[...]
> - if (!fw_dump.fadump_supported) {
> + if (!fw_dump.fadump_supported && fw_dump.fadump_enabled) {
> printk(KERN_ERR "Firmware-assisted dump is not supported on"
> " this hardware\n");
> - return 0;
> }
The above hunk is redundant with similar message already logged during
early boot in fadump_reserve_mem() function. I am not strongly against
this though. So...
Acked-by: Hari Bathini <hbathini@linux.ibm.com>
next prev parent reply other threads:[~2019-08-29 5:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 18:12 [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files Michal Suchanek
2019-08-27 12:27 ` Hari Bathini
2019-08-28 17:07 ` Michal Suchánek
2019-08-29 5:20 ` Hari Bathini
2019-08-28 17:27 ` [PATCH v2] " Michal Suchanek
2019-08-29 5:28 ` Hari Bathini [this message]
2019-09-04 18:35 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15be95b0-4cb2-1cf1-2fc1-ec313b9aa6f0@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=msuchanek@suse.de \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).