From: Hari Bathini <hbathini@linux.ibm.com>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: linuxppc-dev@lists.ozlabs.org, Yangtao Li <tiny.windzz@gmail.com>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files.
Date: Thu, 29 Aug 2019 10:50:52 +0530 [thread overview]
Message-ID: <263584eb-0e74-d8a4-613c-14877a42f155@linux.ibm.com> (raw)
In-Reply-To: <20190828190721.555b6337@naga>
On 28/08/19 10:37 PM, Michal Suchánek wrote:
> On Tue, 27 Aug 2019 17:57:31 +0530
> Hari Bathini <hbathini@linux.ibm.com> wrote:
>
[...]
>> Also, get rid of the error message when fadump is
>> not supported as it is already taken care of in fadump_reserve_mem() function.
>
> That should not be called in that case, should it?
fadump_reserve_mem() is called during early boot while this is an initcall that happens
later. Not sure if we can make the initcall conditional on fadump support though..
> Anyway, I find the message right next to the message about reserving
> memory for kdump. So it really looks helpful in the log.
The message you see right after memory reservation for kdump is coming from
fadump_reserve_mem() function. This is the repeat of the same message logged
much later...
- Hari
next prev parent reply other threads:[~2019-08-29 5:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 18:12 [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files Michal Suchanek
2019-08-27 12:27 ` Hari Bathini
2019-08-28 17:07 ` Michal Suchánek
2019-08-29 5:20 ` Hari Bathini [this message]
2019-08-28 17:27 ` [PATCH v2] " Michal Suchanek
2019-08-29 5:28 ` Hari Bathini
2019-09-04 18:35 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=263584eb-0e74-d8a4-613c-14877a42f155@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=msuchanek@suse.de \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).