linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Implement arm64 specific huge_ptep_get()
@ 2022-05-13  3:37 Baolin Wang
  2022-05-13  3:37 ` [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page Baolin Wang
  2022-05-13  3:37 ` [PATCH v2 2/2] arm64/hugetlb: Implement arm64 specific huge_ptep_get() Baolin Wang
  0 siblings, 2 replies; 7+ messages in thread
From: Baolin Wang @ 2022-05-13  3:37 UTC (permalink / raw)
  To: catalin.marinas, will
  Cc: mike.kravetz, akpm, songmuchun, willy, anshuman.khandual,
	christophe.leroy, baolin.wang, linux-arm-kernel, linux-kernel,
	linux-mm

Hi,

As Mike pointed out [1], the huge_ptep_get() will only return one specific
pte value for the CONT-PTE or CONT-PMD size hugetlb on ARM64 system, which
will not take into account the subpages' dirty or young bits of a CONT-PTE/PMD
size hugetlb page. That will make us miss dirty or young flags of a CONT-PTE/PMD
size hugetlb page for those functions that want to check the dirty or
young flags of a hugetlb page. For example, the gather_hugetlb_stats() will
get inaccurate dirty hugetlb page statistics, and the DAMON for hugetlb monitoring
will also get inaccurate access statistics.

To fix this issue, this patch set introduces an ARM64 specific huge_ptep_get()
implementation, which will take into account any subpages' dirty or young bits.

[1] https://lore.kernel.org/linux-mm/85bd80b4-b4fd-0d3f-a2e5-149559f2f387@oracle.com/

Changes from v1:
 - Rebase on next-20220512.
 - Update commit message suggested by Muchun.
 - Add reviewed tag from Muchun.

Changes from RFC:
 - Implement arm64 specific huge_ptep_get() instead of introducing a new interface.
 - Add a new patch to convert huge_ptep_get() in hugetlbpage.c

Baolin Wang (2):
  arm64/hugetlb: Use ptep_get() to get the pte value of a huge page
  arm64/hugetlb: Implement arm64 specific huge_ptep_get()

 arch/arm64/include/asm/hugetlb.h |  2 ++
 arch/arm64/mm/hugetlbpage.c      | 32 ++++++++++++++++++++++++++++----
 2 files changed, 30 insertions(+), 4 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-05-14  3:00 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-13  3:37 [PATCH v2 0/2] Implement arm64 specific huge_ptep_get() Baolin Wang
2022-05-13  3:37 ` [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page Baolin Wang
2022-05-13 10:50   ` Anshuman Khandual
2022-05-14  1:42     ` Baolin Wang
2022-05-13  3:37 ` [PATCH v2 2/2] arm64/hugetlb: Implement arm64 specific huge_ptep_get() Baolin Wang
2022-05-13 11:03   ` Anshuman Khandual
2022-05-14  1:43     ` Baolin Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).