* [PATCH net-next] net: pxa168_eth: remove unused variable 'retval' int pxa168_eth_change_mtu()
@ 2020-09-14 13:19 Zhang Changzhong
2020-09-14 20:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2020-09-14 13:19 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning:
variable 'retval' set but not used [-Wunused-but-set-variable]
1190 | int retval;
| ^~~~~~
Function pxa168_eth_change_mtu() always return zero, so variable 'retval'
is redundant, just remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/ethernet/marvell/pxa168_eth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
index faac94b..d1e4d42 100644
--- a/drivers/net/ethernet/marvell/pxa168_eth.c
+++ b/drivers/net/ethernet/marvell/pxa168_eth.c
@@ -1187,11 +1187,10 @@ static int pxa168_eth_stop(struct net_device *dev)
static int pxa168_eth_change_mtu(struct net_device *dev, int mtu)
{
- int retval;
struct pxa168_eth_private *pep = netdev_priv(dev);
dev->mtu = mtu;
- retval = set_port_config_ext(pep);
+ set_port_config_ext(pep);
if (!netif_running(dev))
return 0;
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: pxa168_eth: remove unused variable 'retval' int pxa168_eth_change_mtu()
2020-09-14 13:19 [PATCH net-next] net: pxa168_eth: remove unused variable 'retval' int pxa168_eth_change_mtu() Zhang Changzhong
@ 2020-09-14 20:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-09-14 20:43 UTC (permalink / raw)
To: zhangchangzhong; +Cc: kuba, netdev, linux-kernel
From: Zhang Changzhong <zhangchangzhong@huawei.com>
Date: Mon, 14 Sep 2020 21:19:12 +0800
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning:
> variable 'retval' set but not used [-Wunused-but-set-variable]
> 1190 | int retval;
> | ^~~~~~
>
> Function pxa168_eth_change_mtu() always return zero, so variable 'retval'
> is redundant, just remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-14 20:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 13:19 [PATCH net-next] net: pxa168_eth: remove unused variable 'retval' int pxa168_eth_change_mtu() Zhang Changzhong
2020-09-14 20:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).