[PATCH 1/5] rtc: pcf2127: fix a bug when not specify interrupts property

[PATCH 1/5] rtc: pcf2127: fix a bug when not specify interrupts property

[Biwen Li]

From: Biwen Li <biwen.li@nxp.com>

Fix a bug when not specify interrupts property in dts
as follows,
    rtc-pcf2127-i2c 1-0051: failed to request alarm irq
    rtc-pcf2127-i2c: probe of 1-0051 failed with error -22

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 drivers/rtc/rtc-pcf2127.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
index ed6316992cbb..07a5630ec841 100644
--- a/drivers/rtc/rtc-pcf2127.c
+++ b/drivers/rtc/rtc-pcf2127.c
@@ -559,7 +559,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
 	pcf2127->rtc->set_start_time = true; /* Sets actual start to 1970 */
 	pcf2127->rtc->uie_unsupported = 1;
 
-	if (alarm_irq >= 0) {
+	if (alarm_irq > 0) {
 		ret = devm_request_threaded_irq(dev, alarm_irq, NULL,
 						pcf2127_rtc_irq,
 						IRQF_TRIGGER_LOW | IRQF_ONESHOT,
@@ -570,7 +570,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
 		}
 	}
 
-	if (alarm_irq >= 0 || device_property_read_bool(dev, "wakeup-source")) {
+	if (alarm_irq > 0 || device_property_read_bool(dev, "wakeup-source")) {
 		device_init_wakeup(dev, true);
 		pcf2127->rtc->ops = &pcf2127_rtc_alrm_ops;
 	}
-- 
2.17.1

[PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

[Biwen Li]

From: Biwen Li <biwen.li@nxp.com>

Remove useless property interrupts of rtc

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
index dce79018d397..e9e982176e07 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
@@ -171,8 +171,6 @@
 	rtc@51 {
 		compatible = "nxp,pcf2129";
 		reg = <0x51>;
-		// IRQ10_B
-		interrupts = <0 150 0x4>;
 	};
 };
 
-- 
2.17.1

Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

[Shawn Guo]

On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> Remove useless property interrupts of rtc
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> index dce79018d397..e9e982176e07 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -171,8 +171,6 @@
>  	rtc@51 {
>  		compatible = "nxp,pcf2129";
>  		reg = <0x51>;
> -		// IRQ10_B
> -		interrupts = <0 150 0x4>;

If it's a correct description of hardware, I do not see why we would
need to remove it.

Shawn

>  	};
>  };
>  
> -- 
> 2.17.1
> 

RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

[Biwen Li]

> 
> Caution: EXT Email
> 
> On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > From: Biwen Li <biwen.li@nxp.com>
> >
> > Remove useless property interrupts of rtc
> >
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > index dce79018d397..e9e982176e07 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > @@ -171,8 +171,6 @@
> >       rtc@51 {
> >               compatible = "nxp,pcf2129";
> >               reg = <0x51>;
> > -             // IRQ10_B
> > -             interrupts = <0 150 0x4>;
> 
> If it's a correct description of hardware, I do not see why we would need to
> remove it.
Hi Shawn,

Don't need use the interrupt, only read time from rtc.

Best Regards,
Biwen Li
> 
> Shawn
> 
> >       };
> >  };
> >
> > --
> > 2.17.1
> >

RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

[Leo Li]

> -----Original Message-----
> From: Biwen Li <biwen.li@nxp.com>
> Sent: Monday, September 21, 2020 10:13 PM
> To: Shawn Guo <shawnguo@kernel.org>; Biwen Li (OSS)
> <biwen.li@oss.nxp.com>
> Cc: alexandre.belloni@bootlin.com; Leo Li <leoyang.li@nxp.com>;
> robh+dt@kernel.org; mark.rutland@arm.com; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>; linux-
> rtc@vger.kernel.org
> Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless
> property of rtc
> 
> >
> > Caution: EXT Email
> >
> > On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > > From: Biwen Li <biwen.li@nxp.com>
> > >
> > > Remove useless property interrupts of rtc
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > index dce79018d397..e9e982176e07 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > @@ -171,8 +171,6 @@
> > >       rtc@51 {
> > >               compatible = "nxp,pcf2129";
> > >               reg = <0x51>;
> > > -             // IRQ10_B
> > > -             interrupts = <0 150 0x4>;
> >
> > If it's a correct description of hardware, I do not see why we would
> > need to remove it.
> Hi Shawn,
> 
> Don't need use the interrupt, only read time from rtc.

User probably will choose to use the alarm feature of the RTC and need the interrupt property.  Is there any issue when the interrupt property is present?

> 
> Best Regards,
> Biwen Li
> >
> > Shawn
> >
> > >       };
> > >  };
> > >
> > > --
> > > 2.17.1
> > >

RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

[Biwen Li]

> 
> 
> 
> > -----Original Message-----
> > From: Biwen Li <biwen.li@nxp.com>
> > Sent: Monday, September 21, 2020 10:13 PM
> > To: Shawn Guo <shawnguo@kernel.org>; Biwen Li (OSS)
> > <biwen.li@oss.nxp.com>
> > Cc: alexandre.belloni@bootlin.com; Leo Li <leoyang.li@nxp.com>;
> > robh+dt@kernel.org; mark.rutland@arm.com; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>; linux-
> > rtc@vger.kernel.org
> > Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove
> > useless property of rtc
> >
> > >
> > > Caution: EXT Email
> > >
> > > On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > > > From: Biwen Li <biwen.li@nxp.com>
> > > >
> > > > Remove useless property interrupts of rtc
> > > >
> > > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > index dce79018d397..e9e982176e07 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > @@ -171,8 +171,6 @@
> > > >       rtc@51 {
> > > >               compatible = "nxp,pcf2129";
> > > >               reg = <0x51>;
> > > > -             // IRQ10_B
> > > > -             interrupts = <0 150 0x4>;
> > >
> > > If it's a correct description of hardware, I do not see why we would
> > > need to remove it.
> > Hi Shawn,
> >
> > Don't need use the interrupt, only read time from rtc.
> 
> User probably will choose to use the alarm feature of the RTC and need the
> interrupt property.  Is there any issue when the interrupt property is present?
Generic interrupt controller on layerscape only support  IRQ_TYPE_LEVEL_HIGH and  IRQ_TYPE_EDGE_RISING(except SoC LS1043A, LS1046A),
Not support IRQ_TYPE_LEVEL_LOW,
In drivers/rtc/rtc-pcf2127.c
ret = devm_request_threaded_irq(dev, alarm_irq, NULL,
pcf2127_rtc_irq,
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
dev_name(dev), dev);

> 
> >
> > Best Regards,
> > Biwen Li
> > >
> > > Shawn
> > >
> > > >       };
> > > >  };
> > > >
> > > > --
> > > > 2.17.1
> > > >

Re: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

[Li Yang]

On Mon, Sep 21, 2020 at 10:56 PM Biwen Li <biwen.li@nxp.com> wrote:
>
> >
> >
> >
> > > -----Original Message-----
> > > From: Biwen Li <biwen.li@nxp.com>
> > > Sent: Monday, September 21, 2020 10:13 PM
> > > To: Shawn Guo <shawnguo@kernel.org>; Biwen Li (OSS)
> > > <biwen.li@oss.nxp.com>
> > > Cc: alexandre.belloni@bootlin.com; Leo Li <leoyang.li@nxp.com>;
> > > robh+dt@kernel.org; mark.rutland@arm.com; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; Jiafei Pan <jiafei.pan@nxp.com>; linux-
> > > rtc@vger.kernel.org
> > > Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove
> > > useless property of rtc
> > >
> > > >
> > > > Caution: EXT Email
> > > >
> > > > On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > > > > From: Biwen Li <biwen.li@nxp.com>
> > > > >
> > > > > Remove useless property interrupts of rtc
> > > > >
> > > > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > > > ---
> > > > >  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> > > > >  1 file changed, 2 deletions(-)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > > index dce79018d397..e9e982176e07 100644
> > > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > > @@ -171,8 +171,6 @@
> > > > >       rtc@51 {
> > > > >               compatible = "nxp,pcf2129";
> > > > >               reg = <0x51>;
> > > > > -             // IRQ10_B
> > > > > -             interrupts = <0 150 0x4>;
> > > >
> > > > If it's a correct description of hardware, I do not see why we would
> > > > need to remove it.
> > > Hi Shawn,
> > >
> > > Don't need use the interrupt, only read time from rtc.
> >
> > User probably will choose to use the alarm feature of the RTC and need the
> > interrupt property.  Is there any issue when the interrupt property is present?
> Generic interrupt controller on layerscape only support  IRQ_TYPE_LEVEL_HIGH and  IRQ_TYPE_EDGE_RISING(except SoC LS1043A, LS1046A),
> Not support IRQ_TYPE_LEVEL_LOW,

That is not true.  Although the GIC SPI only deals with level high and
rising edge, there is a separate IRQCR register on LX2160 that can
invert external interrupt.  If the current LX2160 code doesn't support
that, we need to fix it.  Adding Varun for this.  We probably can
extend the existing drivers/irqchip/irq-ls-extirq.c driver to support
LX2160.

And btw, the interrupt number 150 is obviously wrong too.  We probably
can remove it temporarily before the external interrupt is properly
supported on lx2160.

> In drivers/rtc/rtc-pcf2127.c
> ret = devm_request_threaded_irq(dev, alarm_irq, NULL,
> pcf2127_rtc_irq,
> IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> dev_name(dev), dev);
>
> >
> > >
> > > Best Regards,
> > > Biwen Li
> > > >
> > > > Shawn
> > > >
> > > > >       };
> > > > >  };
> > > > >
> > > > > --
> > > > > 2.17.1
> > > > >

[PATCH 3/5] arm64: dts: ls1088a-rdb: remove useless property of rtc

[Biwen Li]

From: Biwen Li <biwen.li@nxp.com>

Remove useless property interrupts of rtc

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
index f651f4a5a54b..b543389155b0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
@@ -51,8 +51,6 @@
 			rtc@51 {
 				compatible = "nxp,pcf2129";
 				reg = <0x51>;
-				/* IRQ10_B */
-				interrupts = <0 150 IRQ_TYPE_LEVEL_HIGH>;
 			};
 		};
 	};
-- 
2.17.1

[PATCH 4/5] arm64: dts : ls1088a-qds: remove useless property of rtc

[Biwen Li]

From: Biwen Li <biwen.li@nxp.com>

Remove useless property interrupts of rtc

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
index 5b2699fe4e5d..329a9428ae8b 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts
@@ -90,8 +90,6 @@
 			rtc@51 {
 				compatible = "nxp,pcf2129";
 				reg = <0x51>;
-				/* IRQ10_B */
-				interrupts = <0 150 IRQ_TYPE_LEVEL_HIGH>;
 			};
 
 			eeprom@56 {
-- 
2.17.1

[PATCH 5/5] arm64: dts: ls1046a-qds: remove useless property of rtc

[Biwen Li]

From: Biwen Li <biwen.li@nxp.com>

Remove useless property interrupts of rtc

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index 35fa10a5d594..f13a45bdf4e9 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -122,8 +122,6 @@
 			rtc@51 {
 				compatible = "nxp,pcf2129";
 				reg = <0x51>;
-				/* IRQ10_B */
-				interrupts = <0 150 0x4>;
 			};
 
 			eeprom@56 {
-- 
2.17.1

Re: [PATCH 1/5] rtc: pcf2127: fix a bug when not specify interrupts property

[Alexandre Belloni]

On Tue, 15 Sep 2020 15:32:09 +0800, Biwen Li wrote:
> Fix a bug when not specify interrupts property in dts
> as follows,
>     rtc-pcf2127-i2c 1-0051: failed to request alarm irq
>     rtc-pcf2127-i2c: probe of 1-0051 failed with error -22

Applied, thanks!

[1/1] rtc: pcf2127: fix a bug when not specify interrupts property
      commit: 35425bafc772ee189e3c3790d7c672b80ba65909

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>