* [PATCH net-next] net: mventa: remove unused variable 'dummy' in mvneta_mib_counters_clear()
@ 2020-09-19 2:26 Zhang Changzhong
2020-09-20 21:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2020-09-19 2:26 UTC (permalink / raw)
To: thomas.petazzoni, davem, kuba; +Cc: netdev, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/marvell/mvneta.c:754:6: warning:
variable 'dummy' set but not used [-Wunused-but-set-variable]
754 | u32 dummy;
| ^~~~~
This variable is not used in function mvneta_mib_counters_clear(), so
remove it to avoid build warning.
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/ethernet/marvell/mvneta.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index f75e05e..4694242 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -751,13 +751,12 @@ static void mvneta_txq_inc_put(struct mvneta_tx_queue *txq)
static void mvneta_mib_counters_clear(struct mvneta_port *pp)
{
int i;
- u32 dummy;
/* Perform dummy reads from MIB counters */
for (i = 0; i < MVNETA_MIB_LATE_COLLISION; i += 4)
- dummy = mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i));
- dummy = mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT);
- dummy = mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT);
+ mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i));
+ mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT);
+ mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT);
}
/* Get System Network Statistics */
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: mventa: remove unused variable 'dummy' in mvneta_mib_counters_clear()
2020-09-19 2:26 [PATCH net-next] net: mventa: remove unused variable 'dummy' in mvneta_mib_counters_clear() Zhang Changzhong
@ 2020-09-20 21:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-09-20 21:18 UTC (permalink / raw)
To: zhangchangzhong; +Cc: thomas.petazzoni, kuba, netdev, linux-kernel
From: Zhang Changzhong <zhangchangzhong@huawei.com>
Date: Sat, 19 Sep 2020 10:26:51 +0800
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/marvell/mvneta.c:754:6: warning:
> variable 'dummy' set but not used [-Wunused-but-set-variable]
> 754 | u32 dummy;
> | ^~~~~
>
> This variable is not used in function mvneta_mib_counters_clear(), so
> remove it to avoid build warning.
>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-20 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-19 2:26 [PATCH net-next] net: mventa: remove unused variable 'dummy' in mvneta_mib_counters_clear() Zhang Changzhong
2020-09-20 21:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).