* [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables
@ 2020-09-11 1:37 Jason Yan
2020-09-13 4:00 ` Bjorn Andersson
2020-09-22 18:50 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-09-11 1:37 UTC (permalink / raw)
To: agross, bjorn.andersson, mturquette, sboyd, linux-arm-msm,
linux-clk, linux-kernel
Cc: Jason Yan, Hulk Robot
This addresses the following gcc warning with "make W=1":
drivers/clk/qcom/gcc-msm8939.c:610:32: warning:
‘gcc_xo_gpll6_gpll0a_map’ defined but not used
[-Wunused-const-variable=]
static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
^~~~~~~~~~~~~~~~~~~~~~~
drivers/clk/qcom/gcc-msm8939.c:598:32: warning: ‘gcc_xo_gpll6_gpll0_map’
defined but not used [-Wunused-const-variable=]
static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
^~~~~~~~~~~~~~~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/clk/qcom/gcc-msm8939.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 778354f82b1e..39ebb443ae3d 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -595,24 +595,12 @@ static const struct clk_parent_data gcc_xo_gpll1_emclk_sleep_parent_data[] = {
{ .fw_name = "sleep_clk", .name = "sleep_clk" },
};
-static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
- { P_XO, 0 },
- { P_GPLL6, 1 },
- { P_GPLL0, 2 },
-};
-
static const struct clk_parent_data gcc_xo_gpll6_gpll0_parent_data[] = {
{ .fw_name = "xo" },
{ .hw = &gpll6_vote.hw },
{ .hw = &gpll0_vote.hw },
};
-static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
- { P_XO, 0 },
- { P_GPLL6, 1 },
- { P_GPLL0_AUX, 2 },
-};
-
static const struct clk_parent_data gcc_xo_gpll6_gpll0a_parent_data[] = {
{ .fw_name = "xo" },
{ .hw = &gpll6_vote.hw },
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables
2020-09-11 1:37 [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables Jason Yan
@ 2020-09-13 4:00 ` Bjorn Andersson
2020-09-22 18:50 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-09-13 4:00 UTC (permalink / raw)
To: Jason Yan
Cc: agross, mturquette, sboyd, linux-arm-msm, linux-clk,
linux-kernel, Hulk Robot
On Thu 10 Sep 20:37 CDT 2020, Jason Yan wrote:
> This addresses the following gcc warning with "make W=1":
>
> drivers/clk/qcom/gcc-msm8939.c:610:32: warning:
> ‘gcc_xo_gpll6_gpll0a_map’ defined but not used
> [-Wunused-const-variable=]
> static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-msm8939.c:598:32: warning: ‘gcc_xo_gpll6_gpll0_map’
> defined but not used [-Wunused-const-variable=]
> static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
> ^~~~~~~~~~~~~~~~~~~~~~
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/clk/qcom/gcc-msm8939.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 778354f82b1e..39ebb443ae3d 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -595,24 +595,12 @@ static const struct clk_parent_data gcc_xo_gpll1_emclk_sleep_parent_data[] = {
> { .fw_name = "sleep_clk", .name = "sleep_clk" },
> };
>
> -static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
> - { P_XO, 0 },
> - { P_GPLL6, 1 },
> - { P_GPLL0, 2 },
> -};
> -
> static const struct clk_parent_data gcc_xo_gpll6_gpll0_parent_data[] = {
> { .fw_name = "xo" },
> { .hw = &gpll6_vote.hw },
> { .hw = &gpll0_vote.hw },
> };
>
> -static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
> - { P_XO, 0 },
> - { P_GPLL6, 1 },
> - { P_GPLL0_AUX, 2 },
> -};
> -
> static const struct clk_parent_data gcc_xo_gpll6_gpll0a_parent_data[] = {
> { .fw_name = "xo" },
> { .hw = &gpll6_vote.hw },
> --
> 2.25.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables
2020-09-11 1:37 [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables Jason Yan
2020-09-13 4:00 ` Bjorn Andersson
@ 2020-09-22 18:50 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-09-22 18:50 UTC (permalink / raw)
To: Jason Yan, agross, bjorn.andersson, linux-arm-msm, linux-clk,
linux-kernel, mturquette
Cc: Jason Yan, Hulk Robot
Quoting Jason Yan (2020-09-10 18:37:22)
> This addresses the following gcc warning with "make W=1":
>
> drivers/clk/qcom/gcc-msm8939.c:610:32: warning:
> ‘gcc_xo_gpll6_gpll0a_map’ defined but not used
> [-Wunused-const-variable=]
> static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gcc-msm8939.c:598:32: warning: ‘gcc_xo_gpll6_gpll0_map’
> defined but not used [-Wunused-const-variable=]
> static const struct parent_map gcc_xo_gpll6_gpll0_map[] = {
> ^~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-22 18:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 1:37 [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables Jason Yan
2020-09-13 4:00 ` Bjorn Andersson
2020-09-22 18:50 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).