linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names
@ 2020-10-05  8:18 Matti Vaittinen
  2020-10-05  8:19 ` [PATCH 2/2] regulator: bd9576: Fix print Matti Vaittinen
  2020-10-05 17:54 ` [PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Matti Vaittinen @ 2020-10-05  8:18 UTC (permalink / raw)
  To: matti.vaittinen, mazziesaccount
  Cc: Liam Girdwood, Mark Brown, Matti Vaittinen, linux-kernel, linux-power

Add regulator- prefix to allowed regulator node names. Prefix is expected
by the driver and the actual binding yaml description.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
 .../devicetree/bindings/regulator/rohm,bd9576-regulator.yaml   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml b/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml
index 6df077b0db86..b6515a0cee62 100644
--- a/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/rohm,bd9576-regulator.yaml
@@ -17,7 +17,8 @@ description: |
   on the device tree.
 
   The valid names for BD9576 regulator nodes are
-  vd50, vd18, vdddr, vd10, voutl1, vouts1
+  regulator-vd50, regulator-vd18, regulator-vdddr, regulator-vd10,
+  regulator-voutl1, regulator-vouts1
 
 patternProperties:
   "regulator-.+":

base-commit: 3015c5d019879e2ef82d002506ee5d9f182f0105
-- 
2.21.0


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] regulator: bd9576: Fix print
  2020-10-05  8:18 [PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names Matti Vaittinen
@ 2020-10-05  8:19 ` Matti Vaittinen
  2020-10-05 17:54 ` [PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Matti Vaittinen @ 2020-10-05  8:19 UTC (permalink / raw)
  To: matti.vaittinen, mazziesaccount
  Cc: Liam Girdwood, Mark Brown, Matti Vaittinen, linux-kernel, linux-power

The print in probe is done using pr_info. Correct print call would be
dev_dbg because:
 - Severity should really be dbg
 - The dev pointer is given as first argument

Fixes: b014e9fae7e7de4329a7092ade4256982c5ce974
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---

Sorry folks! This should have never slip in...

 drivers/regulator/bd9576-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/bd9576-regulator.c b/drivers/regulator/bd9576-regulator.c
index 4137fa9a73bb..a8b5832a5a1b 100644
--- a/drivers/regulator/bd9576-regulator.c
+++ b/drivers/regulator/bd9576-regulator.c
@@ -275,7 +275,7 @@ static int bd957x_probe(struct platform_device *pdev)
 		dev_dbg(&pdev->dev, "Found BD9576MUF\n");
 		break;
 	case ROHM_CHIP_TYPE_BD9573:
-		pr_info(&pdev->dev, "Found BD9573MUF\n");
+		dev_dbg(&pdev->dev, "Found BD9573MUF\n");
 		break;
 	default:
 		dev_err(&pdev->dev, "Unsupported chip type\n");
-- 
2.21.0


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names
  2020-10-05  8:18 [PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names Matti Vaittinen
  2020-10-05  8:19 ` [PATCH 2/2] regulator: bd9576: Fix print Matti Vaittinen
@ 2020-10-05 17:54 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-10-05 17:54 UTC (permalink / raw)
  To: Matti Vaittinen, mazziesaccount; +Cc: Liam Girdwood, linux-power, linux-kernel

On Mon, 5 Oct 2020 11:18:19 +0300, Matti Vaittinen wrote:
> Add regulator- prefix to allowed regulator node names. Prefix is expected
> by the driver and the actual binding yaml description.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: bd9576: fix regulator binfdings dt node names
      commit: f2deb05688c25ac124a7e33bc15b1ab13d7fb1a7
[2/2] regulator: bd9576: Fix print
      commit: 184cdb8f6d391b379bb768b0c203600f5657176b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-05 17:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05  8:18 [PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names Matti Vaittinen
2020-10-05  8:19 ` [PATCH 2/2] regulator: bd9576: Fix print Matti Vaittinen
2020-10-05 17:54 ` [PATCH 1/2] dt_bindings: bd9576: fix regulator binfdings dt node names Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).