* [PATCH V2 2/3] arm64: dts: imx8mn: Correct WDOG_B pin configuration
2020-10-12 12:44 [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration Anson Huang
@ 2020-10-12 12:44 ` Anson Huang
2020-10-12 13:05 ` Krzysztof Kozlowski
2020-10-12 12:44 ` [PATCH V2 3/3] arm64: dts: imx8mp-evk: " Anson Huang
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Anson Huang @ 2020-10-12 12:44 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, krzk, aford173,
daniel.baluta, shengjiu.wang, peter.chen, alifer.wsdm, abel.vesa,
yibin.gong, jun.li, l.stach, devicetree, linux-arm-kernel,
linux-kernel
Cc: Linux-imx
Different revision of i.MX8MN EVK boards may have different external
pull up registor design, some are enabled while some are NOT, to make
sure the WDOG_B pin works properly, better to enable internal pull up
resistor. Since enabling internal pull up resistor is NOT harmful and
having benefit of flexibility on different board design, just enable
it for all i.MX8MN boards; And schmitt input is NOT necessary for this
WDOG_B output pin, so remove it; Open drain outputs provide more
flexibility to a designer as they can be pulled-up to any voltage found
in the system, so enable it as well.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
Changes since V1:
- Provide more explanation of removing schmitt input and enabling open drain in commit msg.
---
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
index 4aa0dbd..fda8905 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
@@ -340,7 +340,7 @@
pinctrl_wdog: wdoggrp {
fsl,pins = <
- MX8MN_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0xc6
+ MX8MN_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
>;
};
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
index a2d0190..dde01da 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
@@ -545,7 +545,7 @@
pinctrl_wdog: wdoggrp {
fsl,pins = <
- MX8MN_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0xc6
+ MX8MN_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V2 2/3] arm64: dts: imx8mn: Correct WDOG_B pin configuration
2020-10-12 12:44 ` [PATCH V2 2/3] arm64: dts: imx8mn: " Anson Huang
@ 2020-10-12 13:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-12 13:05 UTC (permalink / raw)
To: Anson Huang
Cc: robh+dt, shawnguo, s.hauer, kernel, festevam, aford173,
daniel.baluta, shengjiu.wang, peter.chen, alifer.wsdm, abel.vesa,
yibin.gong, jun.li, l.stach, devicetree, linux-arm-kernel,
linux-kernel, Linux-imx
On Mon, Oct 12, 2020 at 08:44:01PM +0800, Anson Huang wrote:
> Different revision of i.MX8MN EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MN boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - Provide more explanation of removing schmitt input and enabling open drain in commit msg.
> ---
> arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH V2 3/3] arm64: dts: imx8mp-evk: Correct WDOG_B pin configuration
2020-10-12 12:44 [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration Anson Huang
2020-10-12 12:44 ` [PATCH V2 2/3] arm64: dts: imx8mn: " Anson Huang
@ 2020-10-12 12:44 ` Anson Huang
2020-10-12 13:05 ` Krzysztof Kozlowski
2020-10-12 13:04 ` [PATCH V2 1/3] arm64: dts: imx8mm: " Krzysztof Kozlowski
2020-10-30 10:34 ` Shawn Guo
3 siblings, 1 reply; 7+ messages in thread
From: Anson Huang @ 2020-10-12 12:44 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, kernel, festevam, krzk, aford173,
daniel.baluta, shengjiu.wang, peter.chen, alifer.wsdm, abel.vesa,
yibin.gong, jun.li, l.stach, devicetree, linux-arm-kernel,
linux-kernel
Cc: Linux-imx
Different revision of i.MX8MP EVK boards may have different external
pull up registor design, some are enabled while some are NOT, to make
sure the WDOG_B pin works properly, better to enable internal pull up
resistor. Since enabling internal pull up resistor is NOT harmful and
having benefit of flexibility on different board design, just enable
it for all i.MX8MP boards; And schmitt input is NOT necessary for this
WDOG_B output pin, so remove it; Open drain outputs provide more
flexibility to a designer as they can be pulled-up to any voltage found
in the system, so enable it as well.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
Changes since V1:
- Provide more explanation of removing schmitt input and enabling open drain in commit msg.
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index ad66f12..908b92b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -262,7 +262,7 @@
pinctrl_wdog: wdoggrp {
fsl,pins = <
- MX8MP_IOMUXC_GPIO1_IO02__WDOG1_WDOG_B 0xc6
+ MX8MP_IOMUXC_GPIO1_IO02__WDOG1_WDOG_B 0x166
>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V2 3/3] arm64: dts: imx8mp-evk: Correct WDOG_B pin configuration
2020-10-12 12:44 ` [PATCH V2 3/3] arm64: dts: imx8mp-evk: " Anson Huang
@ 2020-10-12 13:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-12 13:05 UTC (permalink / raw)
To: Anson Huang
Cc: robh+dt, shawnguo, s.hauer, kernel, festevam, aford173,
daniel.baluta, shengjiu.wang, peter.chen, alifer.wsdm, abel.vesa,
yibin.gong, jun.li, l.stach, devicetree, linux-arm-kernel,
linux-kernel, Linux-imx
On Mon, Oct 12, 2020 at 08:44:02PM +0800, Anson Huang wrote:
> Different revision of i.MX8MP EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MP boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - Provide more explanation of removing schmitt input and enabling open drain in commit msg.
> ---
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration
2020-10-12 12:44 [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration Anson Huang
2020-10-12 12:44 ` [PATCH V2 2/3] arm64: dts: imx8mn: " Anson Huang
2020-10-12 12:44 ` [PATCH V2 3/3] arm64: dts: imx8mp-evk: " Anson Huang
@ 2020-10-12 13:04 ` Krzysztof Kozlowski
2020-10-30 10:34 ` Shawn Guo
3 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-12 13:04 UTC (permalink / raw)
To: Anson Huang
Cc: robh+dt, shawnguo, s.hauer, kernel, festevam, aford173,
daniel.baluta, shengjiu.wang, peter.chen, alifer.wsdm, abel.vesa,
yibin.gong, jun.li, l.stach, devicetree, linux-arm-kernel,
linux-kernel, Linux-imx
On Mon, Oct 12, 2020 at 08:44:00PM +0800, Anson Huang wrote:
> Different revision of i.MX8MM EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MM boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - Provide more explanation of removing schmitt input and enabling open drain in commit msg.
> ---
> arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration
2020-10-12 12:44 [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration Anson Huang
` (2 preceding siblings ...)
2020-10-12 13:04 ` [PATCH V2 1/3] arm64: dts: imx8mm: " Krzysztof Kozlowski
@ 2020-10-30 10:34 ` Shawn Guo
3 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2020-10-30 10:34 UTC (permalink / raw)
To: Anson Huang
Cc: robh+dt, s.hauer, kernel, festevam, krzk, aford173,
daniel.baluta, shengjiu.wang, peter.chen, alifer.wsdm, abel.vesa,
yibin.gong, jun.li, l.stach, devicetree, linux-arm-kernel,
linux-kernel, Linux-imx
On Mon, Oct 12, 2020 at 08:44:00PM +0800, Anson Huang wrote:
> Different revision of i.MX8MM EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MM boards; And schmitt input is NOT necessary for this
> WDOG_B output pin, so remove it; Open drain outputs provide more
> flexibility to a designer as they can be pulled-up to any voltage found
> in the system, so enable it as well.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Applied all, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread