* [PATCH] mmc: mediatek: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-10-19 0:43 Tian Tao
2020-10-29 12:08 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-10-19 0:43 UTC (permalink / raw)
To: haotian.jing, ulf.hansson, matthias.bgg, p.zabel, linux-mmc,
linux-arm-kernel, linux-mediatek, linux-kernel
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/mmc/host/mtk-sd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index a704745..fb3e419 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1536,13 +1536,12 @@ static irqreturn_t msdc_irq(int irq, void *dev_id)
struct mmc_host *mmc = mmc_from_priv(host);
while (true) {
- unsigned long flags;
struct mmc_request *mrq;
struct mmc_command *cmd;
struct mmc_data *data;
u32 events, event_mask;
- spin_lock_irqsave(&host->lock, flags);
+ spin_lock(&host->lock);
events = readl(host->base + MSDC_INT);
event_mask = readl(host->base + MSDC_INTEN);
if ((events & event_mask) & MSDC_INT_SDIOIRQ)
@@ -1553,7 +1552,7 @@ static irqreturn_t msdc_irq(int irq, void *dev_id)
mrq = host->mrq;
cmd = host->cmd;
data = host->data;
- spin_unlock_irqrestore(&host->lock, flags);
+ spin_unlock(&host->lock);
if ((events & event_mask) & MSDC_INT_SDIOIRQ)
sdio_signal_irq(mmc);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: mediatek: replace spin_lock_irqsave by spin_lock in hard IRQ
2020-10-19 0:43 [PATCH] mmc: mediatek: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
@ 2020-10-29 12:08 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2020-10-29 12:08 UTC (permalink / raw)
To: Tian Tao
Cc: haotian.jing, Matthias Brugger, Philipp Zabel, linux-mmc,
Linux ARM, moderated list:ARM/Mediatek SoC support,
Linux Kernel Mailing List
On Mon, 19 Oct 2020 at 02:42, Tian Tao <tiantao6@hisilicon.com> wrote:
>
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index a704745..fb3e419 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1536,13 +1536,12 @@ static irqreturn_t msdc_irq(int irq, void *dev_id)
> struct mmc_host *mmc = mmc_from_priv(host);
>
> while (true) {
> - unsigned long flags;
> struct mmc_request *mrq;
> struct mmc_command *cmd;
> struct mmc_data *data;
> u32 events, event_mask;
>
> - spin_lock_irqsave(&host->lock, flags);
> + spin_lock(&host->lock);
> events = readl(host->base + MSDC_INT);
> event_mask = readl(host->base + MSDC_INTEN);
> if ((events & event_mask) & MSDC_INT_SDIOIRQ)
> @@ -1553,7 +1552,7 @@ static irqreturn_t msdc_irq(int irq, void *dev_id)
> mrq = host->mrq;
> cmd = host->cmd;
> data = host->data;
> - spin_unlock_irqrestore(&host->lock, flags);
> + spin_unlock(&host->lock);
>
> if ((events & event_mask) & MSDC_INT_SDIOIRQ)
> sdio_signal_irq(mmc);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 0:43 [PATCH] mmc: mediatek: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2020-10-29 12:08 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).