* [PATCH] xfs: Drop useless comments
@ 2020-11-02 0:03 Fengfei Xi
2020-11-03 18:50 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Fengfei Xi @ 2020-11-02 0:03 UTC (permalink / raw)
To: darrick.wong; +Cc: linux-xfs, linux-kernel, Fengfei Xi
The names of functions xfs_buf_get_maps and _xfs_buf_free_pages
can fully express their roles. So their comments are redundant.
We could drop them entirely.
Signed-off-by: Fengfei Xi <fengfei_xi@126.com>
---
fs/xfs/xfs_buf.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index 4e4cf91..2aeed30 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -197,9 +197,6 @@
return 0;
}
-/*
- * Frees b_pages if it was allocated.
- */
static void
xfs_buf_free_maps(
struct xfs_buf *bp)
@@ -297,9 +294,6 @@
return 0;
}
-/*
- * Frees b_pages if it was allocated.
- */
STATIC void
_xfs_buf_free_pages(
xfs_buf_t *bp)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: Drop useless comments
2020-11-02 0:03 [PATCH] xfs: Drop useless comments Fengfei Xi
@ 2020-11-03 18:50 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-11-03 18:50 UTC (permalink / raw)
To: Fengfei Xi; +Cc: linux-xfs, linux-kernel
On Mon, Nov 02, 2020 at 08:03:16AM +0800, Fengfei Xi wrote:
> The names of functions xfs_buf_get_maps and _xfs_buf_free_pages
xfs_buf_get_maps? I don't see any changes for that function...?
--D
> can fully express their roles. So their comments are redundant.
> We could drop them entirely.
>
> Signed-off-by: Fengfei Xi <fengfei_xi@126.com>
> ---
> fs/xfs/xfs_buf.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 4e4cf91..2aeed30 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -197,9 +197,6 @@
> return 0;
> }
>
> -/*
> - * Frees b_pages if it was allocated.
> - */
> static void
> xfs_buf_free_maps(
> struct xfs_buf *bp)
> @@ -297,9 +294,6 @@
> return 0;
> }
>
> -/*
> - * Frees b_pages if it was allocated.
> - */
> STATIC void
> _xfs_buf_free_pages(
> xfs_buf_t *bp)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-03 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 0:03 [PATCH] xfs: Drop useless comments Fengfei Xi
2020-11-03 18:50 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).