From: Stephen Boyd <sboyd@kernel.org>
To: abel.vesa@nxp.com, festevam@gmail.com, peng.fan@nxp.com,
s.hauer@pengutronix.de, shawnguo@kernel.org
Cc: kernel@pengutronix.de, linux-imx@nxp.com, Anson.Huang@nxp.com,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration
Date: Wed, 04 Nov 2020 17:13:15 -0800 [thread overview]
Message-ID: <160453879574.3965362.14789600439446175918@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1604229834-25594-1-git-send-email-peng.fan@nxp.com>
Quoting peng.fan@nxp.com (2020-11-01 03:23:54)
> From: Peng Fan <peng.fan@nxp.com>
>
> noc/axi/ahb are bus clk, not peripheral clk.
> Since peripheral clk has a limitation that for peripheral clock slice,
> IP clock slices must be stopped to change the clock source.
>
> However if the bus clk is marked as critical clk peripheral, the
> assigned clock parent operation will fail.
>
> So we added CLK_SET_PARENT_GATE flag to avoid glitch.
>
> And add imx8m_clk_hw_composite_bus_critical for bus critical clock usage
>
> Fixes: 936c383673b9e ("clk: imx: fix composite peripheral flags")
> Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> Reported-by: Abel Vesa <abel.vesa@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2020-11-05 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 11:23 [PATCH V3] clk: imx8m: fix bus critical clk registration peng.fan
2020-11-03 0:06 ` Shawn Guo
2020-11-03 1:03 ` Peng Fan
2020-11-03 10:59 ` Shawn Guo
2020-11-05 1:13 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160453879574.3965362.14789600439446175918@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).