From: Shawn Guo <shawnguo@kernel.org>
To: Peng Fan <peng.fan@nxp.com>, Stephen Boyd <sboyd@kernel.org>
Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
Abel Vesa <abel.vesa@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
Anson Huang <anson.huang@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Aisheng Dong <aisheng.dong@nxp.com>
Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration
Date: Tue, 3 Nov 2020 18:59:25 +0800 [thread overview]
Message-ID: <20201103105924.GD31601@dragon> (raw)
In-Reply-To: <DB6PR0402MB2760920568B1FC6A9F993EFB88110@DB6PR0402MB2760.eurprd04.prod.outlook.com>
On Tue, Nov 03, 2020 at 01:03:44AM +0000, Peng Fan wrote:
> Shawn,
>
> > Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration
> >
> > On Sun, Nov 01, 2020 at 07:23:54PM +0800, peng.fan@nxp.com wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > noc/axi/ahb are bus clk, not peripheral clk.
> > > Since peripheral clk has a limitation that for peripheral clock slice,
> > > IP clock slices must be stopped to change the clock source.
> > >
> > > However if the bus clk is marked as critical clk peripheral, the
> > > assigned clock parent operation will fail.
> > >
> > > So we added CLK_SET_PARENT_GATE flag to avoid glitch.
> > >
> > > And add imx8m_clk_hw_composite_bus_critical for bus critical clock
> > > usage
> > >
> > > Fixes: 936c383673b9e ("clk: imx: fix composite peripheral flags")
> > > Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> > > Reported-by: Abel Vesa <abel.vesa@nxp.com>
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >
> > Do you want this be picked up as a fix for 5.10-rc or non-critical stuff for
> > -next?
>
> Please take this as a fix for 5.10-rc.
Okay, I will leave this to Stephen then.
Shawn
next prev parent reply other threads:[~2020-11-03 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 11:23 [PATCH V3] clk: imx8m: fix bus critical clk registration peng.fan
2020-11-03 0:06 ` Shawn Guo
2020-11-03 1:03 ` Peng Fan
2020-11-03 10:59 ` Shawn Guo [this message]
2020-11-05 1:13 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103105924.GD31601@dragon \
--to=shawnguo@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).