linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] clk: imx: scu: Make pd_np with static keyword
@ 2020-11-04 11:19 Zou Wei
  2020-11-05  1:37 ` Stephen Boyd
  2020-11-10  2:17 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-11-04 11:19 UTC (permalink / raw)
  To: mturquette, sboyd, shawnguo, s.hauer, kernel, festevam, linux-imx
  Cc: linux-clk, linux-arm-kernel, linux-kernel, Zou Wei

Fix the following sparse warning:

./clk-scu.c:23:20: warning: symbol 'pd_np' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/clk/imx/clk-scu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
index d0243c5..d10f60e 100644
--- a/drivers/clk/imx/clk-scu.c
+++ b/drivers/clk/imx/clk-scu.c
@@ -20,7 +20,7 @@
 #define IMX_SIP_SET_CPUFREQ		0x00
 
 static struct imx_sc_ipc *ccm_ipc_handle;
-struct device_node *pd_np;
+static struct device_node *pd_np;
 static struct platform_driver imx_clk_scu_driver;
 
 struct imx_scu_clk_node {
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] clk: imx: scu: Make pd_np with static keyword
  2020-11-04 11:19 [PATCH -next] clk: imx: scu: Make pd_np with static keyword Zou Wei
@ 2020-11-05  1:37 ` Stephen Boyd
  2020-11-10  2:17 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-11-05  1:37 UTC (permalink / raw)
  To: Zou Wei, festevam, kernel, linux-imx, mturquette, s.hauer, shawnguo
  Cc: linux-clk, linux-arm-kernel, linux-kernel, Zou Wei

Quoting Zou Wei (2020-11-04 03:19:31)
> Fix the following sparse warning:
> 
> ./clk-scu.c:23:20: warning: symbol 'pd_np' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] clk: imx: scu: Make pd_np with static keyword
  2020-11-04 11:19 [PATCH -next] clk: imx: scu: Make pd_np with static keyword Zou Wei
  2020-11-05  1:37 ` Stephen Boyd
@ 2020-11-10  2:17 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2020-11-10  2:17 UTC (permalink / raw)
  To: Zou Wei
  Cc: mturquette, sboyd, s.hauer, kernel, festevam, linux-imx,
	linux-clk, linux-arm-kernel, linux-kernel

On Wed, Nov 04, 2020 at 07:19:31PM +0800, Zou Wei wrote:
> Fix the following sparse warning:
> 
> ./clk-scu.c:23:20: warning: symbol 'pd_np' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-10  2:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 11:19 [PATCH -next] clk: imx: scu: Make pd_np with static keyword Zou Wei
2020-11-05  1:37 ` Stephen Boyd
2020-11-10  2:17 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).