* [PATCH v2] mtd: spinand: macronix: Add support for MX35LFxGE4AD
@ 2020-11-05 1:43 YouChing Lin
2020-11-05 6:58 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: YouChing Lin @ 2020-11-05 1:43 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr
Cc: juliensu, linux-mtd, linux-kernel, ycllin
The Macronix MX35LF2GE4AD / MX35LF4GE4AD are 3V, 2G / 4Gbit serial
SLC NAND flash device (with on-die ECC).
Validated by read, erase, read back, write, read back and nandtest
on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host
(drivers/spi/spi-mxic.c).
v2: Removed the unnecessary "/*SPINAND_HAS_QE_BIT*/" as per the comments.
v1: Add support for MX35LFxGE4AD
Signed-off-by: YouChing Lin <ycllin@mxic.com.tw>
---
drivers/mtd/nand/spi/macronix.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
index 8e801e4..3786b1b 100644
--- a/drivers/mtd/nand/spi/macronix.c
+++ b/drivers/mtd/nand/spi/macronix.c
@@ -119,6 +119,26 @@ static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,
&update_cache_variants),
SPINAND_HAS_QE_BIT,
SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)),
+ SPINAND_INFO("MX35LF2GE4AD",
+ SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x26),
+ NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 1, 1, 1),
+ NAND_ECCREQ(8, 512),
+ SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+ &write_cache_variants,
+ &update_cache_variants),
+ 0,
+ SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+ mx35lf1ge4ab_ecc_get_status)),
+ SPINAND_INFO("MX35LF4GE4AD",
+ SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x37),
+ NAND_MEMORG(1, 4096, 128, 64, 2048, 40, 1, 1, 1),
+ NAND_ECCREQ(8, 512),
+ SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+ &write_cache_variants,
+ &update_cache_variants),
+ 0,
+ SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+ mx35lf1ge4ab_ecc_get_status)),
SPINAND_INFO("MX31LF1GE4BC",
SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x1e),
NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mtd: spinand: macronix: Add support for MX35LFxGE4AD
2020-11-05 1:43 [PATCH v2] mtd: spinand: macronix: Add support for MX35LFxGE4AD YouChing Lin
@ 2020-11-05 6:58 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2020-11-05 6:58 UTC (permalink / raw)
To: YouChing Lin; +Cc: richard, vigneshr, juliensu, linux-mtd, linux-kernel
Hi YouChing,
YouChing Lin <ycllin@mxic.com.tw> wrote on Thu, 5 Nov 2020 09:43:13
+0800:
> The Macronix MX35LF2GE4AD / MX35LF4GE4AD are 3V, 2G / 4Gbit serial
> SLC NAND flash device (with on-die ECC).
>
> Validated by read, erase, read back, write, read back and nandtest
> on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host
> (drivers/spi/spi-mxic.c).
>
> v2: Removed the unnecessary "/*SPINAND_HAS_QE_BIT*/" as per the comments.
>
> v1: Add support for MX35LFxGE4AD
You cannot put the changelog here. Everything you write above the three
dashes will be part of the final commit message and we don't want this
to appear.
>
> Signed-off-by: YouChing Lin <ycllin@mxic.com.tw>
> ---
V2: ...
v1: ...
should be located here
> drivers/mtd/nand/spi/macronix.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
> index 8e801e4..3786b1b 100644
> --- a/drivers/mtd/nand/spi/macronix.c
> +++ b/drivers/mtd/nand/spi/macronix.c
> @@ -119,6 +119,26 @@ static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,
> &update_cache_variants),
> SPINAND_HAS_QE_BIT,
> SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)),
> + SPINAND_INFO("MX35LF2GE4AD",
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x26),
> + NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 1, 1, 1),
> + NAND_ECCREQ(8, 512),
> + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> + &write_cache_variants,
> + &update_cache_variants),
> + 0,
> + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
> + mx35lf1ge4ab_ecc_get_status)),
> + SPINAND_INFO("MX35LF4GE4AD",
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x37),
> + NAND_MEMORG(1, 4096, 128, 64, 2048, 40, 1, 1, 1),
> + NAND_ECCREQ(8, 512),
> + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> + &write_cache_variants,
> + &update_cache_variants),
> + 0,
> + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
> + mx35lf1ge4ab_ecc_get_status)),
> SPINAND_INFO("MX31LF1GE4BC",
> SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x1e),
> NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-05 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-05 1:43 [PATCH v2] mtd: spinand: macronix: Add support for MX35LFxGE4AD YouChing Lin
2020-11-05 6:58 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).