[PATCH] fix mach64_gx.c

[PATCH] fix mach64_gx.c

[Paul Mackerras]

The patch below is needed for drivers/video/aty/mach64_gx.c to compile
correctly.  Somehow a couple of the var_to_pll routines got the wrong
argument list.

Paul.

diff -urN linux-2.5/drivers/video/aty/mach64_gx.c pmac-2.5/drivers/video/aty/mach64_gx.c
--- linux-2.5/drivers/video/aty/mach64_gx.c	2003-04-21 10:27:15.000000000 +1000
+++ pmac-2.5/drivers/video/aty/mach64_gx.c	2003-04-23 22:10:54.000000000 +1000
@@ -494,7 +494,7 @@
      */
 
 static int aty_var_to_pll_1703(const struct fb_info *info, u32 vclk_per,
-			       u32 vclk_per, u8 bpp, union aty_pll *pll)
+			       u8 bpp, union aty_pll *pll)
 {
 	u32 mhz100;		/* in 0.01 MHz */
 	u32 program_bits;
@@ -610,7 +610,7 @@
      */
 
 static int aty_var_to_pll_8398(const struct fb_info *info, u32 vclk_per,
-			       u32 vclk_per, u8 bpp, union aty_pll *pll)
+			       u8 bpp, union aty_pll *pll)
 {
 	u32 tempA, tempB, fOut, longMHz100, diff, preDiff;
 

Re: [PATCH] fix mach64_gx.c

[James Simmons]

New fixes for the ATI driver are coming. I have been neglecting the 
drivers to finish core changes which for the most part have been done.

P.S
   Has anyone tested this chipset on a PPC 64?

Re: [PATCH] fix mach64_gx.c

[Ben Collins]

On Fri, May 02, 2003 at 09:07:32PM +0100, James Simmons wrote:
> 
> New fixes for the ATI driver are coming. I have been neglecting the 
> drivers to finish core changes which for the most part have been done.
> 
> P.S
>    Has anyone tested this chipset on a PPC 64?

FYI, James. This fix is something I already pushed to Dave, so Linus
will get it already.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo       - http://www.deqo.com/

Re: [PATCH] fix mach64_gx.c

[Paul Mackerras]

James Simmons writes:

>    Has anyone tested this chipset on a PPC 64?

There aren't any PPC64 boxes with this chipset (ATI Mach64 GX), since
all past and current PPC64 boxes are IBM servers.  I suppose one could
find an old ATI Mach64 PCI card and put it in a PPC64 box, but I don't
know why you would do that instead of putting in a PCI radeon or
something. :)

Regards,
Paul.

Re: [PATCH] fix mach64_gx.c

[James Simmons]

> >    Has anyone tested this chipset on a PPC 64?
> 
> There aren't any PPC64 boxes with this chipset (ATI Mach64 GX), since
> all past and current PPC64 boxes are IBM servers.  I suppose one could
> find an old ATI Mach64 PCI card and put it in a PPC64 box, but I don't
> know why you would do that instead of putting in a PCI radeon or
> something. :)

Because it is fun :-)