* [PATCH] scsi: bnx2fc: remove unneeded semicolon
@ 2020-11-01 14:38 trix
2020-11-02 4:44 ` [EXT] " Saurav Kashyap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: trix @ 2020-11-01 14:38 UTC (permalink / raw)
To: skashyap, jhasan, jejb, martin.petersen
Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A semicolon is not needed after a switch statement.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 6890bbe04a8c..a436adb6092d 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -2275,7 +2275,7 @@ static int bnx2fc_ctlr_enabled(struct fcoe_ctlr_device *cdev)
case FCOE_CTLR_UNUSED:
default:
return -ENOTSUPP;
- };
+ }
}
enum bnx2fc_create_link_state {
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon
2020-11-01 14:38 [PATCH] scsi: bnx2fc: remove unneeded semicolon trix
@ 2020-11-02 4:44 ` Saurav Kashyap
2020-11-05 3:04 ` Martin K. Petersen
2020-11-11 2:58 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Saurav Kashyap @ 2020-11-02 4:44 UTC (permalink / raw)
To: trix, Javed Hasan, jejb, martin.petersen
Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel
Hi Tom,
> -----Original Message-----
> From: trix@redhat.com <trix@redhat.com>
> Sent: Sunday, November 1, 2020 8:08 PM
> To: Saurav Kashyap <skashyap@marvell.com>; Javed Hasan
> <jhasan@marvell.com>; jejb@linux.ibm.com; martin.petersen@oracle.com
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; Tom Rix <trix@redhat.com>
> Subject: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon
>
> External Email
>
> ----------------------------------------------------------------------
> From: Tom Rix <trix@redhat.com>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 6890bbe04a8c..a436adb6092d 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2275,7 +2275,7 @@ static int bnx2fc_ctlr_enabled(struct
> fcoe_ctlr_device *cdev)
> case FCOE_CTLR_UNUSED:
> default:
> return -ENOTSUPP;
> - };
> + }
> }
Thanks for a patch.
Reviewed-by: Saurav Kashyap <skashyap@marvell.com>
Thanks,
~Saurav
>
> enum bnx2fc_create_link_state {
> --
> 2.18.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: bnx2fc: remove unneeded semicolon
2020-11-01 14:38 [PATCH] scsi: bnx2fc: remove unneeded semicolon trix
2020-11-02 4:44 ` [EXT] " Saurav Kashyap
@ 2020-11-05 3:04 ` Martin K. Petersen
2020-11-11 2:58 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-11-05 3:04 UTC (permalink / raw)
To: trix
Cc: skashyap, jhasan, jejb, martin.petersen,
GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel
Tom,
> A semicolon is not needed after a switch statement.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: bnx2fc: remove unneeded semicolon
2020-11-01 14:38 [PATCH] scsi: bnx2fc: remove unneeded semicolon trix
2020-11-02 4:44 ` [EXT] " Saurav Kashyap
2020-11-05 3:04 ` Martin K. Petersen
@ 2020-11-11 2:58 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-11-11 2:58 UTC (permalink / raw)
To: trix, skashyap, jejb, jhasan
Cc: Martin K . Petersen, linux-kernel, linux-scsi,
GR-QLogic-Storage-Upstream
On Sun, 1 Nov 2020 06:38:12 -0800, trix@redhat.com wrote:
> A semicolon is not needed after a switch statement.
Applied to 5.11/scsi-queue, thanks!
[1/1] scsi: bnx2fc: Remove unneeded semicolon
https://git.kernel.org/mkp/scsi/c/4a9435b7b04e
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-11 2:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 14:38 [PATCH] scsi: bnx2fc: remove unneeded semicolon trix
2020-11-02 4:44 ` [EXT] " Saurav Kashyap
2020-11-05 3:04 ` Martin K. Petersen
2020-11-11 2:58 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).