* [PATCH v2] tracing: remove the useless value assignment in test_create_synth_event
@ 2020-11-13 16:02 xiakaixu1987
0 siblings, 0 replies; 3+ messages in thread
From: xiakaixu1987 @ 2020-11-13 16:02 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The value of variable ret is overwritten on the delete branch in the
test_create_synth_event() and we care more about the above error than
this delete portion. Remove it.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
v2:
-remove the useless assignment in the delete portion.
kernel/trace/synth_event_gen_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/synth_event_gen_test.c b/kernel/trace/synth_event_gen_test.c
index edd912cd14aa..a4b4bbf8c3bf 100644
--- a/kernel/trace/synth_event_gen_test.c
+++ b/kernel/trace/synth_event_gen_test.c
@@ -307,7 +307,7 @@ static int __init test_create_synth_event(void)
return ret;
delete:
/* We got an error after creating the event, delete it */
- ret = synth_event_delete("create_synth_test");
+ synth_event_delete("create_synth_test");
goto out;
}
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tracing: remove the useless value assignment in test_create_synth_event
2020-11-13 15:21 xiakaixu1987
@ 2020-11-13 15:28 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-11-13 15:28 UTC (permalink / raw)
To: xiakaixu1987; +Cc: arnd, linux-kernel, Kaixu Xia
On Fri, Nov 13, 2020 at 11:21:18PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The value of variable ret is overwritten on the delete branch in the
> test_create_synth_event() and we care more about the above error than
> this delete portion. Remove it.
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> kernel/trace/synth_event_gen_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
$ ./scripts/get_maintainer.pl kernel/trace/synth_event_gen_test.c
Steven Rostedt <rostedt@goodmis.org> (maintainer:TRACING)
Ingo Molnar <mingo@redhat.com> (maintainer:TRACING)
linux-kernel@vger.kernel.org (open list)
You have an odd selection of people you copied on this patch, ensuring
thtat the correct people would not see it :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] tracing: remove the useless value assignment in test_create_synth_event
@ 2020-11-13 15:21 xiakaixu1987
2020-11-13 15:28 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: xiakaixu1987 @ 2020-11-13 15:21 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The value of variable ret is overwritten on the delete branch in the
test_create_synth_event() and we care more about the above error than
this delete portion. Remove it.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
kernel/trace/synth_event_gen_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/synth_event_gen_test.c b/kernel/trace/synth_event_gen_test.c
index edd912cd14aa..a4b4bbf8c3bf 100644
--- a/kernel/trace/synth_event_gen_test.c
+++ b/kernel/trace/synth_event_gen_test.c
@@ -307,7 +307,7 @@ static int __init test_create_synth_event(void)
return ret;
delete:
/* We got an error after creating the event, delete it */
- ret = synth_event_delete("create_synth_test");
+ synth_event_delete("create_synth_test");
goto out;
}
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-13 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 16:02 [PATCH v2] tracing: remove the useless value assignment in test_create_synth_event xiakaixu1987
-- strict thread matches above, loose matches on Subject: below --
2020-11-13 15:21 xiakaixu1987
2020-11-13 15:28 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).