* [PATCH] rtc: da9063: Simplify bool comparison
@ 2020-11-06 8:00 xiakaixu1987
2020-11-14 22:31 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: xiakaixu1987 @ 2020-11-06 8:00 UTC (permalink / raw)
To: a.zummo, alexandre.belloni; +Cc: linux-rtc, linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
Fix the following coccicheck warning:
./drivers/rtc/rtc-da9063.c:246:5-18: WARNING: Comparison to bool
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
drivers/rtc/rtc-da9063.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
index 046b1d4c3dae..6f0a3a711135 100644
--- a/drivers/rtc/rtc-da9063.c
+++ b/drivers/rtc/rtc-da9063.c
@@ -243,7 +243,7 @@ static int da9063_rtc_read_time(struct device *dev, struct rtc_time *tm)
al_secs = rtc_tm_to_time64(&rtc->alarm_time);
/* handle the rtc synchronisation delay */
- if (rtc->rtc_sync == true && al_secs - tm_secs == 1)
+ if (rtc->rtc_sync && al_secs - tm_secs == 1)
memcpy(tm, &rtc->alarm_time, sizeof(struct rtc_time));
else
rtc->rtc_sync = false;
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: da9063: Simplify bool comparison
2020-11-06 8:00 [PATCH] rtc: da9063: Simplify bool comparison xiakaixu1987
@ 2020-11-14 22:31 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-11-14 22:31 UTC (permalink / raw)
To: a.zummo, xiakaixu1987
Cc: Alexandre Belloni, Kaixu Xia, linux-kernel, linux-rtc
On Fri, 6 Nov 2020 16:00:37 +0800, xiakaixu1987@gmail.com wrote:
> Fix the following coccicheck warning:
>
> ./drivers/rtc/rtc-da9063.c:246:5-18: WARNING: Comparison to bool
Applied, thanks!
[1/1] rtc: da9063: Simplify bool comparison
commit: a48c6224ae07bed02893c58073ca2942acb5c3d5
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-14 22:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 8:00 [PATCH] rtc: da9063: Simplify bool comparison xiakaixu1987
2020-11-14 22:31 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).