* [PATCH] rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler
@ 2020-11-10 9:35 Tian Tao
2020-11-14 22:39 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-11-10 9:35 UTC (permalink / raw)
To: a.zummo, alexandre.belloni, linux-rtc, linux-kernel
Coccinelle noticed:
drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/rtc/rtc-cpcap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
index 800667d..38d576b 100644
--- a/drivers/rtc/rtc-cpcap.c
+++ b/drivers/rtc/rtc-cpcap.c
@@ -269,7 +269,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
rtc->alarm_irq = platform_get_irq(pdev, 0);
err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
- cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
+ cpcap_rtc_alarm_irq,
+ IRQF_TRIGGER_NONE | IRQF_ONESHOT,
"rtc_alarm", rtc);
if (err) {
dev_err(dev, "Could not request alarm irq: %d\n", err);
@@ -285,7 +286,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
*/
rtc->update_irq = platform_get_irq(pdev, 1);
err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
- cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
+ cpcap_rtc_update_irq,
+ IRQF_TRIGGER_NONE | IRQF_ONESHOT,
"rtc_1hz", rtc);
if (err) {
dev_err(dev, "Could not request update irq: %d\n", err);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler
2020-11-10 9:35 [PATCH] rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler Tian Tao
@ 2020-11-14 22:39 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-11-14 22:39 UTC (permalink / raw)
To: linux-kernel, Tian Tao, a.zummo, linux-rtc; +Cc: Alexandre Belloni
On Tue, 10 Nov 2020 17:35:47 +0800, Tian Tao wrote:
> Coccinelle noticed:
> drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT
> drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT
Applied, thanks!
[1/1] rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler
commit: bc06cfc1c41e3b60b159132e5bba4c059a2e7f83
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-14 22:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 9:35 [PATCH] rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler Tian Tao
2020-11-14 22:39 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).