* [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword
@ 2020-11-14 7:37 Zou Wei
2020-11-17 4:38 ` Martin K. Petersen
2020-11-20 3:31 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-11-14 7:37 UTC (permalink / raw)
To: subbu.seetharaman, ketan.mukadam, jitendra.bhivare, jejb,
martin.petersen
Cc: linux-scsi, linux-kernel, Zou Wei
Fix the following sparse warning:
./be_main.c:167:25: warning: symbol 'beiscsi_attrs' was not declared. Should it be static?
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 202ba92..50e4642 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -164,7 +164,7 @@ DEVICE_ATTR(beiscsi_active_session_count, S_IRUGO,
beiscsi_active_session_disp, NULL);
DEVICE_ATTR(beiscsi_free_session_count, S_IRUGO,
beiscsi_free_session_disp, NULL);
-struct device_attribute *beiscsi_attrs[] = {
+static struct device_attribute *beiscsi_attrs[] = {
&dev_attr_beiscsi_log_enable,
&dev_attr_beiscsi_drvr_ver,
&dev_attr_beiscsi_adapter_family,
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword
2020-11-14 7:37 [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword Zou Wei
@ 2020-11-17 4:38 ` Martin K. Petersen
2020-11-20 3:31 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-11-17 4:38 UTC (permalink / raw)
To: Zou Wei
Cc: subbu.seetharaman, ketan.mukadam, jitendra.bhivare, jejb,
martin.petersen, linux-scsi, linux-kernel
Zou,
> Fix the following sparse warning:
>
> ./be_main.c:167:25: warning: symbol 'beiscsi_attrs' was not declared. Should it be static?
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword
2020-11-14 7:37 [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword Zou Wei
2020-11-17 4:38 ` Martin K. Petersen
@ 2020-11-20 3:31 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-11-20 3:31 UTC (permalink / raw)
To: jejb, Zou Wei, subbu.seetharaman, ketan.mukadam, jitendra.bhivare
Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Sat, 14 Nov 2020 15:37:54 +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> ./be_main.c:167:25: warning: symbol 'beiscsi_attrs' was not declared. Should it be static?
Applied to 5.11/scsi-queue, thanks!
[1/1] scsi: be2iscsi: Mark beiscsi_attrs with static keyword
https://git.kernel.org/mkp/scsi/c/4ab2990a5ce1
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-20 3:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-14 7:37 [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword Zou Wei
2020-11-17 4:38 ` Martin K. Petersen
2020-11-20 3:31 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).