linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: meson: ship only the necessary clock controllers
@ 2020-10-20  7:50 Jerome Brunet
  2020-10-20 13:13 ` Neil Armstrong
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Jerome Brunet @ 2020-10-20  7:50 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Jerome Brunet, Kevin Hilman, linux-amlogic, linux-kernel,
	linux-arm-kernel

There now the menu entries for the amlogic clock controllers.
Do not select these when ARM64 is enabled so it possible to ship only the
required.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 arch/arm64/Kconfig.platforms | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index cd58f8495c45..b22d1bdd6eb6 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -154,9 +154,6 @@ config ARCH_MESON
 	bool "Amlogic Platforms"
 	select PINCTRL
 	select PINCTRL_MESON
-	select COMMON_CLK_GXBB
-	select COMMON_CLK_AXG
-	select COMMON_CLK_G12A
 	select MESON_IRQ_GPIO
 	help
 	  This enables support for the arm64 based Amlogic SoCs
-- 
2.25.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: meson: ship only the necessary clock controllers
  2020-10-20  7:50 [PATCH] arm64: meson: ship only the necessary clock controllers Jerome Brunet
@ 2020-10-20 13:13 ` Neil Armstrong
  2020-10-20 15:03 ` Kevin Hilman
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2020-10-20 13:13 UTC (permalink / raw)
  To: Jerome Brunet, Catalin Marinas, Will Deacon
  Cc: Kevin Hilman, linux-amlogic, linux-kernel, linux-arm-kernel

On 20/10/2020 09:50, Jerome Brunet wrote:
> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.
> 
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  arch/arm64/Kconfig.platforms | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index cd58f8495c45..b22d1bdd6eb6 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -154,9 +154,6 @@ config ARCH_MESON
>  	bool "Amlogic Platforms"
>  	select PINCTRL
>  	select PINCTRL_MESON
> -	select COMMON_CLK_GXBB
> -	select COMMON_CLK_AXG
> -	select COMMON_CLK_G12A
>  	select MESON_IRQ_GPIO
>  	help
>  	  This enables support for the arm64 based Amlogic SoCs
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: meson: ship only the necessary clock controllers
  2020-10-20  7:50 [PATCH] arm64: meson: ship only the necessary clock controllers Jerome Brunet
  2020-10-20 13:13 ` Neil Armstrong
@ 2020-10-20 15:03 ` Kevin Hilman
  2020-10-20 15:28   ` Jerome Brunet
  2020-11-09 23:23 ` Kevin Hilman
  2020-11-20 19:12 ` Kevin Hilman
  3 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2020-10-20 15:03 UTC (permalink / raw)
  To: Jerome Brunet, Catalin Marinas, Will Deacon
  Cc: Jerome Brunet, linux-amlogic, linux-kernel, linux-arm-kernel

Jerome Brunet <jbrunet@baylibre.com> writes:

> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  arch/arm64/Kconfig.platforms | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index cd58f8495c45..b22d1bdd6eb6 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -154,9 +154,6 @@ config ARCH_MESON
>  	bool "Amlogic Platforms"
>  	select PINCTRL
>  	select PINCTRL_MESON
> -	select COMMON_CLK_GXBB
> -	select COMMON_CLK_AXG
> -	select COMMON_CLK_G12A

This patch alone will break boot when using the default, upstream
defconfig because these options will all now be disabled and we'll have
no clock providers.

I think you also need a default value (e.g. `default y`) in
drivers/clk/meson/Kconfig for each of these entries to keep the same
defaults.   But these defaults could be overridden by SoC-specific
defconfigs leading to more flexibilty.

So, assuming you queue up a drivers/clk patch to go in when this
lands...

Acked-by: Kevin Hilman <khilman@baylibre.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: meson: ship only the necessary clock controllers
  2020-10-20 15:03 ` Kevin Hilman
@ 2020-10-20 15:28   ` Jerome Brunet
  0 siblings, 0 replies; 6+ messages in thread
From: Jerome Brunet @ 2020-10-20 15:28 UTC (permalink / raw)
  To: Kevin Hilman, Catalin Marinas, Will Deacon
  Cc: linux-amlogic, linux-kernel, linux-arm-kernel


On Tue 20 Oct 2020 at 17:03, Kevin Hilman <khilman@baylibre.com> wrote:

> Jerome Brunet <jbrunet@baylibre.com> writes:
>
>> There now the menu entries for the amlogic clock controllers.
>> Do not select these when ARM64 is enabled so it possible to ship only the
>> required.
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> ---
>>  arch/arm64/Kconfig.platforms | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index cd58f8495c45..b22d1bdd6eb6 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -154,9 +154,6 @@ config ARCH_MESON
>>  	bool "Amlogic Platforms"
>>  	select PINCTRL
>>  	select PINCTRL_MESON
>> -	select COMMON_CLK_GXBB
>> -	select COMMON_CLK_AXG
>> -	select COMMON_CLK_G12A
>
> This patch alone will break boot when using the default, upstream
> defconfig because these options will all now be disabled and we'll have
> no clock providers.
>
> I think you also need a default value (e.g. `default y`) in
> drivers/clk/meson/Kconfig for each of these entries to keep the same
> defaults.   But these defaults could be overridden by SoC-specific
> defconfigs leading to more flexibilty.
>
> So, assuming you queue up a drivers/clk patch to go in when this
> lands...

Indeed.
Please wait till the clock PR lands during the merge window, you'll see
that it is already taken care of.

I was not expecting you to look at it so soon ;)

>
> Acked-by: Kevin Hilman <khilman@baylibre.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: meson: ship only the necessary clock controllers
  2020-10-20  7:50 [PATCH] arm64: meson: ship only the necessary clock controllers Jerome Brunet
  2020-10-20 13:13 ` Neil Armstrong
  2020-10-20 15:03 ` Kevin Hilman
@ 2020-11-09 23:23 ` Kevin Hilman
  2020-11-20 19:12 ` Kevin Hilman
  3 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2020-11-09 23:23 UTC (permalink / raw)
  To: Catalin Marinas, Jerome Brunet, Will Deacon
  Cc: linux-kernel, linux-amlogic, linux-arm-kernel

On Tue, 20 Oct 2020 09:50:34 +0200, Jerome Brunet wrote:
> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.

Applied, thanks!

[1/1] arm64: meson: ship only the necessary clock controllers
      (no commit info)

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: meson: ship only the necessary clock controllers
  2020-10-20  7:50 [PATCH] arm64: meson: ship only the necessary clock controllers Jerome Brunet
                   ` (2 preceding siblings ...)
  2020-11-09 23:23 ` Kevin Hilman
@ 2020-11-20 19:12 ` Kevin Hilman
  3 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2020-11-20 19:12 UTC (permalink / raw)
  To: Will Deacon, Jerome Brunet, Catalin Marinas
  Cc: linux-arm-kernel, linux-amlogic, linux-kernel

On Tue, 20 Oct 2020 09:50:34 +0200, Jerome Brunet wrote:
> There now the menu entries for the amlogic clock controllers.
> Do not select these when ARM64 is enabled so it possible to ship only the
> required.

Applied, thanks!

[1/1] arm64: meson: ship only the necessary clock controllers
      (no commit info)

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-11-20 19:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20  7:50 [PATCH] arm64: meson: ship only the necessary clock controllers Jerome Brunet
2020-10-20 13:13 ` Neil Armstrong
2020-10-20 15:03 ` Kevin Hilman
2020-10-20 15:28   ` Jerome Brunet
2020-11-09 23:23 ` Kevin Hilman
2020-11-20 19:12 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).