linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: mmp-sspa: set phase two word length register
@ 2020-11-19  3:41 Kyle Russell
  2020-11-20 21:29 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Kyle Russell @ 2020-11-19  3:41 UTC (permalink / raw)
  To: broonie
  Cc: lkundrak, Kyle Russell, Daniel Mack, Haojian Zhuang,
	Robert Jarzmik, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	linux-arm-kernel, alsa-devel, linux-kernel

If hw params enables dual phase transmission, then the word length for
the second phase should be set to match the sample format instead of
remaining at the reset default.  This matches the configuration already
being done for the first phase.

This driver already sets the phase two sample size, so this should complete
the phase two configuration.

Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
---
 sound/soc/pxa/mmp-sspa.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c
index 52d4d8ace1c3..4803972ee655 100644
--- a/sound/soc/pxa/mmp-sspa.c
+++ b/sound/soc/pxa/mmp-sspa.c
@@ -246,6 +246,9 @@ static int mmp_sspa_hw_params(struct snd_pcm_substream *substream,
 	sspa_ctrl &= ~SSPA_CTL_XWDLEN1_MASK;
 	sspa_ctrl |= SSPA_CTL_XWDLEN1(bitval);
 
+	sspa_ctrl &= ~SSPA_CTL_XWDLEN2_MASK;
+	sspa_ctrl |= SSPA_CTL_XWDLEN2(bitval);
+
 	sspa_ctrl &= ~SSPA_CTL_XSSZ1_MASK;
 	sspa_ctrl |= SSPA_CTL_XSSZ1(bitval);
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: mmp-sspa: set phase two word length register
  2020-11-19  3:41 [PATCH] ASoC: mmp-sspa: set phase two word length register Kyle Russell
@ 2020-11-20 21:29 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-11-20 21:29 UTC (permalink / raw)
  To: Kyle Russell
  Cc: lkundrak, linux-arm-kernel, Haojian Zhuang, Liam Girdwood,
	linux-kernel, Daniel Mack, Takashi Iwai, Robert Jarzmik,
	alsa-devel

On Wed, 18 Nov 2020 22:41:06 -0500, Kyle Russell wrote:
> If hw params enables dual phase transmission, then the word length for
> the second phase should be set to match the sample format instead of
> remaining at the reset default.  This matches the configuration already
> being done for the first phase.
> 
> This driver already sets the phase two sample size, so this should complete
> the phase two configuration.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mmp-sspa: set phase two word length register
      commit: 82d1aeb8a40740cf4208ce864cbcaa5e8bbabf4e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-20 21:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19  3:41 [PATCH] ASoC: mmp-sspa: set phase two word length register Kyle Russell
2020-11-20 21:29 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).