linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] firmware: arm_scmi: remove residual _le structs naming
@ 2020-11-23 16:20 Cristian Marussi
  2020-11-23 16:42 ` Sudeep Holla
  0 siblings, 1 reply; 2+ messages in thread
From: Cristian Marussi @ 2020-11-23 16:20 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel; +Cc: sudeep.holla, Cristian Marussi

For sake of consistency, remove any residual naming based on _le suffixes
in SCMI Sensors Protocol, since little endianity is already assumed across
all of SCMI implementation and, as such, all currently existent names do
not explicitly state their endianness.

No functional change.

Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
Based on for-next/scmi

commit e3811190acf8 ("firmware: arm_scmi: Add SCMI v3.0 sensor notifications")

Thanks

Cristian
---
 drivers/firmware/arm_scmi/sensors.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c
index b3d7c08c09a0..4541b891b733 100644
--- a/drivers/firmware/arm_scmi/sensors.c
+++ b/drivers/firmware/arm_scmi/sensors.c
@@ -168,7 +168,7 @@ struct scmi_resp_sensor_reading_complete {
 	__le64 readings;
 };
 
-struct scmi_sensor_reading_le {
+struct scmi_sensor_reading_resp {
 	__le32 sensor_value_low;
 	__le32 sensor_value_high;
 	__le32 timestamp_low;
@@ -177,7 +177,7 @@ struct scmi_sensor_reading_le {
 
 struct scmi_resp_sensor_reading_complete_v3 {
 	__le32 id;
-	struct scmi_sensor_reading_le readings[];
+	struct scmi_sensor_reading_resp readings[];
 };
 
 struct scmi_sensor_trip_notify_payld {
@@ -189,7 +189,7 @@ struct scmi_sensor_trip_notify_payld {
 struct scmi_sensor_update_notify_payld {
 	__le32 agent_id;
 	__le32 sensor_id;
-	struct scmi_sensor_reading_le readings[];
+	struct scmi_sensor_reading_resp readings[];
 };
 
 struct sensors_info {
@@ -734,7 +734,7 @@ static int scmi_sensor_reading_get(const struct scmi_handle *handle,
 
 static inline void
 scmi_parse_sensor_readings(struct scmi_sensor_reading *out,
-			   const struct scmi_sensor_reading_le *in)
+			   const struct scmi_sensor_reading_resp *in)
 {
 	out->value = get_unaligned_le64((void *)&in->sensor_value_low);
 	out->timestamp = get_unaligned_le64((void *)&in->timestamp_low);
@@ -797,7 +797,7 @@ scmi_sensor_reading_get_timestamped(const struct scmi_handle *handle,
 		ret = scmi_do_xfer(handle, t);
 		if (!ret) {
 			int i;
-			struct scmi_sensor_reading_le *resp_readings;
+			struct scmi_sensor_reading_resp *resp_readings;
 
 			resp_readings = t->rx.buf;
 			for (i = 0; i < count; i++)
@@ -931,7 +931,7 @@ static const struct scmi_event sensor_events[] = {
 		.max_payld_sz =
 			sizeof(struct scmi_sensor_update_notify_payld) +
 			 SCMI_MAX_NUM_SENSOR_AXIS *
-			 sizeof(struct scmi_sensor_reading_le),
+			 sizeof(struct scmi_sensor_reading_resp),
 		.max_report_sz = sizeof(struct scmi_sensor_update_report) +
 				  SCMI_MAX_NUM_SENSOR_AXIS *
 				  sizeof(struct scmi_sensor_reading),
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] firmware: arm_scmi: remove residual _le structs naming
  2020-11-23 16:20 [PATCH] firmware: arm_scmi: remove residual _le structs naming Cristian Marussi
@ 2020-11-23 16:42 ` Sudeep Holla
  0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2020-11-23 16:42 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, Cristian Marussi; +Cc: Sudeep Holla

On Mon, 23 Nov 2020 16:20:08 +0000, Cristian Marussi wrote:
> For sake of consistency, remove any residual naming based on _le suffixes
> in SCMI Sensors Protocol, since little endianity is already assumed across
> all of SCMI implementation and, as such, all currently existent names do
> not explicitly state their endianness.
> 
> No functional change.


Applied to sudeep.holla/linux (for-linux-next), thanks!

[1/1] firmware: arm_scmi: Remove residual _le structs naming
      https://git.kernel.org/sudeep.holla/c/e945927dc7

--
Regards,
Sudeep


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-23 16:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 16:20 [PATCH] firmware: arm_scmi: remove residual _le structs naming Cristian Marussi
2020-11-23 16:42 ` Sudeep Holla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).