[PATCH -next] sched/topology: Mark some symbols with static keyword

[PATCH -next] sched/topology: Mark some symbols with static keyword

[Zou Wei]

Fix the following sparse warnings:

kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?

Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 kernel/sched/topology.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 5d3675c..2676687 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
 #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
 DEFINE_STATIC_KEY_FALSE(sched_energy_present);
 unsigned int sysctl_sched_energy_aware = 1;
-DEFINE_MUTEX(sched_energy_mutex);
-bool sched_energy_update;
+static DEFINE_MUTEX(sched_energy_mutex);
+static bool sched_energy_update;
 
 void rebuild_sched_domains_energy(void)
 {
-- 
2.6.2

Re: [PATCH -next] sched/topology: Mark some symbols with static keyword

[Quentin Perret]

On Tuesday 24 Nov 2020 at 19:52:11 (+0800), Zou Wei wrote:
> Fix the following sparse warnings:
> 
> kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

I think this wants:

Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")

But, with that:

Reviewed-by: Quentin Perret <qperret@google.com>

Thanks,
Quentin

答复: [PATCH -next] sched/topology: Mark some symbols with static keyword

[Zouwei (Samuel)]

Quentin, 
Thanks for the review. I will send the v2 soon.

-----邮件原件-----
发件人: Quentin Perret [mailto:qperret@google.com] 
发送时间: 2020年11月24日 21:24
收件人: Zouwei (Samuel) <zou_wei@huawei.com>
抄送: mingo@redhat.com; peterz@infradead.org; juri.lelli@redhat.com; vincent.guittot@linaro.org; dietmar.eggemann@arm.com; rostedt@goodmis.org; bsegall@google.com; mgorman@suse.de; bristot@redhat.com; linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] sched/topology: Mark some symbols with static keyword

On Tuesday 24 Nov 2020 at 19:52:11 (+0800), Zou Wei wrote:
> Fix the following sparse warnings:
> 
> kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

I think this wants:

Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")

But, with that:

Reviewed-by: Quentin Perret <qperret@google.com>

Thanks,
Quentin