* [PATCH 1/1] iommu/vt-d: Remove set but not used variable
@ 2020-11-27 1:33 Lu Baolu
2020-11-27 9:58 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Lu Baolu @ 2020-11-27 1:33 UTC (permalink / raw)
To: Will Deacon, Joerg Roedel
Cc: iommu, linux-kernel, Lu Baolu, kernel test robot
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/iommu/intel/iommu.c:5643:27: warning: variable 'last_pfn' set but not used [-Wunused-but-set-variable]
5643 | unsigned long start_pfn, last_pfn;
| ^~~~~~~~
This variable is never used, so remove it.
Fixes: 2a2b8eaa5b256 ("iommu: Handle freelists when using deferred flushing in iommu drivers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/intel/iommu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index f9379b4a32fb..8c6c3c0812d2 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -4942,13 +4942,12 @@ static void intel_iommu_tlb_sync(struct iommu_domain *domain,
struct dmar_domain *dmar_domain = to_dmar_domain(domain);
unsigned long iova_pfn = IOVA_PFN(gather->start);
size_t size = gather->end - gather->start;
- unsigned long start_pfn, last_pfn;
+ unsigned long start_pfn;
unsigned long nrpages;
int iommu_id;
nrpages = aligned_nrpages(gather->start, size);
start_pfn = mm_to_dma_pfn(iova_pfn);
- last_pfn = start_pfn + nrpages - 1;
for_each_domain_iommu(iommu_id, dmar_domain)
iommu_flush_iotlb_psi(g_iommus[iommu_id], dmar_domain,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] iommu/vt-d: Remove set but not used variable
2020-11-27 1:33 [PATCH 1/1] iommu/vt-d: Remove set but not used variable Lu Baolu
@ 2020-11-27 9:58 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2020-11-27 9:58 UTC (permalink / raw)
To: Joerg Roedel, Lu Baolu
Cc: catalin.marinas, kernel-team, Will Deacon, iommu, linux-kernel,
kernel test robot
On Fri, 27 Nov 2020 09:33:08 +0800, Lu Baolu wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/iommu/intel/iommu.c:5643:27: warning: variable 'last_pfn' set but not used [-Wunused-but-set-variable]
> 5643 | unsigned long start_pfn, last_pfn;
> | ^~~~~~~~
>
> This variable is never used, so remove it.
Applied to arm64 (for-next/iommu/vt-d), thanks!
[1/1] iommu/vt-d: Remove set but not used variable
https://git.kernel.org/arm64/c/405a43cc0047
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-27 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 1:33 [PATCH 1/1] iommu/vt-d: Remove set but not used variable Lu Baolu
2020-11-27 9:58 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).